Am 13.12.23 um 18:31 schrieb Filip Schauer:
> On 12/12/2023 12:48, Fiona Ebner wrote:
>> Am 12.12.23 um 11:39 schrieb Filip Schauer:
>>> It's actually not a different binary. qemu-system-i386 is a symlink that
>>> points to qemu-system-x86_64. But still this does indeed break migration
>>> between
Already discussed with Stefan off-list yesterday, posting here for the
record:
There is one problem when upgrading from < 8.1.4 with a custom LVM
config where global_filter spans multiple lines, e.g.:
devices {
# added by pve-manager to avoid scanning ZFS zvols
global_filter=["r|/dev/zd
Am 13.12.23 um 17:58 schrieb Filip Schauer:
> @@ -719,6 +731,26 @@ sub get_cpu_from_running_vm {
> return $1;
> }
>
> +sub get_cpu_bitness {
Learned a new word today :)
> +my ($conf, $arch) = @_;
Please pass either the CPU property string or the CPU type directly
instead of the whole
A HTTP DELETE for a built-in target/matcher acts as a reset to its
defaults. This patch changes the 'Remove' button text based on the
selected target/matcher. If it is a built-in, the button text is
changed to 'Reset to default'. Also, if the built-in is not actually
modified, the button is disable
Signed-off-by: Lukas Wagner
---
src/button/Button.js | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/button/Button.js b/src/button/Button.js
index 1f53869..a59a999 100644
--- a/src/button/Button.js
+++ b/src/button/Button.js
@@ -110,6 +110,7 @@ Ext.define('Proxmo
Deleting a built-in target/matcher does not remove it, but resets it
to its default settings. This was not really obvious from the UI.
This patch changes the 'Remove' button text based on the
selected target/matcher. If it is a built-in, the button text is
changed to 'Reset to default'. Also, if
logging in with totp on mobile was broken with these two commits:
pve-manager:
509d7a20 ("mobile ui: implement dummy message box and scrip loader")
and
pve-access-control:
cb64967 ("api: drop old verify_tfa api call")
the pve-manager one overwrote the Ext.MessageBox and Ext.Msg classes and
thus r
On 12/14/23 10:34, Friedrich Weber wrote:
> Not sure how we could extend the global_filter in a reliable way if it
> is customized ... worst case, it might be an option to only rewrite the
> LVM config if it is unchanged (plus our ZFS zvol addition), and leave
> custom configs alone (and add a h
not sure if this was lost at some point or never implemented, but we
want to be consistent with the remaining web ui and apps, so show
the subscription popup here too.
Signed-off-by: Dominik Csapak
---
www/mobile/Workspace.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/mobile/Works
On 12/14/23 10:55, Stefan Hanreich wrote:
> Yes, at this point I'm also not sure there is a sane way to handle this.
doing it for new installations should be possible though
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmo
On 14/12/2023 10:56, Stefan Hanreich wrote:> On 12/14/23 10:55, Stefan
Hanreich wrote:
>> Yes, at this point I'm also not sure there is a sane way to handle this.
>
> doing it for new installations should be possible though
Yeah, I'd agree that it's probably the safest to not rewrite existing
glo
with custom build date format, which would prevent the panel from loading.
Signed-off-by: Fiona Ebner
---
www/manager6/node/StatusView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
index 24b2c8d8..0ac200c7
Lukas Wagner writes:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner
Tested both
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is not
supported on 32-bit CPU types.
To obtain a list of 32-bit CPU types, refer to the builtin_x86_defs in
target/i386/cpu.c of QEMU. Exclude any entries that
Patch v6 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061097.html
On 14/12/2023 10:46, Fiona Ebner wrote:
Am 13.12.23 um 17:58 schrieb Filip Schauer:
@@ -719,6 +731,26 @@ sub get_cpu_from_running_vm {
return $1;
}
+sub get_cpu_bitness {
Learned a new word
... as using PVEContext for tests is brittle and annoying for some
tests.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context/mod.rs | 10 +-
proxmox-notify/src/context/test.rs | 26 ++
2 files changed, 31 insertions(+), 5 deletions(-)
create mode 100644
by a matcher.
In the 'delete'-handler targets, we check if a
target is still referenced by a matcher - if it is, we return an
error. For built-in targets, this is actually not necessary, since
'deleting' a built-in only resets it to its default settings - it will
continue to exist after that.
The
Am 14/12/2023 um 11:34 schrieb Fiona Ebner:
> with custom build date format, which would prevent the panel from loading.
>
> Signed-off-by: Fiona Ebner
> ---
> www/manager6/node/StatusView.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
Am 07.12.23 um 10:12 schrieb Hannes Duerr:
> During migration, the volume names may change if the name is already in
> use at the target location. We therefore want to save the original names
> before the migration so that we can clean up the original volumes
> afterwards.
>
Good catch! I think '
Bump :)
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
The helpers were split out from the original 'sendmail' function when
migrating to the new notification system. They are not needed anywhere
else and can thus be private.
Signed-off-by: Lukas Wagner
---
PVE/VZDump.pm | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE
The old backup job notification mails from before the notification
system overhaul included the total time as well as the total size.
The total size was missing from the new, template-based backup report,
thus we add it back in this commit.
Signed-off-by: Lukas Wagner
---
PVE/VZDump.pm | 24 +++
Am 07.12.23 um 10:12 schrieb Hannes Duerr:
> for base images we call the volume_import of the parent plugin and pass
> it as vm-image instead of base-image, then convert it back as base-image
>
> Signed-off-by: Hannes Duerr
> ---
> src/PVE/Storage/LvmThinPlugin.pm | 60 ++
Am 14.12.23 um 15:23 schrieb Fiona Ebner:
> Am 07.12.23 um 10:12 schrieb Hannes Duerr:
>> +
>> +($storeid, $volname) = split (/:/, $class->SUPER::volume_import(
>
> Using parse_volid() would be more robust than using an ad-hoc split.
>
Sorry, I meant:
PVE::Storage::parse_volume_id()
Signed-off-by: Hannes Duerr
---
pve-firewall.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-firewall.adoc b/pve-firewall.adoc
index 836a51c..a5e40f9 100644
--- a/pve-firewall.adoc
+++ b/pve-firewall.adoc
@@ -562,7 +562,7 @@ and add `ip_conntrack_ftp` to `/etc/modules
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp/Plugin.pm | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Network/SDN/Dhcp/Plugin.pm
b/src/PVE/Network/SDN/Dhcp/Plugin.pm
index b99f598..6e985cd 100644
--- a/src/PVE/Network/SDN/Dhcp/Plugin.pm
++
Stefan Hanreich (3):
dhcp: fix function signatures in abstract class
zones: add method for getting MTU
dhcp: dnsmasq: send mtu option via dhcp
src/PVE/Network/SDN/Dhcp.pm | 2 +-
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 7 ++-
src/PVE/Network/SDN/Dhcp/Plugin.pm
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Zones.pm | 8
src/PVE/Network/SDN/Zones/Plugin.pm | 7 +++
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 8 +++-
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones.pm b/s
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp.pm | 2 +-
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 7 ++-
src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/SDN/Dhcp.pm
inde
29 matches
Mail list logo
