On 14/12/2023 10:56, Stefan Hanreich wrote:> On 12/14/23 10:55, Stefan Hanreich wrote: >> Yes, at this point I'm also not sure there is a sane way to handle this. > > doing it for new installations should be possible though
Yeah, I'd agree that it's probably the safest to not rewrite existing global_filters. So we could just update the snippet that is added by the pve-manager postinst to also include the rbd filter, but keep the general rewriting logic the same (meaning, we do not touch the file if it contains LVM_CONF_MARKER). And then add some check to pve7to8 and a note to the upgrade guide. I think even then, we would get a kind-of automatic migration path for free (I haven't actually tested this though): When upgrading from PVE 7 to 8, users are (IIRC always) asked whether they want to keep /etc/lvm/lvm.conf or install the package maintainers version. If they choose the package maintainers version (which seems reasonable if they never edited the LVM config), lvm.conf is replaced with the upstream lvm default config, and subsequently our pve-manager postinst would add the global filter again, but this time with the rbd filter? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
