Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Wolfgang Bumiller
On Thu, Oct 19, 2023 at 02:18:56PM +0200, Filip Schauer wrote: > Signed-off-by: Filip Schauer > --- > Is it reasonable to add a "dev[n]" argument to the pct.conf, given that > device mount points only allow passing through block devices? Why would they only allow block devices? Also, Dominik rec

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Dominik Csapak
On 10/20/23 09:08, Wolfgang Bumiller wrote: On Thu, Oct 19, 2023 at 02:18:56PM +0200, Filip Schauer wrote: Signed-off-by: Filip Schauer --- Is it reasonable to add a "dev[n]" argument to the pct.conf, given that device mount points only allow passing through block devices? Why would they only

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Thomas Lamprecht
Am 20/10/2023 um 09:51 schrieb Dominik Csapak: > On 10/20/23 09:08, Wolfgang Bumiller wrote: >> Also, Dominik recently added resource mappings for qemu for USB & PCI. >> PCI might be tricky, but for USB we may be able to use these mappings as >> well. >> That said, "raw" `/dev` node pass-through st

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Dominik Csapak
On 10/20/23 10:29, Thomas Lamprecht wrote: Am 20/10/2023 um 09:51 schrieb Dominik Csapak: On 10/20/23 09:08, Wolfgang Bumiller wrote: Also, Dominik recently added resource mappings for qemu for USB & PCI. PCI might be tricky, but for USB we may be able to use these mappings as well. That said,

Re: [pve-devel] [PATCH v3 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-20 Thread Dominik Csapak
hi, nice elegant solution for not needing to change the config or introducing a new file :) there is one caveats with this solution, but that should not matter for most situations: in case the configured portal is not accessible, any new node in the cluster (or one that did not activate the sto

[pve-devel] [PATCH installer 1/5] net: move hostname/fqdn regexes into common code

2023-10-20 Thread Christoph Heiss
Such that they can be re-used by other parts. No functional changes. Signed-off-by: Christoph Heiss --- Proxmox/Sys/Net.pm | 3 +++ proxinstall| 9 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm index ba368c1..f5a9885 1006

[pve-devel] [PATCH installer 4/5] tui: use hostname from run env if available

2023-10-20 Thread Christoph Heiss
This now tries to use the hostname from the DHCP lease if it was set, falling back to the product name as before. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs | 22 +++--- proxmox-tui-installer/src/setup.rs | 3 +++ 2 files changed, 18 insertions(+),

[pve-devel] [PATCH installer 2/5] run env: retrieve and store hostname from DHCP lease if available

2023-10-20 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Proxmox/Install/RunEnv.pm | 4 Proxmox/Sys/Net.pm| 25 + 2 files changed, 29 insertions(+) diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm index 19b5387..7589679 100644 --- a/Proxmox/Install/RunEnv.pm +++

[pve-devel] [PATCH installer 0/5] use hostname from DHCP lease if available

2023-10-20 Thread Christoph Heiss
DHCP servers can set option 12 ("host-name") for client leases [0], telling them about their hostname. It's very much non-invasive and falls back to the default values as done currently. This came up while talking to Aaron, which he noticed (esp. during trainings) that this would be a very useful

[pve-devel] [PATCH installer 5/5] tui: add some tests for `NetworkInfo` -> `NetworkOptions` conversion

2023-10-20 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs | 110 ++- proxmox-tui-installer/src/utils.rs | 2 +- 2 files changed, 110 insertions(+), 2 deletions(-) diff --git a/proxmox-tui-installer/src/options.rs b/proxmox-tui-installer/src/options.rs i

[pve-devel] [PATCH installer 3/5] proxinstall: use hostname from run env if available

2023-10-20 Thread Christoph Heiss
This now tries to use the hostname from the DHCP lease if it was set, falling back to the product name as before. Signed-off-by: Christoph Heiss --- proxinstall | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/proxinstall b/proxinstall index 88f194f..4d61fa7 100755 --- a

Re: [pve-devel] [PATCH manager v2 4/5] ui: GuestStatusView: show privileged status as new row

2023-10-20 Thread Dominik Csapak
one small comment inline On 7/5/23 13:12, Christoph Heiss wrote: As that info is not available through the store (which stores the status), it must be fetched separately. Signed-off-by: Christoph Heiss --- www/manager6/panel/GuestStatusView.js | 32 +++ 1 file change

Re: [pve-devel] [PATCH manager v2 5/5] ui: GuestStatusView: show distro logo and name in summary header

2023-10-20 Thread Dominik Csapak
one small comment inline On 7/5/23 13:12, Christoph Heiss wrote: It fits neatly there, is rather unintrusive and yet still visible at first sight. It also solves the problem of having to create a bigger row, so that the icon is still easily recognisable. At the default font-size of 13pt, this re

Re: [pve-devel] [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary

2023-10-20 Thread Dominik Csapak
the series looks mostly fine to me, i wrote two small comments in the relevant patches, but both are not super important to fix IMO aside from that consider this series Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak ___ pve-devel mailing lis

[pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available

2023-10-20 Thread Thomas Lamprecht
Am 20/10/2023 um 11:46 schrieb Christoph Heiss: > DHCP servers can set option 12 ("host-name") for client leases [0], > telling them about their hostname. It's very much non-invasive and falls > back to the default values as done currently. > > This came up while talking to Aaron, which he noticed

[pve-devel] applied: [PATCH v2 debcargo-conf 01/11] package mail-parser 0.8.2

2023-10-20 Thread Thomas Lamprecht
Am 02/10/2023 um 10:06 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > src/mail-parser/debian/changelog | 6 ++ > src/mail-parser/debian/copyright | 49 > .../debian/copyright.debcargo.hint| 77 +++ > src/mail-parser/

Re: [pve-devel] [PATCH v3 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-20 Thread Yuri Konotopov via pve-devel
--- Begin Message --- 20.10.2023 13:23, Dominik Csapak пишет: hi, Hi, Dominik! Thanks for review! I will address all issues in the next patch version. in case the configured portal is not accessible, any new node in the cluster (or one that did not activate the storage until then) will not