Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Philipp Hufnagl
> There are code paths where $filename is not yet defined here, resulting > in a rather ugly warning – so this needs upfront checking too – always > check where the value code path is coming in (yeah, Rust would do that for > you, but most API endpoints are small enough to be able to do so quickly

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Thomas Lamprecht
Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl: >> There are code paths where $filename is not yet defined here, resulting >> in a rather ugly warning – so this needs upfront checking too – always >> check where the value code path is coming in (yeah, Rust would do that for >> you, but most API end

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Philipp Hufnagl
On 9/27/23 10:33, Thomas Lamprecht wrote: > Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl: >>> There are code paths where $filename is not yet defined here, resulting >>> in a rather ugly warning – so this needs upfront checking too – always >>> check where the value code path is coming in (yeah,

Re: [pve-devel] [RFC manager/container/qemu-server/guest-common 0/4] fix #4474: stop tasks may overrule shutdown tasks

2023-09-27 Thread Friedrich Weber
Lost track of this a bit, reviving due to user interest [1]. As the series does not apply anymore, I'll send a new version in any case, but wanted to ask for feedback before I do. My questions from the cover letter still apply: On 26/01/2023 09:32, Friedrich Weber wrote: > * Does it make sense t

Re: [pve-devel] Thank you for being part of pve-devel

2023-09-27 Thread Dominik Csapak
On 9/26/23 00:34, Alexandre Aguirre via pve-devel wrote: Hello goodnight ! My name is Alexandre, I'm Brazilian and I've been a proxmox user since 2015, I'm an active collaborator in BR communities as well as groups on Telegram and WhatsApp, I'd like to know how I can collaborate with the soluti

Re: [pve-devel] applied: [PATCH v3 docs 1/1] fix #2920: add cifs options parameter

2023-09-27 Thread Friedrich Weber
Is it possible that this pve-docs patch got lost and was not actually applied? At least I don't see it here: https://git.proxmox.com/?p=pve-docs.git;a=history;f=pve-storage-cifs.adoc;h=df63b58d6eefc5c7e2ee302e4ac57fa52c8c372e;hb=0aa61e04787ca6ac791fe6bce28686c9a9fc9ade ... whereas the pve-storage

[pve-devel] applied: [PATCH v3 docs 1/1] fix #2920: add cifs options parameter

2023-09-27 Thread Thomas Lamprecht
Am 01/03/2023 um 13:13 schrieb Fiona Ebner: > From: Stefan Hrdlicka > > Signed-off-by: Stefan Hrdlicka > [FE: rebase + style fix] > Signed-off-by: Fiona Ebner > --- > > Changes from v2: > * use {pve} instead of PVE > > pve-storage-cifs.adoc | 8 > 1 file changed, 8 insertions(+)

[pve-devel] applied: [PATCH manager master stable-7] pve7to8: Fix Fedora 38 systemd unified cgroupv2 check

2023-09-27 Thread Thomas Lamprecht
Am 28/08/2023 um 09:54 schrieb Christian Ebner: > For Fedora 38 the systemd shared object files used to check the systemd > version are located at /usr/lib64/systemd or /usr/lib/systemd. > Therefore, include /usr/lib64/systemd in the list of directories to > check. > > Further, Fedora 38 adds a fc

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Thomas Lamprecht
Am 27/09/2023 um 10:57 schrieb Philipp Hufnagl: > On 9/27/23 10:33, Thomas Lamprecht wrote: >> FYI, I have a pretty much done patch for this already here, so if >> you did not have anything (close to) already finished, I could push >> that out – just mentioning to avoid potential duplicate work. >

[pve-devel] applied-series: [PATCH v3 stable-7+master manager 1/3] ui: vm selector: gracefully handle empty IDs in setValue function

2023-09-27 Thread Thomas Lamprecht
Am 25/09/2023 um 13:58 schrieb Fiona Ebner: > An empty string is passed by the backup job window when using > selection mode 'all', would be converted to [""] and wrongly add an > entry with VMID 0 because the item "" could not be found in the store. > > Reported in the community forum: > https://

[pve-devel] applied: [PATCH v2 stable-7 manager] pve7to8: Add check for dkms modules

2023-09-27 Thread Thomas Lamprecht
Am 01/08/2023 um 10:42 schrieb Christian Ebner: > ... and warn if at least one is present. > > Signed-off-by: Christian Ebner > --- > > changes since v1: > * do not use which to check for dkms, use exit code directly > > PVE/CLI/pve7to8.pm | 22 ++ > 1 file changed, 22 inse

[pve-devel] [PATCH v3 qemu-server 0/2] remote-migration: migration with different cpu

2023-09-27 Thread Alexandre Derumier
This patch series allow remote migration between cluster with different cpu model. 2 new params are introduced: "target-cpu" && "target-reboot" If target-cpu is defined, this will replace the cpu model of the target vm. If vm is online/running, an extra "target-reboot" safeguard option is neede

[pve-devel] [PATCH v3 qemu-server 1/2] migration: move livemigration code in a dedicated sub

2023-09-27 Thread Alexandre Derumier
--- PVE/QemuMigrate.pm | 420 +++-- 1 file changed, 214 insertions(+), 206 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index f41c61f..5ea78a7 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -726,6 +726,219 @@ sub cleanup_bi

[pve-devel] [PATCH v3 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-09-27 Thread Alexandre Derumier
This patch add support for remote migration when target cpu model is different. target-reboot param need to be defined to allow migration whens source vm is online. When defined, only the live storage migration is done, and instead to transfert memory, we cleanly shutdown source vm and restart th