[pve-devel] applied: [PATCH-SERIES qemu-server] migration: nbd alloc: improve format fallback

2023-07-27 Thread Fabian Grünbichler
thanks! (once more for the list ;)) On July 17, 2023 4:00 pm, Fiona Ebner wrote: > Currently, remote migration behaves a bit differently, because an > explicitly passed-in format that is not supported by the target > storage is not overwritten with the storage's default format. > > This meant rem

[pve-devel] [PATCH v3 manager/container/guest-common/docs 1/5] api: backup: refactor backup permission check

2023-07-27 Thread Alexander Zeidler
Alter style to make the parameter check more concise Signed-off-by: Alexander Zeidler --- Changes since v2: * none Changes since v1: Apply Fiona's comments: * shorten permission check PVE/API2/Backup.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Backup.

[pve-devel] [PATCH v3 guest-common 4/5] fix #3069: vzdump: schema: add 'pbs-entries-max' property

2023-07-27 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes since v2: Apply Fiona's comments: * rephrase description * fix dot style nit Changes since v1: * improve de

[pve-devel] [PATCH v3 docs 5/5] vzdump: mention new parameter 'pbs-entries-max'

2023-07-27 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes since v2: * add this commit vzdump.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/v

[pve-devel] [PATCH v3 manager 2/5] fix #3069: vzdump: add property 'performance: pbs-entries-max=N'

2023-07-27 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes since v2: Apply Fiona's comments: * remove property from permission check since it's included in performance *

[pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter

2023-07-27 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes since v2: Apply Fiona's comments: * fix parameter check * fix both style nits Changes since v1: * reword lo

[pve-devel] [PATCH v3 manager/container/guest-common/docs 0/5] fix #3069: add pbs-entries-max to vzdump.conf

2023-07-27 Thread Alexander Zeidler
Users reported[1] about failing container backups to PBS when having a large amount of files in a directory. proxmox-backup-client has already 'entries-max' implemented. The default value prevents out of memory (OOM) situations. Overriding this parameter needs at least 'Sys.Modify' permissions.

[pve-devel] applied: [PATCH v2 manager 1/4] api: backup: refactor backup permission check

2023-07-27 Thread Fabian Grünbichler
applied this one with R-B, thanks! On July 7, 2023 2:53 pm, Fiona Ebner wrote: > Am 15.06.23 um 16:14 schrieb Alexander Zeidler: >> Alter style to make the parameter check more concise >> >> Signed-off-by: Alexander Zeidler > > Reviewed-by: Fiona Ebner > >> --- >> Changes from v1: >> Shorten

[pve-devel] [PATCH manager 3/3] ui: ldap: ad: replace occurences of SSL with TLS

2023-07-27 Thread Lukas Wagner
Although 'SSL' is used colloquially, the proper term is 'TLS'. Signed-off-by: Lukas Wagner --- www/manager6/dc/AuthEditAD.js | 2 +- www/manager6/dc/AuthEditLDAP.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/AuthEditAD.js b/www/manager6/dc/AuthEditAD

[pve-devel] [PATCH manager 2/3] ui: ldap: ad: fix typo for verify certificate combobox

2023-07-27 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- www/manager6/dc/AuthEditAD.js | 2 +- www/manager6/dc/AuthEditLDAP.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/AuthEditAD.js b/www/manager6/dc/AuthEditAD.js index bd46faaa..41390a47 100644 --- a/www/manager6/dc/AuthEd

[pve-devel] [PATCH manager 1/3] ui: ldap: ad: support 'mode' paramter, replacing 'secure'

2023-07-27 Thread Lukas Wagner
The backend has supported the 'mode' parameter for quite a while, however it has not yet been exposed in the GUI, contrary to PMG and PBS. The benefit of 'mode' is that it supports LDAP, LDAPS and LDAP via STARTTLS, compared to just LDAP/LDAPS for the 'secure' parameter. The modified AuthEdit{LDA

Re: [pve-devel] [PATCH v3 manager 2/5] fix #3069: vzdump: add property 'performance: pbs-entries-max=N'

2023-07-27 Thread Fiona Ebner
Am 27.07.23 um 10:37 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler > --- > Changes since v2: > Apply Fiona's comments: > * remove prope

[pve-devel] [PATCH v2 qemu-server] cfg2cmd: netdev: fix value for tx_queue_size

2023-07-27 Thread Fiona Ebner
Quoting from QEMU commit 4271f40383 ("virtio-net: correctly report maximum tx_queue_size value"): > Maximum value for tx_queue_size depends on the backend type. > 1024 for vDPA/vhost-user, 256 for all the others. > So the parameter is silently ignored and ethtool reports a different > value than

Re: [pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter

2023-07-27 Thread Fiona Ebner
Am 27.07.23 um 10:37 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler Reviewed-by: Fiona Ebner > diff --git a/src/PVE/VZDump/LXC.pm b/src/P

Re: [pve-devel] [PATCH v3 guest-common 4/5] fix #3069: vzdump: schema: add 'pbs-entries-max' property

2023-07-27 Thread Fiona Ebner
Am 27.07.23 um 10:37 schrieb Alexander Zeidler: > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index 31e9fdb..ba4a61a 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -88,6 +88,16 @@ PVE::JSONSchema::register_format('backup-performance', { >

[pve-devel] [PATCH widget-toolkit 0/1]ui: Extend BandwithSelector with selecatble units

2023-07-27 Thread Noel Ullreich
Work in progress! But today is my last day and I want to send what I have. While writing a fix for `#3760: change units of ram/swap`, Fiona pointed out that I should extend `BandwithSelector.js` to not have duplicate code and make it easier to implement widgets like this in the future. This patch

[pve-devel] [PATCH widget-toolkit] ui: Extend BandwithSelector with selecatble units

2023-07-27 Thread Noel Ullreich
Work in progress! But today is my last day and I want to send what I have. Comments and TODOS on what needs to still be done and what doesn't work are inline. Extends the BandwithSelector to add features: * selectable units via dropdown menu * pass lists of minvalues/stepsize (TODO: maxvalue) for

Re: [pve-devel] [PATCH common/access-control v2 0/5] improve LDAP DN and bind creds checking on creation/change

2023-07-27 Thread Lukas Wagner
On 7/24/23 11:03, Christoph Heiss wrote: tl;dr implements the result of the discussion in [0]. First, this removes the dreaded LDAP DN regex, replacing it instead with a proper schema format, which does validation using Net::LDAP::Util::canonical_dn(). Already discussed off-list, but for the s

[pve-devel] [PATCH pve-manager 2/2] ui: fix: change units of memory/swap for containers

2023-07-27 Thread Noel Ullreich
This patch adds a dropdown-menu (in the web interface) of units, MiB, GiB, and TiB, (although PiB could easily be added in the future) for ram and swapsize of containers. Signed-off-by: Noel Ullreich --- www/manager6/lxc/ResourceEdit.js | 59 +--- 1 file changed, 39 i

[pve-devel] [PATCH pve-manager 0/2] change unit of memory for ct/vm

2023-07-27 Thread Noel Ullreich
WORK IN PROGRESS! Today is my last day and I wanted to send what I have. This patch utilizes the changes in `BandwidthSelector.js` (see https://lists.proxmox.com/pipermail/pve-devel/2023-July/058538.html) to streamline the implementation of a unit-changing widget. Noel Ullreich (2): ui: fix #37

[pve-devel] [PATCH pve-manager 1/2] ui: fix #3760: change unit of memory of a VM

2023-07-27 Thread Noel Ullreich
This patch adds a dropdown-menu (in the web interface) of units, MiB, GiB, and TiB, (although PiB could easily be added in the future) for ram and balloonsize of VMs. Signed-off-by: Noel Ullreich --- www/manager6/qemu/MemoryEdit.js | 91 ++--- 1 file changed, 38 inser

[pve-devel] [PATCH docs 1/3] fix #4847: network: extend section on interface naming scheme

2023-07-27 Thread Friedrich Weber
Expand the existing section on systemd network interface names with a link to the systemd.net-naming-scheme(7) manpage and some information about naming scheme versions. Also mention the possibility of interface naming changes due to a new naming scheme version, or kernel/driver updates. This happe

[pve-devel] [PATCH+RFC docs/common 0/3] fix #4847: network: custom naming for network devices

2023-07-27 Thread Friedrich Weber
Patch #1 expands the documentation on custom network interface names, including the usage of systemd.link files to assign custom names to network interfaces. Patch #2 and #3 are optional and marked as RFC, with the following reasoning. Working on patch #1, I noticed that PVE only recognizes interf

[pve-devel] [RFC common 3/3] network: recognize interfaces matching `c*` as physical NICs

2023-07-27 Thread Friedrich Weber
Users can use systemd link files to assign meaningful interface names to physical NICs. However, so far PVE only recognizes interface names `ethN`, `en*` and `ib*` as physical NICs. NICs not matching these patterns cannot be configured via the GUI (their type is "Unknown"). To allow users to choos

[pve-devel] [RFC docs 2/3] network: describe and recommend `c*` names for custom interface

2023-07-27 Thread Friedrich Weber
Signed-off-by: Friedrich Weber --- pve-network.adoc | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index b2202cc..bd6a15d 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -71,6 +71,9 @@ We currently use the foll

[pve-devel] applied: [PATCH v2 qemu-server] cfg2cmd: netdev: fix value for tx_queue_size

2023-07-27 Thread Fabian Grünbichler
so that you can already include the Breaks in your pve-qemu-kvm series/update ;) On July 27, 2023 11:10 am, Fiona Ebner wrote: > Quoting from QEMU commit 4271f40383 ("virtio-net: correctly report > maximum tx_queue_size value"): > >> Maximum value for tx_queue_size depends on the backend type. >>

[pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

2023-07-27 Thread Lukas Wagner
Before, there was zero space between the the grid border line and the button, making it look a bit odd. The ListField form component is currently used in the 'User Tag Access' and 'Registered Tags' dialog windows in datacenter option view. Signed-off-by: Lukas Wagner --- www/manager6/form/ListF

[pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option

2023-07-27 Thread Christoph Heiss
The checkbox is enabled by default for new realms, setting the new `check-connection` parameter. Won't effect existing configurations, i.e. being opt-in for them, to not break existing setups. Signed-off-by: Christoph Heiss --- As this uses the newly introduced `check-connection` API parameter,

[pve-devel] [PATCH access-control 1/2] api: domains: add off-by-default `check-connection` parameter

2023-07-27 Thread Christoph Heiss
Removes the dreaded DN regex, instead introducing a connect/bind check on creation/update, aligning it with the way PBS does it. This is enabled by default for new realms, but opt-in for existing, to not break backwards-compatibility. Additionally, it has the benefit that instead of letting a sync

[pve-devel] [PATCH access-control/manager 0/2] ldap: check bind connection on realm add/update

2023-07-27 Thread Christoph Heiss
First of, this removes the dreaded LDAP DN regex. Further, upon saving a LDAP realm in the UI, it tries to connect & bind using the provided credentials, providing the user with immediate feedback whether they are valid or not. The same approach is already implemented in PBS [0], and I'll plan to

[pve-devel] [PATCH V2 common 1/1] fix #4849: download file from url: add opt parameter for a decompression command

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Tools.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 9ffac12..d9869e8 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -2059,6 +2059,15 @@ sub download_file_from_url { } print

[pve-devel] [PATCH V2 storage/manager/common 0/3] allow download of compressed ISOs

2023-07-27 Thread Philipp Hufnagl
Many web pages offer the download of the disk images compressed. This patch allows the download of archives (like .gz), automatically detects the format and decompresses it Philipp Hufnagl (1): fix #4849: download-url: allow download and decompression of compressed ISOs src/PVE/API2/Storag

[pve-devel] [PATCH V2 storage 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 22 +++--- src/PVE/Storage.pm | 6 ++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index 2aaeff6..a087c53 100644

[pve-devel] [PATCH V2 manager 1/1] fix #4849: download to storage: automatically dectect and configure compression

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 21 - www/manager6/Makefile | 1 + www/manager6/form/DecompressionSelector.js | 14 ++ www/manager6/window/DownloadUrlToStorage.js | 21 +++-- 4