Thanks!
On Tue, Feb 21, 2023 at 06:07:20PM +0100, Thomas Lamprecht wrote:
> Am 21/02/2023 um 09:05 schrieb Christoph Heiss:
> > [..]
> >
>
> applied, thanks! But I got some feedback/question inline affecting patch 3/4
>
> > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> > index cbbb82d..d419124 10
The goal for this small series is to make it easier/more obvious to see
that there are potentially more details for a warning ceph is showing
by:
- having a tooltip with the details (limited in length)
- making the detail/info button more visible
This will hopefully reduce the time spent on figuri
This is another step to make it easier for admins to discover more
information for a warning or problem that is shown in the Ceph health
panel.
The length is limited to give a first glimpse. For the full details one
can click on the info/detail button.
Signed-off-by: Aaron Lauterer
---
www/mana
The button for more details is barely noticable as something one can
click on. By making it more obvious that it is a button, users will
hopefully notice it easier.
Signed-off-by: Aaron Lauterer
---
While moving code around I also changed:
- var -> let
- string concat to template literals
www/
This is another step to make it easier for admins to discover more
information for a warning or problem that is shown in the Ceph health
panel.
The length is limited to give a first glimpse. For the full details one
can click on the info/detail button.
Signed-off-by: Aaron Lauterer
---
Please us
On Tue, Feb 21, 2023 at 06:25:39PM +0100, Thomas Lamprecht wrote:
> Am 21/02/2023 um 09:05 schrieb Christoph Heiss:
> > If this network option is set, the host-side link will be forced down
> > and the interface won't be connected to the bridge.
> >
> > Signed-off-by: Christoph Heiss
> > ---
> > C
Am 22/02/2023 um 08:51 schrieb Dominik Csapak:
> this series allows configuring the sorting of the resource tree
>
> options are the sort-field, if guest types are grouped and if templates
> are grouped seperately. it's configurable via browser local storage
>
> the first 2 patches are not really
by updating them on every change, but if the window is closed
without pressing ok, revert to the original settings
moves the fireUIConfigChanged call inside the window, since we
have to call it from inside too
Signed-off-by: Dominik Csapak
---
one weird 'feature': if one changes a value and then
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* Rename option to kebap-case
Changes v2 -> v3:
* Rename option to snake_case again
Changes v3 -> v4:
* Rebase
Q: Since this depends on an updated API endpoint from pve-container, the
minimal required 'Depends' version for pve-container pr
If this network option is set, the host-side link will be forced down
and the interface won't be connected to the bridge.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* Split trailing whitespace fix into separate patch
* Rename option to kebap-case
* Proper option comparison using `saf
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v3 -> v4:
* New patch
A note: The check in net_tap_plug() whether the MAC address is actually
passed in $opts is removed, as this was always the case anyway.
src/PVE/LXC.pm | 20 +---
src/lxcnetaddbr | 9 +
Add a `Disconnect` option for network interfaces on LXC containers, much
like it already exists for VMs. This has been requested in #3413 [0] and
seems useful, especially considering we already support the same thing
for VMs.
One thing to note is that LXC does not seem to support the notion of
set
Displays a confirmation dialogue if the user didn't explicitly
provide a valid ceph version via the `--version` flag and if
stdout is connected to a tty.
Signed-off-by: Max Carrara
---
PVE/CLI/pveceph.pm | 13 +
1 file changed, 13 insertions(+)
Note: This was tested in a VM, with an
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm
> index 32fbdc5..deeb88f 100644
> --- a/PVE/QemuServer/Memory.pm
> +++ b/PVE/QemuServer/Memory.pm
> @@ -3,8 +3,10 @@ package PVE::QemuServer::Memory;
> use strict;
> use warnings;
>
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 9b80da1..6627910 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -32,7 +32,7 @@ use PVE::QemuServer::Drive;
> use PVE::QemuServer::ImportDisk;
> use PVE::QemuServer::Monitor q
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> current qemu_dimm_list can return any kind of memory devices.
>
> make it more generic, with a regex filter to choose kind of device
> from id.
>
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer/Memory.pm | 8
> 1 file change
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm
> index 1b1c99d..bf4e92a 100644
> --- a/PVE/QemuServer/Memory.pm
> +++ b/PVE/QemuServer/Memory.pm
> @@ -3,6 +3,8 @@ package PVE::QemuServer::Memory;
> use strict;
> use warnings;
>
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> @@ -322,30 +290,33 @@ sub qemu_memory_hotplug {
>
> } else {
>
> - foreach_reverse_dimm($conf, $vmid, $value, $sockets, sub {
> - my ($conf, $vmid, $name, $dimm_size, $numanode, $current_size,
> $memory) = @_;
> + my $dimm
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> If some memory can be removed on a specific node,
> we try to rebalance again on other nodes
>
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer/Memory.pm | 51 +++-
> 1 file changed, 35 insertions(+)
Am 13.02.23 um 13:00 schrieb Alexandre Derumier:
> This patch series rework the current memory hotplug + virtiomem.
>
> memory option now have extra options:
>
> memory: [[current=]] [,max=] [,virtio=<1|0>]
> ex: memory: current=1024,max=131072,virtio=1
>
>
> for classic memory hotplug, when ma
Hi,
> > +PVE::JSONSchema::register_format('pve-qm-memory-max',
> > \&verify_qm_memory_max);
> > +sub verify_qm_memory_max {
> > + my ($max, $noerr) = @_;
> > +
> > + return if $noerr;
>
> $noerr only switches if the function should die upon error or return
> undef upon error. But if there i
Am 23.02.23 um 08:35 schrieb DERUMIER, Alexandre:
> Hi,
>
>>> +PVE::JSONSchema::register_format('pve-qm-memory-max',
>>> \&verify_qm_memory_max);
>>> +sub verify_qm_memory_max {
>>> + my ($max, $noerr) = @_;
>>> +
>>> + return if $noerr;
>>
>> $noerr only switches if the function should die
22 matches
Mail list logo
