Am 13.02.23 um 13:00 schrieb Alexandre Derumier: > This patch series rework the current memory hotplug + virtiomem. > > memory option now have extra options: > > memory: [[current=]<integer>] [,max=<enum>] [,virtio=<1|0>] > ex: memory: current=1024,max=131072,virtio=1 > > > for classic memory hotplug, when maxmemory is defined, > we use 64 fixed size dimm. > The max option is a multiple of 64GB. > > The virtio option enable new virtio-mem support, > instead of plugging dimm, it's add/removed block inside > big dimm. > virtio-mem can use 32000 blocks, the blocksize is compute from > max memory. > > Looking good :) I just have a few suggestions for further improvements and there's a wrong function call in 11/16. Consider everything with no answer (or with just nits if you don't change the patch): Reviewed-by: Fiona Ebner <f.eb...@proxmox.com>
Still, would be nice if you could address (some of) the nits too. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
