lgtm. consider this:
Reviewed-by: Stefan Sterz
On 12/15/22 15:20, Noel Ullreich wrote:
> updated the tags doc with slight rephrasing, corrected grammar,
> and fixed typos.
>
> Signed-off-by: Noel Ullreich
> ---
> changes since v1:
> * removed changes in datacenter.cfg.5-opts.adoc since it is a
Am 16.12.22 um 16:08 schrieb Stefan Sterz:
> when a vm is configured to use the physical cd rom drive but there is
> no such drive a cryptic "uninitialized value" error is thrown. this
> is due to the `$path` not being defined in `sub
> print_drive_commandline_full` in this case. warn that no cd ro
On 12/19/22 10:23, Fiona Ebner wrote:
> Am 16.12.22 um 16:08 schrieb Stefan Sterz:
>> when a vm is configured to use the physical cd rom drive but there is
>> no such drive a cryptic "uninitialized value" error is thrown. this
>> is due to the `$path` not being defined in `sub
>> print_drive_comman
when a vm is configured to use the physical cd rom drive but there is
no such drive a cryptic "uninitialized value" error is thrown. this
is due to `$path` not being defined in `sub
print_drive_commandline_full` in this case. warn that no cd rom drive
is available and default back to using "none" a
Am 19.12.22 um 12:14 schrieb Stefan Sterz:
> when a vm is configured to use the physical cd rom drive but there is
> no such drive a cryptic "uninitialized value" error is thrown. this
> is due to `$path` not being defined in `sub
> print_drive_commandline_full` in this case. warn that no cd rom dr
On 12/19/22 10:23, Fiona Ebner wrote:
> Am 16.12.22 um 16:08 schrieb Stefan Sterz:
>> when a vm is configured to use the physical cd rom drive but there is
>> no such drive a cryptic "uninitialized value" error is thrown. this
>> is due to the `$path` not being defined in `sub
>> print_drive_comman
On 12/19/22 12:23, Fiona Ebner wrote:
> Am 19.12.22 um 12:14 schrieb Stefan Sterz:
>> when a vm is configured to use the physical cd rom drive but there is
>> no such drive a cryptic "uninitialized value" error is thrown. this
>> is due to `$path` not being defined in `sub
>> print_drive_commandlin
> >
Hi Fiona, thanks for the review
> >
> The general ideas looks fine to me and my basic testing seemed fine
> too,
> but most patches could use a few improvements. The biggest issue is
> that
> getting static information in HA manager is not adapted to the
> change.
>
yes, I known, I wanted
> > my $static_memory = get_static_mem($conf);
> > + my $confmem = PVE::QemuServer::parse_memory($conf->{memory});
> >
> > - if ($hotplug_features->{memory}) {
> > + if ($hotplug_features->{memory} || defined($confmem->{max})) {
>
> So setting 'max' auto-attches the dimms[0], but
when a vm is configured to use a physical cd rom drive but there is no
such drive a cryptic "uninitialized value" error is thrown. this is
due to `$path` not being defined in `sub
print_drive_commandline_full` in this case. warn that no cd rom drive
is available instead.
note that the error was ba
Am 19.12.22 um 13:05 schrieb DERUMIER, Alexandre:
>
>>> my $static_memory = get_static_mem($conf);
>>> + my $confmem = PVE::QemuServer::parse_memory($conf->{memory});
>>>
>>> - if ($hotplug_features->{memory}) {
>>> + if ($hotplug_features->{memory} || defined($confmem->{max})) {
>
>From the corresponding patch file in the pve-qemu repository which
introduces the option:
> This used to be part of the qemu-side PVE authentication for
> VNC. Now this does nothing.
Remove it now, so the QEMU patch can be dropped with the next major
PVE release.
Signed-off-by: Fiona Ebner
---
Am 19.12.22 um 14:34 schrieb Fiona Ebner:
> From the corresponding patch file in the pve-qemu repository which
> introduces the option:
>> This used to be part of the qemu-side PVE authentication for
>> VNC. Now this does nothing.
>
> Remove it now, so the QEMU patch can be dropped with the next m
To provide similar output on the CLI as is possible in the GUI/API
regaring OSD details.
By default (output-format=text) a more concise output is shown. Using
json or yaml as output format will print all the available data.
The 'verbose' flag causes json-pretty output to be used.
The functionali
On 16/12/2022 14:42, Fiona Ebner wrote:
> It wasn't supported on QEMU 3.0 😉 But it raises the question if we
> should introduce version guards for the feature? Not sure what our
> current policy is when it comes to actively-opt-in features. Especially
> if it's still a technology preview.
Yeah wit
On 19/12/2022 13:23, Stefan Sterz wrote:
> when a vm is configured to use a physical cd rom drive but there is no
> such drive a cryptic "uninitialized value" error is thrown. this is
> due to `$path` not being defined in `sub
> print_drive_commandline_full` in this case. warn that no cd rom drive
16 matches
Mail list logo
