Am 19.12.22 um 13:05 schrieb DERUMIER, Alexandre:
>
>>> my $static_memory = get_static_mem($conf);
>>> + my $confmem = PVE::QemuServer::parse_memory($conf->{memory});
>>>
>>> - if ($hotplug_features->{memory}) {
>>> + if ($hotplug_features->{memory} || defined($confmem->{max})) {
>>
>> So setting 'max' auto-attches the dimms[0], but without memory
>> hotplug
>> enabled, those are useless? Or am I missing something? I feel like we
>> can just keep the conditional here and below[0] as-is.
>>
>
> yes, I was not sure here(same for virtio-mem).
>
> virtiomem && maxmem values only usefull make sense if memory hotplug is
> enabled, but for example, for cpu hotplug, we can define a specific
> vcpu number, without the hotplug cpu option enabled.
>
> So I don't known if we should conditionnaly change hardware topology
> depending of an hotplug option.
> (I mean, only the hotplug action itself should be blocked/allowed by
> the option)
It's just that the 'max' setting doesn't explicitly describe the
hardware topology, but sure, the setting only makes sense for hotplug
after all and then a different hardware topology is needed. And with the
virito setting, one can argue that it does describe the hardware
topology. So feel free to keep the conditionals as-is in your patches :)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
