Le lundi 07 novembre 2022 à 13:41 +0100, Mira Limbeck a écrit :
>
> I'm currently going through this patch series
Thanks for looking at it !
> and I'm wondering.
> Wouldn't it make more sense to delete the bridge fdb entries as part
> of
> the VM shutdown instead?
>
> This way those would be
w.r.t. to this one and the next patch:
I'd slightly prefer either having just a single property for all, or split it
into two:
style and rest. The latter may have a small benefit w.r.t. to stability - if a
parser/edit
bug sneaks in that breaks styling the access stuff might be still working, but
sorry for the delay, applied, thanks
On Thu, Jun 30, 2022 at 05:09:44PM -0700, Daniel Bowder wrote:
> Summary:
> Allows for virtual machines to be pinned to CPU cores via an affinity value
> added to the qemu configuration. I previously created a v1 of this patch,
> but it was my first submission
Am 18/10/2022 um 16:02 schrieb Dominik Csapak:
> by adding a 'user-tag-privileges' and 'admin-tags' option.
> The first sets the policy by which "normal" users (with
> 'VM.Config.Options' on the respective guest) can create/delete tags
> and the second is a list of tags only settable by 'admins'
>
under some conditions, like when calling it in the api where we have
a 30s pveproxy limit, we want to make use of the '--timeout' parameter
of the file-restore binary, but we may want to call it in the future
where we don't want add timeout.
To achieve that, add an extendable 'extra_params' hash p
file-restore has a 'timeout' parameter and if that is exceeded, returns
an error with the http code 503 Service Unavailable
When the web ui encounters such an error, it retries the listing a few
times before giving up.
To make use of these, add the 'timeout' parameter to the new
'extraParams' of
so that we can make use of the dynamic memory feature of file-restore
(it automatically increases the memory of the file-restore vm when
we detect a zfs path)
Signed-off-by: Dominik Csapak
---
new in v4
depends on the proxmox-backup patch for file-restore
src/PVE/PBSClient.pm | 13 +++--
since commit
ba690c40 ("file-restore: remove 'json-error' parameter from list_files")
in proxmox-backup, the file-restore binary will return the error as json
when called with '--output-format json' (which we do in PVE::PBSClient)
here, we assume that 'file-restore' will fail in that case, and we
this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout
and enables/disables the automatic increasing of memory depending
on the users privileges
depends (i'll add it to the seperate patches too)
pve-storage 1/3 fixes the c
if the user has the appropriate rights (details in the comments of
'check_allow_dynamic_memory') enable the dynamic memory behaviour
of the file-restore binary
Signed-off-by: Dominik Csapak
---
new in v4:
depends on pve-common 2/2
PVE/API2/Storage/FileRestore.pm | 25 +++--
by adding 'dynamic-memory' parameter that controls if we automatically
increase the memory of the guest vm or not
Signed-off-by: Dominik Csapak
---
new in v4
not really happy with the 'clippy allow', but imho there is no obvious way to
bundle those parameters without restructuring the code much
created repo & applied
added followups to:
- bump the section-config dependency in Cargo.toml to include the
changes from this series
- use setresuid() to also drop the saved uid
- initial dummy version bump commit
___
pve-devel mailing list
pve-devel
applied
On Fri, Oct 21, 2022 at 03:02:48PM +0200, Fiona Ebner wrote:
> which registers a binary in /root/.forward and handles mail forwarding
> to the mail addresss configured for root@pam in PBS. Similar to how it
> is done in PVE currently.
>
> Signed-off-by: Fiona Ebner
> ---
> debian/contro
applied remaining patches
On Fri, Oct 21, 2022 at 03:02:43PM +0200, Fiona Ebner wrote:
> written in Rust, and replacing the pvemailforward binary in PVE. Can
> be used in PVE and PBS as well as in a mixed installations of the two.
>
> To make reading the config files work, it is a setuid binary o
Am 21/10/2022 um 15:02 schrieb Fiona Ebner:
> Now that the pvemailforward binary was dropped, there is a lintian
> warning that it's not defined anymore.
>
> Signed-off-by: Fiona Ebner
> ---
> debian/control | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
V1 -> V2:
# pve-storage
* formating change
* fixing typos & wording
* added check if dRAID options draidspares & draiddata are used for something
else then setting up a dRAID
# pve-manager
* add a viewModel and use a binding for visiblity
* remove controller
# pve-docs
* fix many typos
* reword
add some basic explanation how ZFS dRAID works including
links to openZFS for more details
add documentation for two dRAID parameters used in code
Signed-off-by: Stefan Hrdlicka
---
local-zfs.adoc | 44 +++-
1 file changed, 43 insertions(+), 1 deletion(-)
It is possible to set the number of spares and the size of
data stripes via draidspares & dreaddata parameters.
Signed-off-by: Stefan Hrdlicka
---
PVE/API2/Disks/ZFS.pm | 55 ++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Disks/
add fields for additional settings required by ZFS dRAID
Signed-off-by: Stefan Hrdlicka
---
www/manager6/node/ZFS.js | 69
1 file changed, 69 insertions(+)
diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index 5b3bdbda..75d7d8e1 100644
-
Tested-by: Lukas Wagner
On 11/10/22 14:24, Stefan Hrdlicka wrote:
V1 -> V2:
# pve-storage
* formating change
* fixing typos & wording
* added check if dRAID options draidspares & draiddata are used for something
else then setting up a dRAID
# pve-manager
* add a viewModel and use a binding for
just outside of context, we already save the result from
machine_type_is_q35 into the $q35 variable, but never use it.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0a8442c..642c
to avoid a cyclic dependency when we want to use that in PVE::QemuServer::USB
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm| 2 +-
PVE/QemuServer.pm | 20 +---
PVE/QemuServer/Cloudinit.pm | 3 ++-
PVE/QemuServer/Helpers.pm | 19 +++
We already have that factored out in PVE.Utils, so use that.
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/USBEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index a2204584a..4373f82c3 100644
--- a/www/
in the backend, we allow up to 14 usb ports, but only if the vm can
use the qemu-xhci controller which is only possible since machine
version 7.1 and if the ostype is l26 or windows > 7
for this we introduce two helpers:
* qemu_min_version: modeled after the signature of 'min_version' from
qemu-
same as with the extended support for more usb devices, allow
hotplugging for guests that can use the qemu-xhci controller which
require a machine type >= 7.1 and a ostype l26 or windows > 7
if no usb device was passed through on startup, dynamically add
the xhci controller (and remove if the last
should not happen normally, but an inattentive user of that function
may forget to check the validity of the parsed device, so err
on the safe side here
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/USB.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuS
we refactored that into PVE::QemuServer::Machine a while ago, so we can
use it here
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/USB.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
index b669c91..10c9bca 100644
--- a/PVE/
for machine versions >= 7.1 and ostype linux or windows > 7, we use the
qemu-xhci controller where we have up to 14 usable ports, so make them
available to the user
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 5 +++--
PVE/QemuServer/USB.pm | 13 +
2 files changed, 16 i
qemu-xhci is to be preferred to nec-usb-xhci, but for compatibility
reasons, only use it for machine types >= 7.1 and ostypes l26 and
windows > 7 (older os' don't support it)
(depending on that machine version should be ok as long as we don't
roll out qemu 7.1 before applying this series)
With tha
going by reports in the forum (e.g. [0]) and semi-official qemu
information[1], we should prefer qemu-xhci over nec-usb-xhci
for compatibility purposes, we guard that behind the machine version,
so that guests with a fixed version don't suddenly have a different usb
controller after a reboot (whic
backed by the proxmox-resource-scheduling crate.
Initially to be used by the HA manager to allow it basing its decision
where to start a new or recovered service on static usage information
rather than just counting.
Signed-off-by: Fiona Ebner
---
Makefile | 1
Models usage of guests and nodes, and allows scoring nodes on which to
start a new service via TOPSIS. For this scoring, each node in turn is
considered as if the service was already running on it.
CPU and memory usage are used as criteria, with memory being weighted
much more, because it's a trul
Planned to be used for static resource scheduling in the HA manager.
It's enough to broadcast the values whenever they are outdated or not
set in the node's local kv store, because pmxcfs will re-broadcast the
local kv store whenever the quorate partition changes. This is already
relied upon for t
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Manager.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 63e6c8a..20b743c 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -52,6 +52,11 @@ sub new {
$self->{ms} = { mas
currently only used to test the installed version and not
automatically during build. See the FIXME note for why.
Signed-off-by: Fiona Ebner
---
pve-rs/test/Makefile | 4 ++
pve-rs/test/README | 2 +
pve-rs/test/resource_scheduling.pl | 70
for reading the resource scheduler settings.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Env.pm | 7 +++
src/PVE/HA/Env/PVE2.pm | 12
src/PVE/HA/Sim/Env.pm | 9 +
3 files changed, 28 insertions(+)
diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm
index 00e3e3c..c
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Manager.pm | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 20b743c..7c85b67 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -8,6 +8,7 @@ us
briefly describing the 'basic' and 'static' modes and with a note
mentioning plans for balancers.
Signed-off-by: Fiona Ebner
---
ha-manager.adoc | 27 +++
1 file changed, 27 insertions(+)
diff --git a/ha-manager.adoc b/ha-manager.adoc
index 54db2a5..dfed393 100644
--- a/
With the Usage::Static plugin, scoring is not as cheap anymore and
select_service_node() is called for each running service.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Manager.pm | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Man
in preparation to also support static resource scheduling via another
such Usage plugin.
The interface is designed in anticipation of the Usage::Static plugin,
the Usage::Basic plugin doesn't require all parameters.
In Usage::Static, the $haenv will necessary for logging and getting
the static no
Implement the TOPSIS[0] algorithm to score multi-valued alternatives
according to a given set of weighted criteria.
The number of alternatives cannot be known at compile time, but the
number of criteria should be (a given module using the topsis module
should have one (or more) fixed sets of crite
so the frontend has the information readily available.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
Changes from v2:
* Add it to the new 'static-info' kv instead of being standalone.
* Fix params for get_node_kv() call (already in previous patch).
PVE/API2/Cluster.pm
Right now, the online node usage calculation for the HA manager only
considers the number of active services on each node. This patch
series allows switching to a 'static' scheduler mode instead, where
static usage information from the nodes and guest configurations is
used instead.
This also incl
Signed-off-by: Fiona Ebner
---
.gitignore | 5
Makefile | 67
debian/changelog | 5
debian/control | 39 ++
debian/copyright | 16 +++
debian/debcargo.toml | 7 +
6 fi
Initially, with a setting for HA to switch between basic (just count
services) and static (use static node and resource information).
Signed-off-by: Fiona Ebner
---
data/PVE/DataCenterConfig.pm | 25 +
1 file changed, 25 insertions(+)
diff --git a/data/PVE/DataCenterConf
to be used for static resource scheduling.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Env.pm | 6 ++
src/PVE/HA/Env/PVE2.pm| 13 +
src/PVE/HA/Sim/TestEnv.pm | 6 ++
3 files changed, 25 insertions(+)
diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm
index ac569a
to be used for static resource scheduling.
In container's vmstatus(), the 'cores' option takes precedence over
the 'cpulimit' one, but it felt more accurate to prefer 'cpulimit'
here.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Resources.pm | 5 +
src/PVE/HA/Resources/PVECT.pm | 11 +++
In preparation for scheduling based on static information, where the
scoring of nodes depends on information from the service's
VM/CT configuration file (and the $sid is required to query that).
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Manager.pm | 4 +++-
src/test/test_failover1.pl | 2 +-
for calculating node usage of services based upon static CPU and
memory configuration as well as scoring the nodes with that
information to decide where to start a new or recovered service.
For getting the service stats, it's necessary to also consider the
migration target (if present), becuase th
With the Usage::Static plugin, scoring is not as cheap anymore and
select_service_node() is called for each running service.
This should cover most calls of select_service_node().
Signed-off-by: Fiona Ebner
---
I think the whole $found logic can be dropped *if* we ensure that
$tried_nodes and $
forgot to mention: i tested the passthrough with various devices (mouse, usb
key, onlykey..) and
the hotplugging with live migration with hot(un)plugging multiple times in
various slots
without any problems
___
pve-devel mailing list
pve-devel@lists.
so that the default value and limits actually correspond to what will
be used. Defaults to values for cgroup v2, because that is the more
common scenario.
Signed-off-by: Fiona Ebner
---
No changes from v1.
www/manager6/lxc/CreateWizard.js | 8
www/manager6/lxc/ResourceEdit.js | 3
no functional change is intended.
One test needs adaptation too, because it created its own version of
$online_node_usage.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Manager.pm | 35 +--
src/test/test_failover1.pl | 19 ++-
2 files changed, 27
as reported in
https://forum.proxmox.com/threads/sudden-reboot-of-multiple-nodes-while-adding-a-new-node.116714/
this patch just fixes a particular issue where a node joins (as in
quorum membership change, not limited to PVE cluster join) an existing
cluster, but has a lower MTU than the existing
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/LXC.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 79aecaa..0e8cb95 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -380,6 +380,9 @@ __PACKAGE__->register_method({
This patch adds hooks that run when the user restores a backup from the Web UI
/ CLI. I have tested this with both VMs/CTs via Web UI and CLI. Are there any
other places where the hook should get triggered that I missed?
Changes compared to v1:
- slightly moved the call site of the exec_hookscript
Signed-off-by: Stefan Hanreich
---
examples/guest-example-hookscript.pl | 14 ++
1 file changed, 14 insertions(+)
diff --git a/examples/guest-example-hookscript.pl
b/examples/guest-example-hookscript.pl
index adeed59..19fe213 100755
--- a/examples/guest-example-hookscript.pl
+++ b/e
Signed-off-by: Stefan Hanreich
---
PVE/API2/Qemu.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index a539b5c..3d4079e 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -888,6 +888,7 @@ __PACKAGE__->register_method({
Am 10/11/2022 um 15:35 schrieb Dominik Csapak:
> qemu-xhci is to be preferred to nec-usb-xhci, but for compatibility
> reasons, only use it for machine types >= 7.1 and ostypes l26 and
> windows > 7 (older os' don't support it)
> (depending on that machine version should be ok as long as we don't
>
q35 + usb passthrough
q35 + usb3 passthrough
q35 + usb3 passthrough with new xhci controller
old machine type + new usb config error
old machine type + q35 + new usb config error
old ostype (w2k) + new usb config error
Signed-off-by: Dominik Csapak
---
test/cfg2cmd/ostype-usb13-error.conf| 1
60 matches
Mail list logo
