Le lundi 07 novembre 2022 à 13:41 +0100, Mira Limbeck a écrit : > > I'm currently going through this patch series Thanks for looking at it !
> and I'm wondering. > Wouldn't it make more sense to delete the bridge fdb entries as part > of > the VM shutdown instead? > > This way those would be cleaned up whenever the VM is stopped (and > the > tap device gets destroyed). No special handling for migrations > needed, > unless I'm missing something? > Well, the fdb entry is already auto-deleted when the tap in unplug from the bridge. (so when qemu process is stopped too) We want the fdb entries only present in the bridge on active vm. (some advanced controlplane like evpn, also blocking the write of duplicated mac on multiple nodes) as we resume the targetvm before stopping the sourcevm, we need to remove fdb entries on source bridge manually. The workflow is: ---------------- 1) original vm is started, fbd entries are written in bridge 2) start migration, destination vm is started paused without writting fdb entries (I think I don't implement this currently, I need to verify) 3) At the end of the migration, when sourcevm is stopped, before the resume of target vm: - fdb entries are removed on source vm bridge - fdb entries are added in destination vm bridge - targetvm is resumed - sourcevm is stopped I'll review and retest the full patch series tomorrow > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://antiphishing.cetsi.fr/proxy/v3?i=Zk92VEFKaGQ4Ums4cnZEUWMTpfHaXFQGRw1_CnOoOH0&r=bHA1dGV3NWJQVUloaWNFUZPm0fiiBviaiy_RDav2GQ1U4uy6lsDDv3uBszpvvWYQN5FqKqFD6WPYupfAUP1c9g&f=SlhDbE9uS2laS2JaZFpNWvmsxai1zlJP9llgnl5HIv-4jAji8Dh2BQawzxID5bzr6Uv-3EQd-eluQbsPfcUOTg&u=https%3A//lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel&k=XRKU > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
