[pve-devel] applied-series: [PATCH proxmox-offline-mirror 0/4] extend/add commands

2022-09-26 Thread Wolfgang Bumiller
applied series, thanks On Wed, Sep 21, 2022 at 10:12:38AM +0200, Fabian Grünbichler wrote: > this series adds diff commands for diffing two snapshots of a mirror > (`mirror snapshot diff`), a medium and its source mirrors (`medium > diff`) and extends `mirror snapshot list` to allow listing *all*

[pve-devel] applied: Re: [PATCH docs] cloud init: add warning to not install cloud-init on the host

2022-09-26 Thread Thomas Lamprecht
On 22/09/2022 10:32, Fiona Ebner wrote: > From time to time, users install the cloud-init package on the host > by accident [0]. Since the other commands are intended to be run on > the host, add a warning about the one command that shouldn't. > > Patch suggested by @Neobin on the community forum

[pve-devel] applied: [PATCH docs] cloud init: mention that serial display might not work for all images

2022-09-26 Thread Thomas Lamprecht
On 22/09/2022 11:33, Fiona Ebner wrote: > Example from the community forum: > https://forum.proxmox.com/threads/112225/ > > Signed-off-by: Fiona Ebner > --- > qm-cloud-init.adoc | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > applied, thanks! _

[pve-devel] applied: Re: [PATCH v2 guest-common] replication: avoid "expected snapshot missing" warning when irrelevant

2022-09-26 Thread Thomas Lamprecht
On 23/09/2022 10:16, Fiona Ebner wrote: > Only print it when there is a snapshot that would've been removed > without the safeguard. Mostly relevant when a new volume is added to > an already replicated guest. > > Fixes replication tests in pve-manager. > > Fixes: c0b2948 ("replication: prepare:

Re: [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used

2022-09-26 Thread Thomas Lamprecht
On 31/08/2022 14:46, Fiona Ebner wrote: > which can lead to operations like cloning the running VM failing. hmm, could be a bit spammy as warning, but we do not have a level between info and warning task log; log_notice() could be nice to get sometimes to have something that isn't as "alarming" as

[pve-devel] applied: [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible

2022-09-26 Thread Thomas Lamprecht
On 31/08/2022 14:46, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > > (build-)dependency bump for libpve-common-perl >= 7.1-4 needed > > PVE/QemuServer.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] [PATCH firewall] fix #4204: automatically update usages of group when it is renamed

2022-09-26 Thread Leo Nunner
When renaming a group, the usages didn't get updated automatically. To get around problems with atomicity, the old rule is first cloned with the new name, the usages are updated and only when updating has finished, the old rule is deleted. The subroutines that lock/update host configs had to be ch

Re: [pve-devel] [PATCH pve-guest-common 1/1] Add abstract methods for pre/post-migrate hooks

2022-09-26 Thread Thomas Lamprecht
Am 22/09/2022 um 16:13 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/PVE/AbstractMigrate.pm | 14 ++ > 1 file changed, 14 insertions(+) > for the record, if we do it like this (not much rationale given in the commit message) this breaks containers and qemu-s

Re: [pve-devel] [PATCH qemu-server 1/1] Add VM hooks for pre/post-migrate on target/source

2022-09-26 Thread Thomas Lamprecht
I don't like that there's no commit message (the cover letter is more for general/meta info, it doesn't gets into git after all, would require doing pull requests which we (currently) don't do in most cases). Besides that I'd rather avoid extending SSH usage further, a long term goal is to allo

Re: [pve-devel] [PATCH pve-container/qemu-server/pve-guest-common/pve-docs 0/1] Add pre/post-migrate hooks

2022-09-26 Thread Thomas Lamprecht
Am 22/09/2022 um 16:13 schrieb Stefan Hanreich: > I have decided to create distinct event types for source/target nodes, since > otherwise the same script would run essentially twice on the source/target > node. > With distinct event types, the hooks should be more flexible in their usage. just m