Am 22/09/2022 um 16:13 schrieb Stefan Hanreich: > I have decided to create distinct event types for source/target nodes, since > otherwise the same script would run essentially twice on the source/target > node. > With distinct event types, the hooks should be more flexible in their usage.
just make that a parameter, same flexibility but less cmd explosion and complexity. Also, _iff_ (see reply we keep the CLI entries for pct/qm it should just be a single command there, any difference should be handled in the parameters; it's internal after all and we want to avoid that there's more internal commands then externals someday ;) Target and source should be part of the parameters on either call (pre/post, src/target), it is relevant info and should be easily available. Some param info like offline/online migration could be relevant too, but we can always extend on that, so in that regard it can be fine to stop smaller, to avoid going over board and having to keep all that info for backward compat. Any parameter would need to be encoded in the example then. Some more general note, the example is better than nothing, but a nice list/table directly in the docs would be really good to have. This could be done upfront, before adding new hooks - best for now to duplicate it for both CT and VM chapter (if sensible it can live in its own guest-hook-list.adoc and just get included twice). Including the example script as an appendix would be a nice touch too. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
