Am 05.09.22 um 10:25 schrieb Eneko Lacunza:
> Hi Fiona,
>
> I just confirmed that in addition to issue reported in
> https://bugzilla.proxmox.com/show_bug.cgi?id=4073 (live migrated VM hung
> using 100% CPU), we also reproduce issue reported in
>
> https://forum.proxmox.com/threads/zeitspr%C3%BCn
On September 13, 2022 5:03 pm, Stoiko Ivanov wrote:
> Thanks for the patch!
>
> 2-3 small issues and one nit:
> On Tue, 13 Sep 2022 14:30:35 +0200
> Fabian Grünbichler wrote:
>
>> missed when switching over to Proxmox::RS::Subscription, which stores
>> the same info in the product-specific /etc/
missed when switching over to Proxmox::RS::Subscription, which stores
the same info in the product-specific /etc/apt/auth.conf.d/pve.conf .
the top-level file might contain non-PVE-managed entries, so only remove
entries matching "our" machine.
Signed-off-by: Fabian Grünbichler
---
Notes:
v
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/LXC/Snapshot.pm | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm
index 4be16ad..0999fbc 100644
--- a/src/PVE/API2/LXC/Snapshot.pm
+++ b/src/PVE/API2/LXC/Snapshot.pm
@@ -272,6
Since the previous patch we have decided to implement a new component
that can be used for creating confirmation dialogs with form fields. The
new component should be similar to the MessageBox, except it can contain
form fields. It also automatically calls an API endpoint when the user
confirms the
Signed-off-by: Stefan Hanreich
---
PVE/API2/Qemu.pm | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 3ec31c2..e6f8f31 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -4764,6 +4764,12 @@ __PACKAGE__->register_method({
nod
Added a new component, Confirm. It acts similar to a messagebox, except it
can contain form elements. It also automatically calls an API endpoint
when the user confirms the message.
This component was then used for implementing the new rollback dialog window.
Signed-off-by: Stefan Hanreich
---
w
--- Begin Message ---
Hi Fiona,
El 14/9/22 a las 9:50, Fiona Ebner escribió:
Am 05.09.22 um 10:25 schrieb Eneko Lacunza:
I just confirmed that in addition to issue reported in
https://bugzilla.proxmox.com/show_bug.cgi?id=4073 (live migrated VM hung
using 100% CPU), we also reproduce issue rep
Am 14/09/2022 um 10:05 schrieb Fabian Grünbichler:
> missed when switching over to Proxmox::RS::Subscription, which stores
> the same info in the product-specific /etc/apt/auth.conf.d/pve.conf .
>
> the top-level file might contain non-PVE-managed entries, so only remove
> entries matching "our" m
--- Begin Message ---
Hi,
El 14/9/22 a las 10:40, Eneko Lacunza escribió:
El 14/9/22 a las 9:50, Fiona Ebner escribió:
Am 05.09.22 um 10:25 schrieb Eneko Lacunza:
I just confirmed that in addition to issue reported in
https://bugzilla.proxmox.com/show_bug.cgi?id=4073 (live migrated VM hung
u
the volume path could contain escaped ":" or ",", which means their '\'
needs to be escaped another time for passing to HMP.
the same approach is used for hotplugging regular drives in
PVE::QemuServer, and is needed (at least) for RBD storages with IPv6
monhosts or an explicit monhost port.
Signe
Signed-off-by: Fabian Grünbichler
---
PVE/VZDump/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 0d58e03b..bf0d1c56 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -444,7 +444,7 @@
With change to our new tfa mechanism, we now lock the tfa config
when verifying the second factor and when creating the challenge for it
that makes sense, since at least one tfa type can change the config
(recovery keys must be deleted from there).
The downside is that we cannot authenticate users
Why the change from vm.text to vm_text in {lxc,qemu}/Config.js?
AFAICT we have exactly the same string in the now not used "vm.text".
If these changes are needed and should be part of this commmit, a short
explanation would be good as it does not seem to have anything to do with the
resource t
On 6/21/22 11:20, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
www/manager6/form/Tag.js | 22 +++--
www/manager6/form/TagEdit.js | 96 +++-
2 files changed, 114 insertions(+), 4 deletions(-)
diff --git a/www/manager6/form/Tag.js b/www/ma
One thing I noticed in a few places regarding variable names was that they
probably could use some camel casing for better readabilty. E.g.:
newcls -> newCls
newrbd -> newRgb or maybe newRGB?
More comments inline.
On 6/21/22 11:20, Dominik Csapak wrote:
this provides a basic grid to edit a li
one small nit inside
On 6/21/22 11:19, Dominik Csapak wrote:
by querying 'lock' and 'tags' with 'get_guest_config_properties'
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Clu
Out of curiosity, did you decide to use the older style of component, instead of
the newer declarative approach, to be able to have references to the buttons as
"me." instead of having to do lookups all the time?
one more thing inline
On 6/21/22 11:20, Dominik Csapak wrote:
this is a wrapper
This component seems to not be working as expected.
In Firefox (105.0) I get all kinds of glitches and investigating it a bit, it
seems like the HTML & CSS classes manipulation doesn't seem to work correctly.
For example, if I edit an existing tag and select another existing one from the
appea
Something that crossed my mind:
Have you thought about not allowing tags if they match an admin tag, except for
the '+'?
Depending on what they will be used for in the future, there could be some
potential to trick an admin by creating a similar regular tag. Any code relying
on admin tags shou
Some small nits inline
On 6/21/22 11:19, Dominik Csapak wrote:
helpers to
* generate a color from a string consistently
* generate a html tag for a tag
* related css classes
contrast is calculated according to SAPC draft:
https://github.com/Myndex/SAPC-APCA
which is likely to become a w3c guid
Tested it and a few things I noticed:
- can add one tag multiple times
- user with PVEAdmin role on / (should not have Sys.Modify permissions) can
remove an admin tag, though it does not work if I apply VMAdmin role privileges
directly on the VM
- editing tags themselves seems to be a bit buggy
I have to follow up here as I noticed that in a private Firefox window it did
work much better and as expected. I suspect some addon is interfereing here.
Which one I cannot say yet.
On 9/14/22 16:15, Aaron Lauterer wrote:
This component seems to not be working as expected.
In Firefox (105.0)
23 matches
Mail list logo
