[pve-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file

2022-07-20 Thread Fabian Ebner
It's currently possible to add a remote in PMG without password (via API), but deletion of such a remote would fail here. Signed-off-by: Fabian Ebner --- src/PVE/PBSClient.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm index 373

[pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter

2022-07-20 Thread Fabian Ebner
Instead, use the one from the initial configuration. The only current caller is in PMG and the namespace parameter set there agrees with the one from the initial configuration, so this is not actually a breaking change. Signed-off-by: Fabian Ebner --- src/PVE/PBSClient.pm | 4 ++-- 1 file change

[pve-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters

2022-07-20 Thread Fabian Ebner
All existing callers for functions with namespaced parameters just re-use the one that's passed in via the initial configuration already, so there is no need for namespaced parameters currently. If the need for one PBS client to handle multiple namespaces arises, a set_namespace() function could b

[pve-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account

2022-07-20 Thread Fabian Ebner
instead of assuming that the requested ID is the same as the node in the API path. This endpoint is not currently used in the UI AFAICS. Signed-off-by: Fabian Ebner --- src/PMG/API2/PBS/Job.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG/A

[pve-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes

2022-07-20 Thread Fabian Ebner
Mostly done in preparation for #3186 (refactor pbs client use in PVE), to avoid the need to manually set the namespace for all call-sites in PVE, when it's already present in the storage/PBS config. pve-common 1/5 and 2/5 and pmg-api 1/1 are improvements touching parts of the same infrastructure,

[pve-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output

2022-07-20 Thread Fabian Ebner
Otherwise, there will be Result: { "data": null } when calling via a CLI tool for example. This also makes it consistent with PVE in preparation to switch to using PBSClient there. Signed-off-by: Fabian Ebner --- src/PVE/PBSClient.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[pve-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters

2022-07-20 Thread Fabian Ebner
For get_snapshots(), also set the default when no namespaced parameter is present at all. This would break any callers that have a namespace in the initial config and explicitly don't set it for a later call, but the only such caller is restore_pxar() in PMG, which /should/ be using the namespace!

[pve-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: don't use namespaced parameters

2022-07-20 Thread Fabian Ebner
Instead, rely on PBSClient to set namespace according to the initial configuration. Signed-off-by: Fabian Ebner --- Dependency bump for new libpve-common-perl needed. PVE/API2/Storage/FileRestore.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Storage/FileRe

[pve-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters

2022-07-20 Thread Fabian Ebner
Instead, rely on PBSClient to set namespace according to the initial configuration. Signed-off-by: Fabian Ebner --- Dependency bump for new libpve-common-perl needed. src/PMG/API2/PBS/Job.pm | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/PMG/API2/

Re: [pve-devel] [PATCH qemu-server] fix #3784: Parameter for guest vIOMMU & machine as property-string

2022-07-20 Thread Markus Frank
Ping viommu-Patches: 1: [PATCH qemu-server 1/3] tests: replaced somemachine&someothermachine with q35&pc 2: [PATCH qemu-server] fix #3784: Parameter for guest vIOMMU & machine as property-string 3: [PATCH qemu-server] added test-cases for new machine-syntax & viommu 4: [PATCH manager] ui: Machine

Re: [pve-devel] [PATCH manager v2] Jobs: fix scheduling after updating job from a different node

2022-07-20 Thread Fabian Ebner
Am 15.07.22 um 14:34 schrieb Dominik Csapak: > since the jobs are configured clusterwide in pmxcfs, a user can use any > node to update the config of them. for some configs (schedule/enabled) > we need to update the last runtime in the state file, but this > is sadly only node-local. > > to also u

[pve-devel] [PATCH v2 manager] fix #3248: GUI: storage: upload multiple files

2022-07-20 Thread Matthias Heiserer
Queue multiple files for upload to the storage. The upload itself happens in a separate window. When closing the window, files with an error (i.e. wrong hash) are retained in the upload window. Signed-off-by: Matthias Heiserer --- Depends on https://lists.proxmox.com/pipermail/pbs-devel/2022-Jul

[pve-devel] [PATCH pve-container 2/3] fix #3711 cleanup: remove spaces from empty lines

2022-07-20 Thread Stefan Hrdlicka
remove spaces where they are not needed Signed-off-by: Stefan Hrdlicka --- src/PVE/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 74c8d17..42d94ac 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -668,7 +668,7 @@ sub

[pve-devel] [PATCH pve-manager 3/3] fix #3711: enable removing container with non existent storage

2022-07-20 Thread Stefan Hrdlicka
Add a checkbox to the remove dialog of LXC containers to force deleting a container if the storage it uses has been removed. Signed-off-by: Stefan Hrdlicka --- www/manager6/lxc/Config.js | 1 + www/manager6/window/SafeDestroyGuest.js | 34 + 2 files changed,

[pve-devel] [PATCH pve-container 0/3] fix #3711: delete LXC container with missing storage

2022-07-20 Thread Stefan Hrdlicka
The patch adds a new option 'force-remove-storage' that stops pct destory from dying if the storage is not available. This also adds a menu option for the delete dialog of containers. Stefan Hrdlicka (2): fix 3711: enable delete of LXC container via force option fix #3711 cleanup: remove spac

[pve-devel] [PATCH pve-container 1/3] fix #3711: enable delete of LXC container via force option

2022-07-20 Thread Stefan Hrdlicka
Make it possible to delete a container whoes underlying storage is no longer available. This will just write an warning instead of dying. Without setting the option force-remove-storage=1 a delete will still fail, like it did before the changes. With this option set it will try to delete the volum