Mostly done in preparation for #3186 (refactor pbs client use in PVE), to avoid the need to manually set the namespace for all call-sites in PVE, when it's already present in the storage/PBS config.
pve-common 1/5 and 2/5 and pmg-api 1/1 are improvements touching parts of the same infrastructure, but not directly related. The other patches change PBSClient to auto-select the namespace from its initial configuration if not explicitly overriden with a namespaced parameter and deprecate namespaced parameters as a whole. Rationale is that essentially all current users of PBSClient are configured for one namespace (there is the "status" call, which doesn't depend on a namespace, but that doesn't contradict the previous claim). It's less work on the call sites and there's no risk to forget namespacing a parameter (as happened with pxar_restore in PMG) if the PBSClient handles it itself. If the need for handling more than one namespace with a single client ever arises, we can still add e.g. a set_namespace() function to the PBSClient. Also makes it possible to restore a backup from a namespace in PMG, which currently fails. Dependency bump for new pve-common is needed for pve-storage and pmg-api. pve-common: Fabian Ebner (5): pbs client: delete password: return success for non-existent file pbs client: forget snapshot: suppress output pbs client: default to configured namespace for non-namespaced parameters pbs client: deprecate namespaced parameters pbs client: backup fs tree: drop namespace parameter src/PVE/PBSClient.pm | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) pmg-api: Fabian Ebner (2): api: get group snapshots: take backup-id into account api: pbs: don't use namespaced parameters src/PMG/API2/PBS/Job.pm | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) pve-storage: Fabian Ebner (1): api: pbs: file restore: don't use namespaced parameters PVE/API2/Storage/FileRestore.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel