Re: [pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common

2022-05-28 Thread Thomas Lamprecht
This isn't bumping the version of pve-common, but the build-dependency only (why not the installation dependency too?). The common commit subject style used for such things, as can be seen by checking git log on debian/control, is: "d/control: bump build-dependency of pve-common" Then a short se

[pve-devel] applied: [PATCH v4 manager 1/3] fix typo

2022-05-28 Thread Thomas Lamprecht
On 27/05/2022 13:48, Matthias Heiserer wrote: > Worked before because if SCSI should be a value, that's set in init. > isScsi is never used. > > Signed-off-by: Matthias Heiserer > --- > > Changes from v3: > New patch > > www/manager6/qemu/HDEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [pve-devel] [PATCH pve-cluster] Change log statements to debug

2022-05-28 Thread Thomas Lamprecht
On 27/05/2022 11:37, Matthias Heiserer wrote: > They have been commented with //fixme for more than 11 years > and contain little information, so at least make them debug logs. not really that of a good reason? Was there some actual event from a user report or similar to trigger this? As otherwise

Re: [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd

2022-05-28 Thread DERUMIER, Alexandre
Hi Thomas, for pressure, I don't really need rrd or history, as I can already broadcast last 10s,60s, 300s. so could simply broadcast them in kvstore. This was the original patch in 2020 https://lists.proxmox.com/pipermail/pve-devel/2020-October/045493.html but Dietmar asked about to put them in