Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

2022-04-12 Thread Thomas Lamprecht
On 11.04.22 16:49, Aaron Lauterer wrote: > On 4/11/22 14:17, Thomas Lamprecht wrote: >> FWIW, with storage getting the following patch the symlinks get created (may >> need >> an trigger for reloading udev (or manually `udevadm control -R`). >> >> We'd only need to check to prioritize /deb/rbd-pve

[pve-devel] [PATCH docs 1/2] zfs: fix #3479 rephrase boot-loader description.

2022-04-12 Thread Stoiko Ivanov
since using proxmox-boot-tool also for legacy systems the distinction of p-b-t vs grub is not accurate anymore. Signed-off-by: Stoiko Ivanov --- local-zfs.adoc | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index e77595f..ab0f6ad 10064

[pve-devel] [PATCH docs 2/2] sys: boot: minimally document kernel version pinning

2022-04-12 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- system-booting.adoc | 48 + 1 file changed, 48 insertions(+) diff --git a/system-booting.adoc b/system-booting.adoc index 2b96409..7d8ff47 100644 --- a/system-booting.adoc +++ b/system-booting.adoc @@ -68,6 +68,7 @@ dev

[pve-devel] [PATCH docs 0/2] update proxmox-boot-tool docs

2022-04-12 Thread Stoiko Ivanov
the 2 patches are independent of each other (I had overlooked 3479 for a while) Stoiko Ivanov (2): zfs: fix #3479 rephrase boot-loader description. sys: boot: minimally document kernel version pinning local-zfs.adoc | 8 ++-- system-booting.adoc | 48 +++

[pve-devel] [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes

2022-04-12 Thread Stefan Sterz
since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. requires a bump of the widget toolkit in order to use the `pmxNotesView`. Signed-off-by: Stefan Sterz --- i chose the maxLength of a note in pbs to be 1022*64 because the server allows at

[pve-devel] [PATCH proxmox-backup v5 0/5] fix 3067: add notes functionality in webui

2022-04-12 Thread Stefan Sterz
adds support for markdown-based notes to pbs. It also refactors the pve `NotesView` panel and `NotesEdit` window so that we can move it to the widget toolkit and maintain a single version of the two. hence, the last commits for proxmox-backup and pve-manager need to be applied and bumped with or af

[pve-devel] [PATCH widget-toolkit v5 3/5] toolkit: refactor markdown based NotesView and NotesEdit

2022-04-12 Thread Stefan Sterz
refactor them to make them more flexible and, thus, usable in pbs. adds parameters for enabling the TBar, setting the help section in the editing dialog and cleans up the code in some places Signed-off-by: Stefan Sterz --- src/panel/NotesView.js | 135 +++- s

[pve-devel] [PATCH manager v5 4/5] ui: move NotesView panel and NotesEdit window to widget kit

2022-04-12 Thread Stefan Sterz
this removes the NotesView panel and NotesEdit and replaces them with with the version from the widget kit. requires a bump of the widget toolkit. Signed-off-by: Stefan Sterz --- www/manager6/Makefile | 2 - www/manager6/dc/Config.js | 2 +- www/manager6/node/Config.js

[pve-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window

2022-04-12 Thread Stefan Sterz
move them here from pve so we can maintain them across several products Signed-off-by: Stefan Sterz --- src/Makefile| 2 + src/panel/NotesView.js | 129 src/window/NotesEdit.js | 38 3 files changed, 169 insertions(+) create

[pve-devel] [PATCH proxmox-backup v5 1/5] fix #3067: docs: add markdown primer from pve to pbs

2022-04-12 Thread Stefan Sterz
this copies the markdown primer from the pve docs to allow access to it via the help buttons in the gui Signed-off-by: Stefan Sterz --- docs/index.rst | 1 + docs/markdown-primer.rst | 178 +++ 2 files changed, 179 insertions(+) create mode 100644

[pve-devel] [PATCH manager v6 02/11] api: /version: add 'tag-colors' and 'tag-tree-style'

2022-04-12 Thread Dominik Csapak
to be able to get them in the gui directly after login Signed-off-by: Dominik Csapak --- PVE/API2.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/API2.pm b/PVE/API2.pm index a4256160..0592d4de 100644 --- a/PVE/API2.pm +++ b/PVE/API2.pm @@ -111,6 +111,16 @@

[pve-devel] [PATCH manager v6 01/11] api: /cluster/resources: add tags to returned properties

2022-04-12 Thread Dominik Csapak
by querying 'lock' and 'tags' with 'get_guest_config_properties' Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 718a8eb9..01a21c9e 100644 --- a/PVE/API2/Cluster.pm

[pve-devel] [PATCH cluster v6 2/3] Cluster: add get_guest_config_properties

2022-04-12 Thread Dominik Csapak
akin to get_guest_config_property, but with a list of properties. uses the new CFS_IPC_GET_GUEST_CONFIG_PROPERTIES also adds the same NOTEs regarding parsing/permissions to the comment of get_guest_config_property Signed-off-by: Dominik Csapak --- data/PVE/Cluster.pm | 27 ++

[pve-devel] [PATCH manager v6 10/11] ui: tree/ResourceTree: show Tags in tree

2022-04-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js| 4 +++- www/manager6/qemu/Config.js | 4 +++- www/manager6/tree/ResourceTree.js | 4 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 9f199

[pve-devel] [PATCH manager v6 04/11] ui: tree/ResourceTree: collect tags on update

2022-04-12 Thread Dominik Csapak
into a global list, so that we have it avaiable anywhere also add the tags from the tagOverrides on update into the list Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 7 +++ www/manager6/data/ResourceStore.js | 6 ++ www/manager6/tree/ResourceTree.js | 16

[pve-devel] [PATCH manager v6 03/11] ui: parse and save tag color overrides from /version

2022-04-12 Thread Dominik Csapak
into a global list of overrides. on update, also parse the values from the browser localstore Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 39 +++ www/manager6/Workspace.js | 13 + 2 files changed, 52 insertions(+) diff --git a/ww

[pve-devel] [PATCH manager v6 06/11] ui: dc/OptionView: add editors for tag settings

2022-04-12 Thread Dominik Csapak
namely for 'tag-tree-style' and 'tag-colors'. display the tag overrides directly as they will appear as tags Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 20 www/manager6/dc/OptionView.js | 43 ++- 2 files changed, 62 insertio

[pve-devel] [PATCH manager v6 11/11] ui: form/GlobalSearchField: display tags and allow to search for them

2022-04-12 Thread Dominik Csapak
each tag is treated like a seperate field, so it weighs more if the user searches for the exact string of a single tag Signed-off-by: Dominik Csapak --- www/manager6/form/GlobalSearchField.js | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/www/manager6/f

[pve-devel] [PATCH manager v6 09/11] ui: {lxc, qemu}/Config: show Tags and make them editable

2022-04-12 Thread Dominik Csapak
add the tags in the status line, and add a button for adding new ones Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 32 ++-- www/manager6/qemu/Config.js | 31 +-- 2 files changed, 59 insertions(+), 4 deletions(-) diff --g

[pve-devel] [PATCH cluster v6 3/3] datacenter.cfg: add option for tag-tree-style and tag-colors

2022-04-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- data/PVE/DataCenterConfig.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 6c0fa5b..c21dbb7 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm @@

[pve-devel] [PATCH cluster/widget-toolkit/manager v6] add tags to ui

2022-04-12 Thread Dominik Csapak
this series brings the already existing 'tags' for ct/vms to the gui: * tags can be edited in the status toolbar of the guest * existing tags will be shown in the tree/global search * when editing a tag, a list of existing tags will be shown * by default, the color is (consistently) autogenerated b

[pve-devel] [PATCH manager v6 08/11] ui: add form/TagEdit.js

2022-04-12 Thread Dominik Csapak
this is a wrapper container for holding a list of (editable) tags intended to be used in the lxc/qemu status toolbar Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/form/TagEdit.js | 132 +++ 2 files changed, 133 insertions(+)

[pve-devel] [PATCH widget-toolkit v6 1/1] add tag related helpers

2022-04-12 Thread Dominik Csapak
helpers to * generate a color from a string consistently * generate a html tag for a tag * related css classes contrast is calculated according to SAPC draft: https://github.com/Myndex/SAPC-APCA which is likely to become a w3c guideline in the future and seems to be a better algorithm for this S

[pve-devel] [PATCH manager v6 07/11] ui: add form/Tag

2022-04-12 Thread Dominik Csapak
displays a single tag, with the ability to edit inline on click (when the mode is set to editable). This brings up a list of globally available tags for simple selection. Also has a mode for adding a new Tag. This has a 'layoutCallback' which will be called on input, so that the parent component

[pve-devel] [PATCH cluster v6 1/3] add CFS_IPC_GET_GUEST_CONFIG_PROPERTIES method

2022-04-12 Thread Dominik Csapak
for getting multiple properties from the in memory config of the guests. I added a new CSF_IPC_ call to maintain backwards compatibility. It basically behaves the same as CFS_IPC_GET_GUEST_CONFIG_PROPERTY, but takes a list of properties instead. The old way of getting a single property is now als

[pve-devel] [PATCH manager v6 05/11] ui: add form/TagColorGrid

2022-04-12 Thread Dominik Csapak
this provides a basic grid to edit a list of tag color overrides. We'll use this for editing the datacenter.cfg overrides and the browser storage overrides. Signed-off-by: Dominik Csapak --- www/css/ext6-pve.css | 5 + www/manager6/Makefile | 1 + www/manager6/Utils.

[pve-devel] [PATCH storage] rbd: fix #3969: add rbd dev paths with cluster info

2022-04-12 Thread Aaron Lauterer
By adding our own customized rbd udev rules and ceph-rbdnamer we can create device paths that include the cluster fsid and avoid any ambiguity if the same pool and namespace combination is used in multiple clusters we connect to. Additionally to the '/dev/rbd//...' paths we now have '/dev/rbd-pve/

[pve-devel] [PATCH manager] cli: acme: Allow to get certificates from CAs requiring EAB

2022-04-12 Thread Ember 'n0emis' Keske via pve-devel
--- Begin Message --- From: Ember 'n0emis' Keske to allow to fetch certificates from CA's like sectigo or zerossl. The CLI checks, if the CA requires EAB credentials and promts the user to enter them on demand. Signed-off-by: Ember 'n0emis' Keske --- PVE/API2/ACMEAccount.pm | 74 ++