Re: [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint

2021-08-31 Thread Thomas Lamprecht
On 30.08.21 13:54, Lorenz Stechauner wrote: > On 26.08.21 18:30, Thomas Lamprecht wrote: >> On 03/08/2021 14:16, Lorenz Stechauner wrote: >>> @@ -486,6 +486,7 @@ __PACKAGE__->register_method ({ >>>   print "command: " . join(' ', @$cmd) . "\n"; >>>     eval { run_command($cmd, errms

[pve-devel] [PATCH v4 storage 4/4] status: fix tmpfile cleanup

2021-08-31 Thread Lorenz Stechauner
$tmpfilename already gets unlinked after executing the cmd. furthermore, because this is a local file, it is wrong to delete it via the ssh command on a remote node. small change: added \n to the error message. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 4 ++-- 1 file ch

[pve-devel] [PATCH v4 storage 2/4] status: remove sleep(1) in file upload

2021-08-31 Thread Lorenz Stechauner
this racey sleep(1) is only there for legacy reasons: because we don't use apache anymore and only emulate its behabiour regarding removing temp files, this is under our own control now and so we can improve this whole situation. this change requires a pve-http-server version, in which the tmpfile

[pve-devel] [PATCH v4 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-08-31 Thread Lorenz Stechauner
any uploaded file has to be deleted by the corrosponding endpoint. the file upload was only used by the 'upload to storage' feature in pve. this change allows the endpoint to delete the file itself, making the old and racey`sleep 1` (waiting until the worker has opened the file) obsolete. this ch

[pve-devel] [PATCH v4 storage 1/4] status: move unlink from http-server to enpoint

2021-08-31 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index b838461..

[pve-devel] [PATCH v4 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 489be9dc..f0c6186f 100644 --- a/www/manager6/wind

[pve-devel] [PATCH-SERIES v4 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload

2021-08-31 Thread Lorenz Stechauner
changes to v3: * added comment regarding tmpfile cleanup * added commit fixing the cleanup of tmpfile * fixed commit in http-server; every call to cleanup_reqchange() is now updated Lorenz Stechauner (1): anyevent: move unlink from http-server to endpoint src/PVE/APIServer/AnyEvent.pm |

[pve-devel] [PATCH v4 manager 5/5] ui/UplaodToStorage: check file extension

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index f0c6186f..ec83c581 100644 --- a/www/manager6/window/UploadToStorage.js +++ b/

[pve-devel] [PATCH v4 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 40 ++ 1 file changed, 40 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index e7db41fb..489be9dc 100644 --- a/www/manager6/window/Up

[pve-devel] [PATCH v4 storage 3/4] fix #3505: status: add checksum and algorithm to file upload

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 37 + 1 file changed, 37 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 6493d22..41b3696 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/

[pve-devel] [PATCH v4 manager 1/5] ui: move upload window into UploadToStorage.js

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode 100

[pve-devel] [PATCH v4 manager 2/5] ui: refactor UploadToStorage.js

2021-08-31 Thread Lorenz Stechauner
this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. the check for FormData() is also removed, because this is supported by all major browsers for a long time. therefore doStandardSubmit() is al

[pve-devel] [PATCH v2 pve-docs 1/4] remove pvenode.adoc from chapter 18

2021-08-31 Thread Dylan Whyte
removes pvenode.adoc inclusion from chapter 18, "Shell interface for the Proxmox VE API", as the section is already included as part of section 3.10 "Proxmox Node Management" Signed-off-by: Dylan Whyte --- changes from v1: * new patch. noticed after linking to pvenode.adoc from qm.adoc and pct.a

[pve-devel] [PATCH v2 pve-docs 3/4] pvenode: add task & migrate/stop/startall sections

2021-08-31 Thread Dylan Whyte
Adds PVE Node Management sections related to viewing task history, and bulk operations for starting, stopping, and migrating all guests. Signed-off-by: Dylan Whyte --- changes from v1: * New patch, adding sections for items requested by @Thomas pvenode.adoc | 64

[pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: language fix-up

2021-08-31 Thread Dylan Whyte
minor corrections to the introduction and wake-on-lan section of "Proxmox VE Node Management" also expand introduction, based on new content Signed-off-by: Dylan Whyte --- changes from v1: * New patch. May as well do some fix-up while I'm here! pvenode.adoc | 28 +++- 1

[pve-devel] [PATCH v2 pve-docs 2/4] fix #844: document first VM/CT start-up delay

2021-08-31 Thread Dylan Whyte
adds subsection to the "PVE Node Management" section, discussing the initial VM/CT startup delay feature. also makes reference to this in the Qemu & LXC sections of the documentation. Signed-off-by: Dylan Whyte --- changes from v1: * Add section to PVE node management section and cross referenc

[pve-devel] [PATCH pve-manager 2/2] pvenode task log: don't hardcode 'limit' in CLI

2021-08-31 Thread Dylan Whyte
Removes the hardcoded '--limit' option when setting up the 'pvenode task log' command. This allows a user to control this option themselves. Also changes the default limit from 50 to 500, as this is what we use in the GUI, and should be plenty for the majority of tasks. Signed-off-by: Dylan Whyte

[pve-devel] [PATCH pve-manager 1/2] Add/fix option descriptions in pvenode api docs

2021-08-31 Thread Dylan Whyte
Adds some missing descriptions to the api/man page documentation, for certain options of the `pvenode` command. Some minor language fix-ups are also included Signed-off-by: Dylan Whyte --- PVE/API2/Tasks.pm | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/

Re: [pve-devel] [PATCH v2 pve-docs 3/4] pvenode: add task & migrate/stop/startall sections

2021-08-31 Thread Thomas Lamprecht
On 31.08.21 12:44, Dylan Whyte wrote: > Adds PVE Node Management sections related to viewing task history, and > bulk operations for starting, stopping, and migrating all guests. > > Signed-off-by: Dylan Whyte > --- > changes from v1: > * New patch, adding sections for items requested by @Thomas

[pve-devel] applied: [PATCH pve-manager 1/2] Add/fix option descriptions in pvenode api docs

2021-08-31 Thread Thomas Lamprecht
On 31.08.21 16:42, Dylan Whyte wrote: > Adds some missing descriptions to the api/man page documentation, for > certain options of the `pvenode` command. Some minor language fix-ups > are also included > > Signed-off-by: Dylan Whyte > --- > PVE/API2/Tasks.pm | 19 ++- > 1 file ch

Re: [pve-devel] [PATCH pve-manager 2/2] pvenode task log: don't hardcode 'limit' in CLI

2021-08-31 Thread Thomas Lamprecht
On 31.08.21 16:42, Dylan Whyte wrote: > Removes the hardcoded '--limit' option when setting up the > 'pvenode task log' command. This allows a user to control this option > themselves. > > Also changes the default limit from 50 to 500, as this is what we use in > the GUI, and should be plenty for