[pve-devel] [PATCH storage 3/3] pvesm: encryption key parameter should load files

2020-07-09 Thread Wolfgang Bumiller
also `pvesm set` and `pvesm add` should behave the same with respect to how configuration options are treated Signed-off-by: Wolfgang Bumiller --- PVE/CLI/pvesm.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 4f934d6..f223c92 10

[pve-devel] [PATCH storage 2/3] refactor sensitive parameter handling

2020-07-09 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- PVE/API2/Storage/Config.pm | 61 -- PVE/Storage/CIFSPlugin.pm | 6 PVE/Storage/PBSPlugin.pm | 6 ++-- 3 files changed, 41 insertions(+), 32 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/C

[pve-devel] [PATCH storage 1/3] pbs: encryption support, split "raw client command" API

2020-07-09 Thread Wolfgang Bumiller
(And deprecate it...) Signed-off-by: Wolfgang Bumiller --- PVE/Storage/PBSPlugin.pm | 126 +-- 1 file changed, 109 insertions(+), 17 deletions(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 092d800..31af450 100644 --- a/PVE/Storage/

[pve-devel] [PATCH manager] vzdump: included_guest: return empty hash if no guests selected

2020-07-09 Thread Aaron Lauterer
This will fix the behaviour when calling `vzdump --stop` to cause all local guests to be backed up. When refactoring this logic in commit be308647, the assumption was that every call will have one of the following parameters set: pool, list of VMIDs or all (intentional or when exclude is used). T

[pve-devel] applied: Re: [PATCH manager] vzdump: included_guest: return empty hash if no guests selected

2020-07-09 Thread Thomas Lamprecht
On 09.07.20 13:21, Aaron Lauterer wrote: > This will fix the behaviour when calling `vzdump --stop` to cause all > local guests to be backed up. > > When refactoring this logic in commit be308647, the assumption was that > every call will have one of the following parameters set: pool, list of > V

[pve-devel] applied-series: Re: [PATCH storage 1/3] pbs: encryption support, split "raw client command" API

2020-07-09 Thread Thomas Lamprecht
On 09.07.20 10:25, Wolfgang Bumiller wrote: > (And deprecate it...) > > Signed-off-by: Wolfgang Bumiller > --- > PVE/Storage/PBSPlugin.pm | 126 +-- > 1 file changed, 109 insertions(+), 17 deletions(-) > > applied series, thanks! Renamed the "encryption_key"

[pve-devel] applied: Re: [PATCH v3 qemu 1/2] PVE: add query_proxmox_support QMP command

2020-07-09 Thread Thomas Lamprecht
On 08.07.20 11:57, Stefan Reiter wrote: > Generic interface for future use, currently used for PBS and > dirty-bitmap backup support. > > Signed-off-by: Stefan Reiter > --- > > v2: > * include 'pbs' feature > > pve-backup.c | 8 > qapi/block-core.json | 24 +++

[pve-devel] applied: Re: [PATCH v3 container 1/4] fix #1423: add timezone config option

2020-07-09 Thread Thomas Lamprecht
On 02.07.20 14:49, Oguz Bektas wrote: > optionally enabled. > > adds the 'timezone' option to config, which takes a valid timezone (i.e. > Europe/Vienna) to set in the container. > > if nothing is selected, then it will show as 'container managed' in > GUI, and nothing will be done. > > if set t

[pve-devel] applied: Re: [PATCH widget-toolkit] Add focusable pseudo class to edit windows defaultFocus

2020-07-09 Thread Thomas Lamprecht
On 08.07.20 10:42, Fabian Möller wrote: > Restricting the defaultFocus of the edit windows to only focusable fields > ensures that windows like "PVE -> Virtual Machine -> Manage HA", which > has a first field of xtype "displayfield", receive focus upon opening. > > This allows those windows to be

Re: [pve-devel] [PATCH v3 qemu-server 3/3] fix #2671: include CPU format in man page again

2020-07-09 Thread Thomas Lamprecht
On 25.06.20 13:35, Stefan Reiter wrote: > Use the new register_format(3) call to use a validator (instead of a > parser) for 'pve-(vm-)?cpu-conf'. This way the $cpu_fmt hash can be used for > generating the documentation, while still applying the same verification > rules as before. > > Since the

[pve-devel] [PATCH qemu-server] fixup: use parse_property_string instead of parse_cpu_conf_basic

2020-07-09 Thread Stefan Reiter
The latter was removed and replaced with a validator. Signed-off-by: Stefan Reiter --- Too much Rust and static compilation... PVE/QemuMigrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 96de0db..b699b67 100644 --- a/PVE/

[pve-devel] [PATCH v4 manager 5/7] make use of archive_info and archive_remove

2020-07-09 Thread Fabian Ebner
to avoid some code duplication. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 601cd56e..2f509555 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -631,10 +631,15 @@

[pve-devel] [RFC container] fix #2762: add recursive bindmount option

2020-07-09 Thread Oguz Bektas
allows to mount bindmounts recursively. useful for mounting ZFS datasets in containers. Signed-off-by: Oguz Bektas --- @wobu is unsure about the security implications of this (bindmount + symlink + recursion), so i'm sending this first version as RFC to get reviewed. src/PVE/LXC.pm| 1

[pve-devel] [PATCH v4 storage 3/7] Add API and pvesm call for prune_backups

2020-07-09 Thread Fabian Ebner
For the pvesm call use a wrapper and a --dry-run option to redirect to the correct API call. Signed-off-by: Fabian Ebner --- Changes from v3: * allow filtering by type * pvesm: redirect to correct API call according to --dry-run PVE/API2/Storage/Makefile| 2 +- PVE/API2/Stora

[pve-devel] [PATCH v4 storage 2/7] Add prune_backups to storage API

2020-07-09 Thread Fabian Ebner
Implement it for generic storages supporting backups (i.e. directory-based storages) and add a wrapper for PBS. Signed-off-by: Fabian Ebner --- Changes from v3: * prune_mark: merge loops * allow filtering by type * more error handling * allow passing along a log function * ad

[pve-devel] [PATCH v4 storage 1/7] Introduce prune-backups property for directory-based storages

2020-07-09 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v3: * use property string validator PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/CephFSPlugin.pm| 1 + PVE/Storage/DirPlugin.pm | 5 +-- PVE/Storage/GlusterfsPlugin.pm | 5 +-- PVE/Storage/NFSPlugin.pm | 5 +-- PVE/Stora

[pve-devel] [PATCH v4 manager 6/7] Allow prune-backups as an alternative to maxfiles

2020-07-09 Thread Fabian Ebner
and make the two options mutally exclusive as long as they are specified on the same level (e.g. both from the storage configuration). Otherwise prefer option > storage config > default (only maxfiles has a default currently). Defines the backup limit for prune-backups as the sum of all keep-value

[pve-devel] [PATCH-SERIES v4] fix #2649: introduce prune-backups property for storages supporting backups

2020-07-09 Thread Fabian Ebner
A new 'prune-backups' option is introduced for storages as well as for vzdump Patches #1-#3 introduces prune-backups in the backend Patch #4 introduces the new vzdump parameter Patch #6 is the 'real' change needed for vzdump. Patch #7 gets rid of 'maxfiles' internally, re-using 'prune-backups' ins

[pve-devel] [PATCH v4 manager 7/7] Always use prune-backups instead of maxfiles internally

2020-07-09 Thread Fabian Ebner
For the use case with '--dumpdir', it's not possible to call prune_backups directly, so a little bit of special handling is required there. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 42 -- 1 file changed, 16 insertions(+), 26 deletions(-) diff --git

[pve-devel] [PATCH v4 guest-common 4/7] Add prune-backups option to vzdump parameters

2020-07-09 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- New in v4 PVE/VZDump/Common.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 909e3af..2f3c16e 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -210,6 +210,10 @@ my $confdesc = { mi

[pve-devel] applied: Re: [PATCH qemu-server] fixup: use parse_property_string instead of parse_cpu_conf_basic

2020-07-09 Thread Thomas Lamprecht
On 09.07.20 14:41, Stefan Reiter wrote: > The latter was removed and replaced with a validator. > > Signed-off-by: Stefan Reiter > --- > > Too much Rust and static compilation... > > PVE/QemuMigrate.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH storage] vdisk_list: skip scanning storages which cannot have images/rootdisks

2020-07-09 Thread Thomas Lamprecht
Do not try to scan (and thus activate) storages which aren't configured to support (or cannot support) "vdisks" anyway. Avoids seemingly strange failures of VM migrations due to a backup storage not being currently online - even if that storage isn't referenced in the VM config anywhere.. Signed-

[pve-devel] applied: [PATCH container] vzdump: fix passing mountpoints for the PBS case

2020-07-09 Thread Thomas Lamprecht
The stop-mode case only worked by luck as then $snapdir == $rootdir. But for snapshots we rsync over a clean state to a separate directory, so this has to be used as base for the backup (just like tar does). Signed-off-by: Thomas Lamprecht --- src/PVE/VZDump/LXC.pm | 6 +++--- 1 file changed, 3

[pve-devel] applied-series: Re: [PATCH v4 manager 0/5] add backup detail and not backed up view

2020-07-09 Thread Thomas Lamprecht
On 07.07.20 11:48, Aaron Lauterer wrote: > This series add a new detail view for backup jobs to show which volumes > of a guest would be included. > > Additionally it adds a notification if there are any guests not covered > by any backup job with a new window showing these guests. This is to fix