commit description missing here as well..
I haven't tested this (or the first patches doing the blockdev conversion) yet,
but I see a few bigger design/architecture issues left (besides FIXMEs for
missing pieces that previously worked ;)):
- we should probably move the decision whether a snapsh
> DERUMIER, Alexandre hat am 04.04.2025
> 13:31 CEST geschrieben:
> Hi Fabian,
>
> >>the first one is the renaming of a blockdev while it is used, which
> >>is currently done like this:
> >>-- "link" snapshot path to make it available under old and new name
> >>-- handle blockdev additions/reo
--- Begin Message ---
> I have reused vdisk_free for this one, as I'm seeing a comment about
> $running deprecation in Storage.pm
>
> # FIXME PVE 8.x remove $running parameter (needs APIAGE reset)
> sub volume_snapshot_delete {
> my ($cfg, $volid, $snap, $running) = @_;
>
>
> vdisk_free have
--- Begin Message ---
Hi Fabian,
>>the first one is the renaming of a blockdev while it is used, which
>>is currently done like this:
>>-- "link" snapshot path to make it available under old and new name
>>-- handle blockdev additions/reopening/backing-file updates/deletions
>>on the qemu layer
>>
--- Begin Message ---
>>- we should probably move the decision whether a snapshot is done on
>>the storage layer or by qemu into the control of the storage plugin,
>>especially since we are currently cleaning that API up to allow
>>easier implementation of external plugins
Agree with that indeed,
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
PVE/QemuConfig.pm | 4 +-
PVE/QemuServer.pm | 226 +---
PVE/QemuServer/Drive.pm | 4 +
3 files changed, 220 insertions(+), 14 deletions(-)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConf
