--- Begin Message ---> I have reused vdisk_free for this one, as I'm seeing a comment about > $running deprecation in Storage.pm > > # FIXME PVE 8.x remove $running parameter (needs APIAGE reset) > sub volume_snapshot_delete { > my ($cfg, $volid, $snap, $running) = @_; > > > vdisk_free have also a cluster_lock_storage, so for lvm , I think > it's > better. > > (I have introduce a $snap param to vdisk_free, to only delete the > specific snapshot, and not the whole chain)>>vdisk_free is definitely wrong - you are not deleting a vdisk, just a >>snapshot.. I think this might be an argument for keeping $running ;) >> ok, I wasn't sure about it >>you can call the lock inside volume_snapshot_delete, right? yes sure. I'll work on it next week, with all others changes you have requested.
--- End Message ---
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
