Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-25 Thread Thomas Lamprecht
For the record, we talked about this in person for a bit with the following outcome: - there was a bit of a misunderstanding w.r.t. my heavy exaggeration for the point's sake, I really did not mean that as accusation at all, but that's now talked out - it's a good point that the package that

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-05 Thread Fiona Ebner
Am 04.07.24 um 19:45 schrieb Thomas Lamprecht: > Am 04/07/2024 um 14:11 schrieb Fiona Ebner: >> There is no apiinfo call required anymore. No code is the cleanest kind > > Yeah, by the assumption you self choose to use and that I question, so > not really a useful argument. > > In practice, users

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-05 Thread Thomas Lamprecht
Am 04/07/2024 um 14:11 schrieb Fiona Ebner: > Yes, next time we introduce an apiinfo call, we can just have it fail > hard upon errors. Oh, and just to avoid potential future error potential here: For a new topic-specific API version call that might not work, as the fallback and (lacking) error ha

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-04 Thread Thomas Lamprecht
Am 04/07/2024 um 14:11 schrieb Fiona Ebner: > There is no apiinfo call required anymore. No code is the cleanest kind Yeah, by the assumption you self choose to use and that I question, so not really a useful argument. In practice, users can upgrade a from one major release to the next one, nothi

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-04 Thread Fiona Ebner
Am 04.07.24 um 13:51 schrieb Thomas Lamprecht: > Am 04/07/2024 um 12:28 schrieb Fiona Ebner: >> Am 04.07.24 um 11:52 schrieb Thomas Lamprecht: >>> Am 10/06/2024 um 11:04 schrieb Fiona Ebner: The storage API version has been bumped to at least 9 since libpve-storage = 7.0-4. If the source

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-04 Thread Thomas Lamprecht
Am 04/07/2024 um 12:28 schrieb Fiona Ebner: > Am 04.07.24 um 11:52 schrieb Thomas Lamprecht: >> Am 10/06/2024 um 11:04 schrieb Fiona Ebner: >>> The storage API version has been bumped to at least 9 since >>> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where >>> this change will c

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-04 Thread Fiona Ebner
Am 04.07.24 um 11:52 schrieb Thomas Lamprecht: > Am 10/06/2024 um 11:04 schrieb Fiona Ebner: >> The storage API version has been bumped to at least 9 since >> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where >> this change will come in, then the target node can be assumed to be

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-04 Thread Thomas Lamprecht
Am 10/06/2024 um 11:04 schrieb Fiona Ebner: > The storage API version has been bumped to at least 9 since > libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where > this change will come in, then the target node can be assumed to be > running either Proxmox VE 8 or, during upgrade, th

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-02 Thread Max Carrara
On Mon Jun 10, 2024 at 11:04 AM CEST, Fiona Ebner wrote: > The storage API version has been bumped to at least 9 since > libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where > this change will come in, then the target node can be assumed to be > running either Proxmox VE 8 or, durin

[pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-06-10 Thread Fiona Ebner
The storage API version has been bumped to at least 9 since libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where this change will come in, then the target node can be assumed to be running either Proxmox VE 8 or, during upgrade, the latest version of Proxmox VE 7.4, so it's safe to