Thank you for tackling this!
On 5/5/25 14:57, Fiona Ebner wrote:
> As reported in the enterprise support, it can happen that a guest
> agent command is read, but then the guest agent never sends an answer,
> because the service in the guest is stopped/killed. For example, if a
> guest reboot happe
On 4/15/25 16:10, Timo Veith wrote:
> Hello Mira,
>
> thank you very much for your reply.
>
>> Am 15.04.2025 um 11:09 schrieb Mira Limbeck :
>>
>> Hi Timo,
>>
>> At the moment I'm working on storage mapping support for iSCSI.
>> This would al
Hi Timo,
At the moment I'm working on storage mapping support for iSCSI.
This would allow one to configure different portals on each of the hosts
that are logically the same storage.
If you tried setting up a storage via iSCSI where each host can only
access a part of the portals which are announ
The previous regex matched exactly that combination of characters,
rather than any combination of the specified ones.
Fixes: e80f840 ("openid: make groups-claim RE more restrictive")
Signed-off-by: Mira Limbeck
---
src/PVE/Auth/OpenId.pm | 2 +-
1 file changed, 1 insertion(+),
library functions for optional userinfo
> endpoint
>
> proxmox-openid/src/lib.rs | 30 +-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
>
Tested the series with Authentik. Verified the userinfo endpoint query
with tcpdump.
Rebased proxmox-perl-rs
From: Thomas Skinner
Signed-off-by: Thomas Skinner
[ML: rebased on master, added code to common and pve-rs forwarding]
Signed-off-by: Mira Limbeck
---
PMG uses the functions as well, depending on how perlmod handles
unspecified parameters, those callsites may need to be updated.
common/src
On 3/24/25 04:37, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> pve-rs/src/openid/mod.rs | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/pve-rs/src/openid/mod.rs b/pve-rs/src/openid/mod.rs
> index 1fa7572..095ef26 100644
> --- a/pve-rs/src/openid/mo
+++---
>
>
> proxmox-openid:
>
> Thomas Skinner (1):
> fix #4411: openid: add library code for generic id token claim support
>
> proxmox-openid/src/lib.rs | 55 +++++--
Works as expected, tested with Authentik:
Tested-by: Mir
forgot the link [0] in my previous reply:
https://pve.proxmox.com/wiki/Perl_Style_Guide
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
;openid groups claim '$groups_claim' is not
> found in claims");
> + }
> + }
> +
> my $ticket = PVE::AccessControl::assemble_ticket($username);
> my $csrftoken =
> PVE::AccessControl::assemble_csrf_prevention_token($username);
> my $cap = $rpcenv->compute_api_permission($username);
There are some trailing whitespaces, wrongly mixed tabs and spaces, and
some space-only indentations.
The indentation scheme used [0] is not that straightforward. It can be
fixed up when applying the patch, so no need to send a v6 unless there
are some other issues.
Other than the whitespace issues the code looks good.
So consider this:
Tested-by: Mira Limbeck
Reviewed-by: Mira Limbeck
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
The patch looks good to me. Thank you!
Consider this:
Tested-by: Mira Limbeck
Reviewed-by: Mira Limbeck
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> Thomas Skinner hat am 24.03.2025 03:37 CET geschrieben:
>
>
> Signed-off-by: Thomas Skinner
> ---
> pveum.adoc | 37 +
> 1 file changed, 37 insertions(+)
>
> diff --git a/pveum.adoc b/pveum.adoc
> index 81565ab..5da0e98 100644
> --- a/pveum.adoc
> +++ b/
the v4!
I gave it a spin with Authentik again as OIDC provider.
It behaved as expected, including the log message for invalid group
names:
```
Mar 25 17:24:26 pve80-ceph18-staging-1 pvedaemon[31077]: openid group
'test!2345' contains invalid characters
```
One small issue with the docs
On 3/18/25 17:11, Friedrich Weber wrote:
> Hi, thanks for the new version! I think this is shaping up nicely. Some
> comments inline below, but only minor ones. So it may make sense to wait
> a couple of days for additional comments from others before sending a
> new version. I'll also run a few mo
On 3/17/25 13:18, Fabian Grünbichler wrote:
> On February 13, 2025 12:03 pm, Fabian Grünbichler wrote:
>>
>>> Mira Limbeck hat am 12.02.2025 15:51 CET
>>> geschrieben:
>>>
>>>
>>> On 2/11/25 06:40, Thomas Skinner wrote:
>>>> Si
Thank you for the v2!
some comments inline
> +sub iscsi_test_session {
> +my ($sid) = @_;
> +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1'];
> +
> +my $res = 0;
> +eval {
> +run_command($cmd, errmsg => 'iscsi session test failed', outfunc =>
> sub {
> +
On 3/7/25 12:59, Mira Limbeck wrote:
> Thank you for the patch!
>
> some comments inline
>
>> +sub iscsi_test_session {
>> +my ($portal, $sid) = @_;
>> +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1'];
Thank you for the patch!
some comments inline
> +sub iscsi_test_session {
> +my ($portal, $sid) = @_;
> +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1'];
> +
> +my $res = 0;
> +eval {
> +run_command($cmd, errmsg => 'iscsi session test failed', outfunc =>
On 2/8/25 06:42, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> pve-rs/src/openid/mod.rs | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/pve-rs/src/openid/mod.rs b/pve-rs/src/openid/mod.rs
> index 1fa7572..8f914ad 100644
> --- a/pve-rs/src/openid/mod
On 2/8/25 06:42, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> src/PVE/API2/OpenId.pm | 6 +-
> src/PVE/Auth/OpenId.pm | 7 +++
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm
> index 77410e6..456e96a
On 2/8/25 06:42, Thomas Skinner wrote:
> Continues work on adding an option to disable querying the userinfo endpoint
> for an
> OIDC provider.
>
> Changes since v2:
> - Adjust verify_authorization_code in pve-rs to be backwards compatible
> - Fix defaults in wrapper functions
>
> access-control
On 2/13/25 12:01, Fiona Ebner wrote:
> Am 10.02.25 um 13:07 schrieb Daniel Herzig:
>> From: Leo Nunner
>>
>> The code to generate the actual configuration works pretty much the same
>> as with the VM system. We generate an instance ID by hashing the user
>> configuration, causing cloud-init to run
On 2/13/25 11:10, Fiona Ebner wrote:
> Am 10.02.25 um 13:07 schrieb Daniel Herzig:
>> From: Leo Nunner
>>
>> Introduce configuration parameters for cloud-init. Like with VMs, it's
>> possible to specify:
>> - user
>> - password
>> - ssh keys
>> - enable/disable updates on first boo
On 2/11/25 06:40, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> src/PVE/API2/OpenId.pm | 79
> src/PVE/AccessControl.pm | 2 +-
> src/PVE/Auth/OpenId.pm | 33 +
> src/PVE/Auth/Plugin.pm | 1 +
> 4 files changed, 114
On 2/11/25 06:40, Thomas Skinner wrote:
> Continued work on adding support for OIDC groups.
>
> changes since v2:
> - Move RE for group name characters to Plugin.pm
> - Undo refactoring of user group deletion
> - Refactor logic to use hashes instead of arrays
> - Cleanup code style
> - Add RE and
On 11/19/24 12:55, Maximiliano Sandoval wrote:
>
> Mira Limbeck writes:
>
>> Signed-off-by: Mira Limbeck
>> ---
>> Proxmox/Install.pm | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
>
If it is set and 0, don't warn.
Signed-off-by: Mira Limbeck
---
v2:
- added check != 0
- fixed punctuation in text
Proxmox/Install.pm | 4
1 file changed, 4 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..e278917 100644
--- a/Proxmox/Install.pm
On 11/19/24 11:45, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> Proxmox/Install.pm | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Pro
Signed-off-by: Mira Limbeck
---
Proxmox/Install.pm | 4
1 file changed, 4 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..da8fb55 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -555,6 +555,10 @@ sub create_lvm_volumes {
my $maxvz
On 9/1/24 18:55, Thomas Skinner wrote:
> This patch series adds support for groups for OpenID logins.
>
> The following options are implemented:
> - Configurable claim for retrieving a list of groups and adding them to the
> user in PVE
> - Allowing "synchronization" of groups on login b
estatd's iteration time of 10 seconds, but
> more tolerable. Logins will still be continuously retried by pvestatd
> in every iteration until there is a session to each discovered portal.
>
> Signed-off-by: Friedrich Weber
> Tested-by: Mira Limbeck
> Reviewed-by: Mira Limbeck
retries, see the comment for `initial_login_retry_max`:
# Note that if the login fails
# quickly (before node.conn[0].timeo.login_timeout fires) because the
network
# layer or the target returns an error, iscsid may retry the login more than
# node.session.initial_login_retry_max times.
So especiall
On 7/30/24 21:14, Thomas Lamprecht wrote:
> Am 30/07/2024 um 17:15 schrieb Mira Limbeck:
>> Cloudbase-Init, a cloud-init reimplementation for Windows, supports only
>> a subset of the configuration options of cloud-init. Some features
>> depend on support by the Metadata
Signed-off-by: Mira Limbeck
---
v3:
- fixed list continuity/indentation
v2:
- added metadata_services config option
- added Sysprep section
- fixed typos and clarified some parts
qm-cloud-init.adoc | 154 +
1 file changed, 154 insertions(+)
diff
plaintext password in the guest.
The `citype` needs to be `configdrive2`, which is the default for
Windows guests, for the generated configs to be compatible with
Cloudbase-Init.
[0] https://cloudbase-init.readthedocs.io/en/latest/index.html
Signed-off-by: Mira Limbeck
---
v3:
- removed `use
URI is used in multiple files:
PVE/API2/Qemu.pm
PVE/CLI/qm.pm
PVE/QemuServer.pm
PVE/QemuServer/Cloudinit.pm
Dependencies of qemu-server already have it as dependency, but there's
no explicit dependency in qemu-server yet.
Signed-off-by: Mira Limbeck
---
debian/control | 2 ++
1 file chang
On 7/29/24 19:22, Thomas Lamprecht wrote:
> Am 29/07/2024 um 17:19 schrieb Mira Limbeck:
>> cloudbase-init, a cloud-init reimplementation for Windows, supports only
>> a subset of the configuration options of cloud-init. Some features
>> depend on support by the Metadata Servi
Signed-off-by: Mira Limbeck
---
v2:
- added metadata_services config option
- added Sysprep section
- fixed typos and clarified some parts
qm-cloud-init.adoc | 147 +
1 file changed, 147 insertions(+)
diff --git a/qm-cloud-init.adoc b/qm-cloud
that
depend on the current ConfigDrive2 implementation.
[0] https://cloudbase-init.readthedocs.io/en/latest/index.html
Signed-off-by: Mira Limbeck
---
v2:
- unchanged
v1:
DNS search domains are not handled at all by the cloudbase-init ENI
parser.
The password is used for the Admin user specified
Thank you for testing it!
On 7/18/24 17:51, Friedrich Weber wrote:
> On 09/07/2024 17:12, Mira Limbeck wrote:
>> cloudbase-init, a cloud-init reimplementation for Windows, supports only
>> a subset of the configuration options of cloud-init. Some features
>> depend on su
Hi Matias,
Thank you for providing this detailed description of the issue!
We have an open issue in our bug tracker [0]. If it's alright with you
I'd add your text as-is to the bug tracker as a comment for additional
information/reasoning on why that change would be needed.
Feel free to add your
There seems to be an issue with the network adapter. Whenever the guest
is shutdown and started again it finds a new network adapter. Rebooting
instead of shutting down doesn't show the same behavior.
I'm not sure yet why this happens, but it seems to be caused by
cloudbase-init.
___
Signed-off-by: Mira Limbeck
---
qm-cloud-init.adoc | 79 ++
1 file changed, 79 insertions(+)
diff --git a/qm-cloud-init.adoc b/qm-cloud-init.adoc
index 8686ed7..4baab31 100644
--- a/qm-cloud-init.adoc
+++ b/qm-cloud-init.adoc
@@ -169,6 +169,85 @@ qm
that
depend on the current ConfigDrive2 implementation.
[0] https://cloudbase-init.readthedocs.io/en/latest/index.html
Signed-off-by: Mira Limbeck
---
DNS search domains are not handled at all by the cloudbase-init ENI
parser.
The password is used for the Admin user specified in the
cloudbase
Signed-off-by: Mira Limbeck
---
v2:
- add `api: ` prefix to commit msg
PVE/API2/APT.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 19f0baca0..4095e790f 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -774,6 +774,7 @@ __PACKAGE__
On 4/24/24 13:20, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> PVE/API2/APT.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 19f0baca0..4095e790f 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API
Signed-off-by: Mira Limbeck
---
PVE/API2/APT.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 19f0baca0..4095e790f 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -774,6 +774,7 @@ __PACKAGE__->register_method({
libpve-network-p
On 4/18/24 17:45, Alexander Zeidler wrote:
> On Thu, 2024-04-18 at 12:43 +0200, Mira Limbeck wrote:
>> On 4/18/24 11:16, Alexander Zeidler wrote:
>>> Successful boots which crashed somehow and sometime afterwards, will
>>> show the same "until" value (&quo
rces, would it maybe make sense to move `pvesubscription
get` and `pvesh get /cluster/resources` next to each other, and `lscpu`
to the hardware section where we have all the `dmidecode` output, and
`lspci`?
Except for the `dmidecode -t16,17` command needin
On 4/18/24 11:16, Alexander Zeidler wrote:
> Successful boots which crashed somehow and sometime afterwards, will
> show the same "until" value ("still running" or timestamp) as the next
> following boot(s). The most recent boot from such a sequence of
> duplicated "until" lines, has not been crash
On 4/18/24 11:16, Alexander Zeidler wrote:
> While using keywords (-t bios,...) would be possible, depending on the
> server it also bloats the report with uninteresting information,
> hiding the relevant.
>
> Therefore the non-grouped, specific number types are used. Where we
> only need specific
On 4/18/24 11:16, Alexander Zeidler wrote:
> * to see if a RAM upgrade is slot/capacity-wise possible
> * to spot added/replaced RAM that may now be causing issues
>
> Maximum Capacity: 2 TB
> Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1
> Size: 16 GB Part Number: 18ASF2G72
x27;),
> response.htmlStatus);
> - },
> - });
> + },
> },
> - },
> + ],
> },
> {
> xtype: 'displayfield',
> @@ -125,6 +186,19 @@ Ext.define('PVE.node.ACMEAccountCreate', {
> },
> ],
>
> +clearToSFields: function() {
> + let me = this;
> +
> + let disp = me.down('#tos_url_display');
> + let field = me.down('#tos_url');
> + let checkbox = me.down('#tos_checkbox');
> +
> + disp.setValue("Terms of service not fetched yet");
> + field.setValue(undefined);
> + checkbox.setValue(undefined);
> + checkbox.setHidden(true);
> +},
> +
> });
>
> Ext.define('PVE.node.ACMEAccountView', {
Tested this patch series in a Debian 12 container with Pebble 2.4
installed via the Debian Bookworm repositories.
The behavior of the combobox changed with this patch. The combobox now
shows an `x` to clear it, but doesn't actually clear the selection.
Instead it always sets it to `Custom`.
Account creation worked like a charm using a custom directory and EAB
(with the 2nd patch).
Other than the combobox issue above, consider this and the 2nd patch:
Tested-by: Mira Limbeck
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
1452: also log stderr of remote command with
insecure storage migration")
Signed-off-by: Mira Limbeck
---
v3:
- added log prefix for remote error logs
- fixed style issues
v2:
- incorporated Fiona's suggestions
- added `Fixes: ...` to commit message
- kept old ip/port matching
h
insecure storage migration")
Signed-off-by: Mira Limbeck
---
v2:
- incorporated Fiona's suggestions
- added `Fixes: ...` to commit message
- kept old ip/port matching including # untaint comments
- added logging for all messages in STDERR
- simplified branches
src
in a migration or
replication failing.
the bare open3 call is replaced by the run_command wrapper from
pve-common to use a safe wrapper around open3 with the same
functionality.
STDERR is now read separately from STDOUT and the last line of STDERR
is kept in case of errors.
Signed-off-by: Mira Li
ile_write("$dev_sysfs_dir/remove", "1") if -e
> $dev_sysfs_dir;
> + if (-e $dev_sysfs_dir) {
> + warn "cleaning up mediated device $uuid\n";
> + PVE::SysFSTools::file_write("$dev_sysfs_dir/remove", "1&qu
el the query without resorting to
> the queryDelay hack.
>
> Reported-By: Mira Limbeck
> Signed-off-by: Stefan Hanreich
> ---
> www/manager6/form/IPRefSelector.js | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/www/manager6/form/
f;
> }
> },
> },
lgtm, consider this:
Reviewed-by: Mira Limbeck
Tested-by: Mira Limbeck
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 1/15/24 17:28, Stefan Hanreich wrote:
> Fallback to v.ref when we do not use an alias or ipset in order to be
> able to use normal CIDRs as source / destination address again
>
> Signed-off-by: Stefan Hanreich
> ---
> www/manager6/form/IPRefSelector.js | 4 +++-
> 1 file changed, 3 insertions
On 12/19/23 18:09, Aaron Lauterer wrote:
> The commit message doesn't explain the actual issue that it is trying to
> solve.
> AFAICT we do not need the ceph.conf symlinked right away for normal PVE
> operations. If it is not present in /etc/ceph/ceph.conf, the RBD and
> CephFS connections will use
The original patch removed the first branch of `if` condition, leaving the
`else` in which matched the `if` above.
The correct condition for this `else` is any bond mode that is not `lacp`
(4).
Signed-off-by: Mira Limbeck
---
...bond-remove-bond-min-links-0-warning.patch | 19
Looks like a python-cryptography maintainer opened a pull request on
Github with the exact same change:
https://github.com/proxmox/pve-common/pull/8
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/list
:
Version: Unknown (2)
```
Signed-off-by: Mira Limbeck
---
I wasn't able to create a test setup where I could test this yet, will
try again on monday.
Stoiko tested it on his setup with Let's Encrypt Staging and it worked
fine. Although he didn't extract the CSR to verify it.
A cu
On 12/16/22 11:31, Thomas Lamprecht wrote:
On 15/12/2022 17:57, Mira Limbeck wrote:
Since some users keep their passwords in the VM/CT configs as comments
and those are most of the time unnecessary when looking through the
report, filter those.
I'd rather have this optional, opt-out is
filtering, a new sub 'file2text' is introduced that
can filter the file contents if required.
This sub replaces the 'cat ...' commands.
Signed-off-by: Mira Limbeck
---
I did not add print to STDERR in file2text for now since it got quite
chatty.
If this is wanted, I'll send
If the config doesn't contain the cloud-init disk anymore after the
rollback, we have to clean it up since otherwise no further disk can be
attached unless the one still existing on the storage is deleted.
Signed-off-by: Mira Limbeck
Reviewed-by: Stefan Hanreich
Tested-by: Stefan Han
On 11/11/22 16:18, Stefan Hanreich wrote:
Test Setup:
I created a new VM, without any Cloud-Init drive, and immediately
created a snapshot. Then I setup a Cloud-Init drive according to the
PVE documentation via CLI. I created another snapshot of this state
with a Cloud-Init drive.
What I tes
On 11/11/22 09:36, DERUMIER, Alexandre wrote:
Le mercredi 09 novembre 2022 à 15:19 +0100, Mira Limbeck a écrit :
Why not add the bridge in the pve-bridge script as well? This way
there
would be no need for patch 2 for qemu-server since we always add the
MAC
address to the FDB whenever the tap
On 8/24/22 18:26, Alexandre Derumier wrote:
This disabling mac learning && unicast flood for the tap interface
for vmstart, we don't add mac directly to fdb.
We set it latter if it's a migration or a fresh start.
for nic hotplug, we directly add mac to fdb
Signed-off-by: Alexandre Derumier
--
On 8/24/22 18:26, Alexandre Derumier wrote:
at the end of a live migration, we need to remove old mac entries
on source host (vm is not yet stopped), before resume vm on target host
Signed-off-by: Alexandre Derumier
---
PVE/QemuMigrate.pm| 1 +
PVE/QemuServer.pm
If the config doesn't contain the cloud-init disk anymore after the
rollback, we have to clean it up since otherwise no further disk can be
attached unless the one still existing on the storage is deleted.
Signed-off-by: Mira Limbeck
---
v2:
- chose the add_unused_volume way as @
On 9/30/22 10:21, Fiona Ebner wrote:
Am 29.09.22 um 15:36 schrieb Mira Limbeck:
If the config doesn't contain the cloud-init disk anymore after the
rollback, we have to clean it up since otherwise no further disk can be
attached unless the one still existing on the storage is deleted.
S
If the config doesn't contain the cloud-init disk anymore after the
rollback, we have to clean it up since otherwise no further disk can be
attached unless the one still existing on the storage is deleted.
Signed-off-by: Mira Limbeck
---
PVE/QemuConfig.pm
When a disk exists but is not referenced in the config, it will be
reused instead of dying during the attempt to allocate the disk.
Signed-off-by: Mira Limbeck
---
This patch is not required to fix the rollback code, but might be nice
to have in addition since there will still be some users with
MAC filter was enabled as long as the VM firewall config existed even
with an invalid config.
With this change the check now matches the one for CTs.
Signed-off-by: Mira Limbeck
---
src/PVE/Firewall.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Firewall.pm b
rs in QEMU:
eaee072085 ("coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing")
29a6ea24eb ("coroutine-sleep: replace QemuCoSleepState pointer with struct in the
API")
[0]: https://forum.proxmox.com/threads/112130/
Signed-off-by: Fiona Ebner
---
Tested-by: Mira Limbec
Signed-off-by: Mira Limbeck
---
local-zfs.adoc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index 2dc25fd..1f4a4ed 100644
--- a/local-zfs.adoc
+++ b/local-zfs.adoc
@@ -547,6 +547,12 @@ improve performance when sufficient memory exists in a
system
On 5/16/22 13:04, DERUMIER, Alexandre wrote:
Le vendredi 06 mai 2022 à 12:11 +0200, Fabian Ebner a écrit :
This will break possibly existing workflows like
1. add second cloud-init
2. remove first cloud-init
to change the cloud-init storage.
Also, currently, in the gui, we can't add 2 cloud-ini
On 5/16/22 10:32, DERUMIER, Alexandre wrote:
---
Are there any scenarios where having multiple cloud-init drives is
useful?
I don't remember exactly how cloud-init daemon is mounting drives,
but I'm pretty sure that with multiple cloud-init drives,
only 1 will be mounted and read.
So,I'm 100%
On 6/17/22 10:42, Wolfgang Bumiller wrote:
On Wed, Jun 15, 2022 at 04:09:50PM +0200, Mira Limbeck wrote:
Azure AD seems to have a variable authorization code size, depending on
the browser state according to one report in bug #4074 [0].
Sometimes the size is greater than our current limit of
current experience, a size limit of 2048 might be enough for every
current OpenID Connect provider.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4074
[1] https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2
Signed-off-by: Mira Limbeck
---
The PBS implementation doesn't seem to be
Signed-off-by: Mira Limbeck
---
upstream pull request:
https://github.com/algesten/ureq/pull/495
.../patches/add-https-proxy-support.patch | 231 ++
src/ureq/debian/patches/series| 1 +
2 files changed, 232 insertions(+)
create mode 100644 src/ureq/debian
which is the case when using `send`. See
https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding
See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/
for the issue.
Signed-off-by: Mira Limbeck
---
v3:
- fixed link in inline comment
v2:
- added i
On 4/1/22 11:32, Mira Limbeck wrote:
Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint,
but with the switch to ureq we always send requests with this set.
Fix by switching to `Content-Length` in the header instead. ureq only
sets `Transfer-Encoding: chunked` whe
which is the case when using `send`. See
https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding
See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/
for the issue.
Signed-off-by: Mira Limbeck
---
v2:
- added inline comment
- removed the unnecessary
On 4/1/22 06:21, Dietmar Maurer wrote:
let response = if let Method::POST = request.method {
-req.send(&*request.body)
+let bytes = request.body.as_slice();
+req.send_bytes(bytes)
Does this have the side effect of changing the transfer encoding? If so, it is
worth
which is the case when using `send`. See
https://github.com/algesten/ureq/blob/main/README.md#content-length-and-transfer-encoding
See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/
for the issue.
Signed-off-by: Mira Limbeck
---
probably also fixes https://bugzilla.proxmo
ureq has support for a HTTP proxy, but no support for HTTPS proxy yet.
ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by
itself, the way curl does. So set the proxy in code if any of the above
environment variables are set.
Signed-off-by: Mira Limbeck
---
v2:
- ch
ureq has support for a HTTP proxy, but no support for HTTPS proxy yet.
ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by
itself the way curl does. So set the proxy in code if any of the above
environment variables are set.
Signed-off-by: Mira Limbeck
---
Perl's automatic conversion can lead to integers being converted to
strings, for example by matching it in a regex.
To make sure we always return an integer in the API call, add an
explicit cast to integer.
Signed-off-by: Mira Limbeck
Reviewed-by: Fabian Ebner
---
v3:
- fixed style
`qemu-img info --output=json` returns the size and used values as integers in
the JSON format, but the regex match converts them to strings.
As we know they only contain digits, we can simply cast them back to integers
after the regex.
The API requires them to be integers.
Signed-off-by: Mira
`qemu-img info --output=json` returns the size and used values as integers in
the JSON format, but the regex match converts them to strings.
As we know they only contain digits, we can simply cast them back to integers
after the regex.
The API requires them to be integers.
Signed-off-by: Mira
Perl's automatic conversion can lead to integers being converted to
strings, for example by matching it in a regex.
To make sure we always return an integer in the API calls, add
explicit casts to integer.
Signed-off-by: Mira Limbeck
---
v2: new
PVE/API2/Storage/Content.pm | 6 --
1
On 2/17/22 15:10, Fabian Ebner wrote:
Am 17.02.22 um 14:33 schrieb Mira Limbeck:
On 2/17/22 14:24, Fabian Ebner wrote:
Am 17.02.22 um 13:55 schrieb Mira Limbeck:
'qemu-img info' with output format 'json' returns the size and used
values as
integers, but the regex ma
On 2/17/22 14:24, Fabian Ebner wrote:
Am 17.02.22 um 13:55 schrieb Mira Limbeck:
'qemu-img info' with output format 'json' returns the size and used values as
integers, but the regex match converts them to strings.
As we know they only contain digits, we can simply cast t
'qemu-img info' with output format 'json' returns the size and used values as
integers, but the regex match converts them to strings.
As we know they only contain digits, we can simply cast them back to integers
after the regex.
The API requires them to be integers.
Signed-
>check_pool_exist($pool);
- $rpcenv->check_perm_modify($authuser, "/pool/$pool");
}
if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) {
Works when no Permissions.Modify and no Pool.Allocate
With the patch adding vendor-data support to cloud-init, a use of
uninitialized value was introduced. This can be fixed by setting it to
an empty string if no vendor-data is defined.
vendor-data can only be set via --cicustom and is optional.
Signed-off-by: Mira Limbeck
---
PVE/QemuServer
Looks good.
Reviewed-by: Mira Limbeck
On 10/30/21 4:49 PM, Constantin Herold wrote:
Signed-off-by: Constantin Herold
---
PVE/QemuServer.pm | 8
PVE/QemuServer/Cloudinit.pm | 25 -
2 files changed, 28 insertions(+), 5 deletions(-)
diff --git a
1 - 100 of 156 matches
Mail list logo
