On 4/18/24 11:16, Alexander Zeidler wrote: > * to see if a RAM upgrade is slot/capacity-wise possible > * to spot added/replaced RAM that may now be causing issues > > Maximum Capacity: 2 TB > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: No Module Installed > Size: No Module Installed > Size: No Module Installed > Size: No Module Installed > > Signed-off-by: Alexander Zeidler <a.zeid...@proxmox.com> > --- > v2: > * make regex stricter > * reduce possible dmidecode output which is not needed here > * reduce and clarify the printed information > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062348.html > > > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 9d1b9b27..d9f81a0f 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -113,6 +113,7 @@ my $init_report_cmds = sub { > 'cd /sys/devices/virtual/dmi/id; grep -HT "" sys_vendor > product_name product_version', > 'cd /sys/devices/virtual/dmi/id; grep -HT "" board_vendor > board_name board_version', > 'dmidecode -t 0,3,32', > + 'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | > sed -Ez "s/\n(\tP[^\n]*)/\1/g" | sort', Please add a space between `-t` and `16,17`.
> 'lspci -nnk', > ], > }, To be honest, I'm not a fan of this command. In those few cases it was interesting to see, we often wanted to see all the information. And the full dmidecode -t 17 output is just too much for the report. Not to mention the quite complicated `grep | sed | sort` part that might break on some systems that report things differently. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
