[pve-devel] [PATCH qemu-server v1 1/5] fix #6370: virtiofs: add support for thread-pool-size option

2025-05-05 Thread Markus Frank
Allows tuning the number of worker threads used by virtiofsd. Signed-off-by: Markus Frank --- PVE/QemuServer/Virtiofs.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/QemuServer/Virtiofs.pm b/PVE/QemuServer/Virtiofs.pm index cfde92c9..1894c95d 100644 --- a/PVE/QemuServer

[pve-devel] [PATCH docs v1 2/5] virtiofs: add explanation for cache=metadata behavior

2025-05-05 Thread Markus Frank
Adds a description of the `cache=metadata` mode and references the upstream patch that introduced it. Signed-off-by: Markus Frank --- qm.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 8b9e096..74f8304 100644 --- a/qm.adoc +++ b/qm.adoc

[pve-devel] [PATCH docs v1 4/5] virtiofs: add thread-pool-size description

2025-05-05 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 1549705..8cf75ca 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1334,12 +1334,13 @@ All Optional Parameters: |`expose-acl` |Enables ACL passthrough; implies `expose

[pve-devel] [PATCH qemu-server/docs/manager v1 0/5] virtiofs: add thread-pool-size and improve docs

2025-05-05 Thread Markus Frank
qemu-server: Markus Frank (1): fix #6370: virtiofs: add support for thread-pool-size option PVE/QemuServer/Virtiofs.pm | 9 + 1 file changed, 9 insertions(+) docs: Markus Frank (3): virtiofs: add explanation for cache=metadata behavior virtiofs: add table for optional

[pve-devel] [PATCH manager v1 5/5] fix #6370: ui: virtiofs edit: add support for thread-pool-size option

2025-05-05 Thread Markus Frank
Requires the qemu-server commit named "fix #6370: virtiofs: add support for thread-pool-size option". Set the maximum value to '256', the same as for the VM CPU cores. Signed-off-by: Markus Frank --- www/manager6/qemu/VirtiofsEdit.js | 10 ++ 1 file changed, 10

[pve-devel] [PATCH docs v1 3/5] virtiofs: add table for optional parameters

2025-05-05 Thread Markus Frank
Removes redundant explanatory text now covered by the table. Signed-off-by: Markus Frank --- qm.adoc | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qm.adoc b/qm.adoc index 74f8304..1549705 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1325,12 +1325,16 @@ xattrs

Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Markus Frank
On 2025-05-02 14:13, Fiona Ebner wrote: Am 02.05.25 um 13:52 schrieb Markus Frank: On 2025-04-28 12:17, Fiona Ebner wrote: As reported in the community forum [0] and the virtio-win project [1], virtiofsd will run into its open file limit when used with a Windows guest that reads too many

Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Markus Frank
tory and some of them do not support file handles. [0]: https://forum.proxmox.com/threads/165565/ [1]: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/1136 Signed-off-by: Fiona Ebner Tested-by: Markus Frank --- Didn't get around to measure the performance impact yet,

[pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Markus Frank
Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("check local resources: extend for mapped resources") Signed-off-by: Markus Frank --- T

[pve-devel] [PATCH qemu-server v2] fix: print error message that the resource mapping entry does not exist

2025-04-10 Thread Markus Frank
Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("check local resources: extend for mapped resources") Signed-off-by: Markus Frank

Re: [pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Markus Frank via pve-devel
--- Begin Message --- On 2025-04-10 13:18, Fiona Ebner wrote: Am 10.04.25 um 12:59 schrieb Markus Frank: Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. F

[pve-devel] [PATCH qemu-server] fix: print error message that the resource mapping entry does not exist

2025-04-09 Thread Markus Frank
Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("check local resources: extend for mapped resources") Signed-off-by: Markus Frank -

[pve-devel] [PATCH docs] virtiofs: add a description of how to install virtiofsd

2025-04-08 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qm.adoc b/qm.adoc index 39cf492..44e2436 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1269,6 +1269,12 @@ Linux VMs with kernel >=5.4 support virtiofs by default (https://www.kernelconfig

[pve-devel] [PATCH manager v17 10/10] ui: add options to add virtio-fs to qemu config

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank --- nothing changed in v17 www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 www/manager6/qemu/VirtiofsEdit.js | 143 ++ 4 files changed, 164 insertions

[pve-devel] [PATCH manager v17 09/10] ui: form: add selector for directory mappings

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- nothing changed in v17 www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2

[pve-devel] [PATCH qemu-server v17 4/10] migration: check_local_resources for virtiofs

2025-04-07 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- nothing changed in v17 PVE/QemuServer.pm| 10 +- test

[pve-devel] [PATCH manager v17 08/10] ui: add resource mapping view for directories

2025-04-07 Thread Markus Frank
To save vertical space in the Resource Mappings tab, there is a temporary Directory Mappings tab until we find content fitting the general 'resource mapping' panel and can put all types as submenu items. Signed-off-by: Markus Frank --- v17: * moved directory mapping in its own t

[pve-devel] [PATCH manager v17 06/10] api: add resource map api endpoints for directories

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- nothing changed in v17 PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308

[pve-devel] [PATCH docs v17 1/10] add doc section for the shared filesystem virtio-fs

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Daniel Kral --- nothing changed in v17 qm.adoc | 102 ++-- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 3eadac6..e0e1178 100644 --- a/qm.adoc +++ b/qm.adoc

[pve-devel] [PATCH manager v17 07/10] ui: add edit window for dir mappings

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank --- nothing changed in v17 www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 204 ++ 2 files changed, 205 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile

[pve-devel] [PATCH qemu-server v17 5/10] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- nothing changed in v17 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[pve-devel] [PATCH docs/qemu-server/manager v17 0/10] Virtio-fs

2025-04-07 Thread Markus Frank
dded check if virtiofsd is installed * pve-manager: * moved directory mapping in its own tab to save vertical space in the "Resource Mappings" tab - discussed off-list with Dominik docs: Markus Frank (1): add doc section for the shared filesystem virti

[pve-devel] [PATCH qemu-server v17 2/10] d/control: add virtiofsd to Recommends for qemu-server

2025-04-07 Thread Markus Frank
Signed-off-by: Markus Frank --- v17: * virtiofsd in Recommends instead of Depends debian/control | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/debian/control b/debian/control index 0acc3126..2a37ef7e 100644 --- a/debian/control +++ b/debian/control @@ -58,8 +58,9

[pve-devel] [PATCH qemu-server v17 3/10] fix #1027: virtio-fs support

2025-04-07 Thread Markus Frank
E: https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/README.md Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- v17: * added check if virtiofsd is installed PVE/API2/Qemu.pm | 41 ++- PVE/QemuServer.pm | 27 - PVE/QemuServer/Makefile

Re: [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-04-07 Thread Markus Frank
On 2025-04-07 14:00, Thomas Lamprecht wrote: Am 07.04.25 um 12:59 schrieb Markus Frank: On 2025-04-07 12:43, Thomas Lamprecht wrote: Would your code handle the case where the executable does not exist with a somewhat nice error? No, it does not. But it can easily be added. diff

Re: [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-04-07 Thread Markus Frank
On 2025-04-07 12:43, Thomas Lamprecht wrote: Am 04.04.25 um 18:08 schrieb Markus Frank: Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16

[pve-devel] [PATCH qemu-server v15 6/12] migration: check_local_resources for virtiofs

2025-04-05 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- v15: * removed unnecessary "if ($entry->{dirid})" check PVE/

[pve-devel] [PATCH qemu-server v15 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-04 Thread Markus Frank
Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-04 Thread Markus Frank
On 2025-04-04 10:27, Lukas Wagner wrote: On 2025-04-03 12:34, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p

[pve-devel] [PATCH manager v16 08/12] api: add resource map api endpoints for directories

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308

[pve-devel] [PATCH docs v16 3/12] add doc section for the shared filesystem virtio-fs

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Daniel Kral --- no changes in v16 qm.adoc | 102 ++-- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 2617a7c..63632fc 100644 --- a/qm.adoc +++ b/qm.adoc

[pve-devel] [PATCH manager v16 11/12] ui: form: add selector for directory mappings

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2

[pve-devel] [PATCH qemu-server v16 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE

[pve-devel] [PATCH qemu-server v16 5/7] fix #1027: virtio-fs support

2025-04-04 Thread Markus Frank
E: https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/README.md Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank Tested-by: Lukas Wagner --- no changes in v16 except rebase to master PVE/API2/Qemu.pm | 41 +++- PVE/QemuServer.pm | 27 ++

[pve-devel] [PATCH qemu-server v16 6/12] migration: check_local_resources for virtiofs

2025-04-04 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- v16: * rebase to master * replaced push with $mapped_res->{$k} = { n

[pve-devel] [PATCH manager v16 12/12] ui: add options to add virtio-fs to qemu config

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v16: * added hint for directory mapping in VirtiofsEdit www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 www/manager6/qemu/VirtiofsEdit.js | 143 ++ 4

[pve-devel] [PATCH manager v16 09/12] ui: add edit window for dir mappings

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v16: * adapted error message and added comment why there is also an error message in the GUI www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 204 ++ 2 files changed, 205 insertions(+) create mode 100644

[pve-devel] [PATCH manager v16 10/12] ui: add resource mapping view for directories

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Daniel Kral Tested-by: Daniel Kral --- no changes in v16 www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 38 +++ 3 files changed, 49 insertions

[pve-devel] [PATCH guest-common v16 2/12] add dir mapping section config

2025-04-04 Thread Markus Frank
Adds a config file for directories by using a 'map' property string for each node mapping. example config: ``` some-dir-id map node=node1,path=/path/to/share/ map node=node2,path=/different/location/ ``` Signed-off-by: Markus Frank --- v16: * renamed veri

[pve-devel] [PATCH cluster v16 1/12] add mapping/dir.cfg for resource mapping

2025-04-04 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v16 0/12] virtiofs

2025-04-04 Thread Markus Frank
ebUI and section config * PVE::QemuServer::Virtiofs dependency removed in QemuServer/Memory.pm * Minor changes to function/variable names * Disable snapshots (with RAM) and hibernate due to incompatibility cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluste

[pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian

[pve-devel] [PATCH pve-docs] amd-sev: add SEV-SNP infos and improve documentation

2025-04-04 Thread Markus Frank
add SEV-SNP limitations, example configuration and hyperlinks for more information Signed-off-by: Markus Frank --- qm.adoc | 51 +++ 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/qm.adoc b/qm.adoc index 2617a7c..3aa0406 100644

[pve-devel] [PATCH qemu-server v15 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-04-03 Thread Markus Frank
Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 81f0fad6

[pve-devel] [PATCH manager v15 08/12] api: add resource map api endpoints for directories

2025-04-03 Thread Markus Frank
Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308 ++ PVE

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-03 Thread Markus Frank
I forgot one v15 change. On 2025-04-03 12:34, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system

[pve-devel] [PATCH manager v15 10/12] ui: add resource mapping view for directories

2025-04-03 Thread Markus Frank
Signed-off-by: Markus Frank --- v15: * removed announce-submounts www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 38 +++ 3 files changed, 49 insertions(+) create mode 100644 www/manager6/dc

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-03 Thread Markus Frank
pm * Minor changes to function/variable names * Disable snapshots (with RAM) and hibernate due to incompatibility cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) guest-common: Marku

[pve-devel] [PATCH qemu-server v15 5/7] fix #1027: virtio-fs support

2025-04-03 Thread Markus Frank
E: https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/README.md Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- v15: * removed announce-submounts option altogether and always set it for virtiofsd * added die if both memory hotplug and virtiofs are enabled *

[pve-devel] [PATCH manager v15 09/12] ui: add edit window for dir mappings

2025-04-03 Thread Markus Frank
Signed-off-by: Markus Frank --- v15: * removed announce-submounts www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 202 ++ 2 files changed, 203 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www

[pve-devel] [PATCH cluster v15 1/12] add mapping/dir.cfg for resource mapping

2025-04-03 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank

[pve-devel] [PATCH guest-common v15 2/12] add dir mapping section config

2025-04-03 Thread Markus Frank
Adds a config file for directories by using a 'map' property string for each node mapping. example config: ``` some-dir-id map node=node1,path=/path/to/share/ map node=node2,path=/different/location/ ``` Signed-off-by: Markus Frank --- v15: * removed announce-submou

[pve-devel] [PATCH manager v15 12/12] ui: add options to add virtio-fs to qemu config

2025-04-03 Thread Markus Frank
Signed-off-by: Markus Frank --- v15: * moved all options except dirid to an advanced tab * improved field labels www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 www/manager6/qemu/VirtiofsEdit.js | 138

[pve-devel] [PATCH docs v15 3/12] add doc section for the shared filesystem virtio-fs

2025-04-03 Thread Markus Frank
Signed-off-by: Markus Frank --- v15: * added fstab entry example in the docs * added hyperlinks for websites * removed announce-submounts part qm.adoc | 102 ++-- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/qm.adoc b

[pve-devel] [PATCH manager v15 11/12] ui: form: add selector for directory mappings

2025-04-03 Thread Markus Frank
Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions

Re: [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

2025-04-02 Thread Markus Frank
Thanks for the feedback. On 2025-04-02 15:14, Fabian Grünbichler wrote: On March 4, 2025 12:57 pm, Markus Frank wrote: Adds a config file for directories by using a 'map' property string for each node mapping. Next to node & path, there is the optional announce-submounts p

Re: [pve-devel] [PATCH pve-manager v5 4/4] Add configuration options for AMD SEV-SNP

2025-04-02 Thread Markus Frank
SEV-SNP. Signed-off-by: Philipp Giersfeld Tested-by: Markus Frank Reviewed-by: Markus Frank --- changes since v4: https://lists.proxmox.com/pipermail/pve-devel/2025-March/069033.html * fix bugs related to SMT option www/manager6/qemu/Options.js | 1 + www/manager6/qemu/SevEdit.js

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs

2025-03-18 Thread Markus Frank
ping On 2025-03-04 12:57, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system protocol. build

Re: [pve-devel] [PATCH qemu-server v4 3/4] config: add AMD SEV-SNP support.

2025-03-18 Thread Markus Frank
verified that the kernel actually used the respective feature. Signed-off-by: Philipp Giersfeld Reviewed-by: Daniel Kral Tested-by: Markus Frank I have not tested this version before (there have been some changes since v3/v2). But now I have. So the "Tested-by" can stay there. ---

Re: [pve-devel] [PATCH edk2-firmware v4 1/4] Add OVMF targets for AMD SEV-ES and SEV-SNP

2025-03-18 Thread Markus Frank
that builds OVMF firmware suitable for AMD SEV. [1] https://www.qemu.org/docs/master/system/i386/amd-memory-encryption. [2] https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/specifications/56421.pdf Signed-off-by: Philipp Giersfeld Tested-by: Markus Frank I have not tested

Re: [pve-devel] [PATCH pve-manager v4 4/4] Add configuration options for AMD SEV-SNP

2025-03-17 Thread Markus Frank
Hello, I noticed that currently I cannot disable 'allow-smt' in the WebUI. The default value for allow-smt in qemu-server is '1'. So setting it to 1 or no value in the WebUI results in allow-smt always being enabled. To fix this, you can explicitly set allow-smt to 0 when the checkbox is not ch

[pve-devel] [PATCH storage v3 1/4] add standard option for VM disk formats in file-based storages

2025-03-15 Thread Markus Frank
Signed-off-by: Markus Frank --- v3: * removed 'optional => 1' * changed description src/PVE/Storage/Plugin.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 65cf43f..c15dc44 100644 --- a/src/PVE/Storage/Plugin

[pve-devel] [PATCH qemu-server v3 2/4] fix 4888: qmrestore: add disk-format option

2025-03-07 Thread Markus Frank
Add an option to choose a file format (qcow2, raw, vmdk) when restoring a vm backup to file based storage. This options allows all disks to be recreated with the specified file format if supported by the target storage. Signed-off-by: Markus Frank --- v3: * added requires => 'archive&

[pve-devel] [PATCH storage/qemu-server/manager v3 0/4] restore with a specified file format

2025-03-07 Thread Markus Frank
: * renamed diskformat to disk-format * added storage patch to a new standard option that only allows raw, qcow2 and vmdk storage: Markus Frank (1): add standard option for VM disk formats in file-based storages src/PVE/Storage/Plugin.pm | 6 ++ 1 file changed, 6 insertions(+) qemu-server

[pve-devel] [PATCH manager v3 3/4] ui: add hideFormatWhenStorageEmpty option to DiskStorageSelector

2025-03-07 Thread Markus Frank
Prerequisite for "ui: restore window: add diskformat option" The hide condition is copied from the format selector item in the same file. Signed-off-by: Markus Frank --- v3: * added (me.hideFormatWhenStorageEmpty && !me.autoSelect) to the hide condition in initComponent i

[pve-devel] [PATCH manager v3 4/4] ui: restore window: add disk-format option

2025-03-07 Thread Markus Frank
confuse users. Signed-off-by: Markus Frank --- v3: * added (me.hideFormatWhenStorageEmpty && !me.autoSelect) to the hide condition in the previous patch (3/4) instead of manually hiding it here. www/manager6/window/Restore.js | 14 +- 1 file changed, 9 insertions(+), 5 d

[pve-devel] [PATCH qemu-server v14 6/12] migration: check_local_resources for virtiofs

2025-03-04 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed PVE/QemuServer.pm

[pve-devel] [PATCH manager v14 12/12] ui: add options to add virtio-fs to qemu config

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * disable expose-xattr when expose-acl is set * added missing writeback cache option www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 137

[pve-devel] [PATCH docs v14 3/12] add doc section for the shared filesystem virtio-fs

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * addressed formulation nits * added paragraph about expose-acl & expose-xattr qm.adoc | 99 +++-- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..86b

[pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * return HTML encoded comment www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 42 +++ 3 files changed, 53 insertions(+) create mode 100644 www/manager6/dc

[pve-devel] [PATCH qemu-server v14 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 648b28cd..5caef7ba 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

[pve-devel] [PATCH manager v14 08/12] api: add resource map api endpoints for directories

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * added missing imports/uses * addressed style nits and improved formatting PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308 ++ PVE/API2/Cluster/Mapping/Makefile | 1

[pve-devel] [PATCH qemu-server v14 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: * nothing changed debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 81f0fad6..eda357a5 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus

[pve-devel] [PATCH qemu-server v14 5/12] fix #1027: virtio-fs support

2025-03-04 Thread Markus Frank
E: https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/README.md Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- v14: * use max_virtiofs() in check_vm_create_dir_perm * addressed style nits and improved formatting * added missing imports/uses * assert_virtiofs_co

[pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

2025-03-04 Thread Markus Frank
may be created because inode IDs are only unique on a single filesystem. example config: ``` some-dir-id map node=node1,path=/mnt/share/,announce-submounts=1 map node=node2,path=/mnt/share/, ``` Signed-off-by: Markus Frank --- v14: * disallow commas and equal signs in path until t

[pve-devel] [PATCH manager v14 09/12] ui: add edit window for dir mappings

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * disallow commas and equal signs in path until the path can be quoted in property strings www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 214 ++ 2 files changed, 215 insertions(+) create mode

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs

2025-03-04 Thread Markus Frank
changes to function/variable names * Disable snapshots (with RAM) and hibernate due to incompatibility cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) guest-common: Markus Frank (1):

[pve-devel] [PATCH manager v14 11/12] ui: form: add selector for directory mappings

2025-03-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v14: * nothing changed www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6

[pve-devel] [PATCH cluster v14 1/12] add mapping/dir.cfg for resource mapping

2025-03-04 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- v14: nothing changed src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed

Re: [pve-devel] [PATCH pve-manager v2 1/1] Add configuration options for AMD SEV-SNP

2025-02-18 Thread Markus Frank
Thank you for your effort to make amd sev snp support possible. For this patch I have some comments inline below. For the rest of the patch series, it is still working fine. If the qemu-server and edk2-firmware patches do not change, you can add this there: Tested-by: Markus Frank On 2025

Re: [pve-devel] [PATCH edk2-firmware/qemu-server/manager 0/4] AMD SEV-SNP

2025-02-13 Thread Markus Frank
Thanks. I have tested AMD SEV SNP and it works fine with your patch series. Tested-by: Markus Frank One thing I noticed: I would add a note in the WebUI that you need kernel >= 6.11 installed on the pve host to enable SEV-SNP as long as >=6.11 is not the default kernel. On 2025-02-07

[pve-devel] [PATCH qemu-server v2 2/4] fix 4888: qmrestore: add disk-format option

2025-02-12 Thread Markus Frank
Add an option to choose a file format (qcow2, raw, vmdk) when restoring a vm backup to file based storage. This options allows all disks to be recreated with the specified file format if supported by the target storage. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 6 ++ PVE/CLI

[pve-devel] [PATCH storage v2 1/4] add standard option for VM disk formats in file-based storages

2025-02-12 Thread Markus Frank
Signed-off-by: Markus Frank --- src/PVE/Storage/Plugin.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 65cf43f..9f21f0b 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -354,6 +354,13 @@ sub

[pve-devel] [PATCH storage/qemu-server/manager v2 0/4] Restore with a specified file format

2025-02-12 Thread Markus Frank
* added storage patch to a new standard option that only allows raw, qcow2 and vmdk storage: Markus Frank (1): add standard option for VM disk formats in file-based storages src/PVE/Storage/Plugin.pm | 7 +++ 1 file changed, 7 insertions(+) qemu-server: Markus Frank (1): fix 4888

[pve-devel] [PATCH manager v2 4/4] ui: window: add disk-format option to the restore window

2025-02-12 Thread Markus Frank
confuse users. Signed-off-by: Markus Frank --- www/manager6/window/Restore.js | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 6efe1313..9600cdab 100644 --- a/www/manager6/window/Restore.js

[pve-devel] [PATCH manager v2 3/4] ui: form: add hideFormatWhenStorageEmpty option to DiskStorageSelector

2025-02-12 Thread Markus Frank
Prerequisite for "ui: window: add diskformat option to restore window" The hide condition is copied from the format selector item in the same file. Signed-off-by: Markus Frank --- www/manager6/form/DiskStorageSelector.js | 9 + 1 file changed, 9 insertions(+) diff --git a/ww

Re: [pve-devel] [PATCH qemu-server v1 1/3] fix #4888: qmrestore: add diskformat option

2025-02-04 Thread Markus Frank
On 2025-02-04 17:39, Fiona Ebner wrote: Am 04.02.25 um 17:21 schrieb Fiona Ebner: Am 04.02.25 um 17:13 schrieb Markus Frank: Add an option to choose a file format (qcow2, raw, vmdk) when restoring a vm backup to file based storage. This options allows all disks to be recreated with the

[pve-devel] [PATCH qemu-server v1 1/3] fix #4888: qmrestore: add diskformat option

2025-02-04 Thread Markus Frank
Add an option to choose a file format (qcow2, raw, vmdk) when restoring a vm backup to file based storage. This options allows all disks to be recreated with the specified file format if supported by the target storage. Signed-off-by: Markus Frank --- Choosing the file format and storage for

[pve-devel] [PATCH manager v1 3/3] ui: window: add diskformat option to the restore window

2025-02-04 Thread Markus Frank
: Markus Frank --- www/manager6/window/Restore.js | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 6efe1313..393a6b28 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window

[pve-devel] [PATCH manager v1 2/3] ui: form: add hideFormatWhenStorageEmpty option to DiskStorageSelector

2025-02-04 Thread Markus Frank
Prerequisite for "ui: window: add diskformat option to restore window by changing to DiskStorageSelector" The hide condition is copied from the format selector item in the same file. Signed-off-by: Markus Frank --- www/manager6/form/DiskStorageSelector.js | 9 + 1 file

[pve-devel] [PATCH manager v1 1/2] ui: qemu: add vnc clipboard hint for migration

2025-01-27 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 9 + 1 file changed, 9 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 7acc25d6..8d8f1e00 100644 --- a/www/manager6/qemu/DisplayEdit.js +++ b/www/manager6/qemu

[pve-devel] [PATCH manager v1 2/2] ui: qemu: fix the capitalisation of the word clipboard in DisplayEdit

2025-01-27 Thread Markus Frank
Fixes: 80da5bb97dbd6a03173365f98c796d96c94f5e85 Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 8d8f1e00..c8a67017 100644 --- a/www

[pve-devel] [PATCH docs v13 3/12] add doc section for the shared filesystem virtio-fs

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 92 +++-- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..5ad79c1 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1202,6 +1202,93 @@ recommended to always use a

[pve-devel] [PATCH manager v13 09/12] ui: add edit window for dir mappings

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 208 ++ 2 files changed, 209 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH manager v13 11/12] ui: form: add selector for directory mappings

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v13 0/12] virtiofs

2025-01-22 Thread Markus Frank
(with RAM) and hibernate due to incompatibility cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) guest-common: Markus Frank (1): add dir mapping section config src/Makefile

[pve-devel] [PATCH qemu-server v13 5/12] fix #1027: virtio-fs support

2025-01-22 Thread Markus Frank
E: https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/README.md Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 40 ++- PVE/QemuServer.pm | 22 +++- PVE/QemuServer/Makefile| 3 +- PVE/QemuServer/Memory.pm | 23 +

[pve-devel] [PATCH manager v13 08/12] api: add resource map api endpoints for directories

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 307 ++ PVE/API2/Cluster/Mapping/Makefile | 1 + 3 files changed, 315 insertions(+) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm diff --git a/PVE

[pve-devel] [PATCH manager v13 12/12] ui: add options to add virtio-fs to qemu config

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 123 ++ 4 files changed, 144 insertions(+) create mode 100644 www

[pve-devel] [PATCH qemu-server v13 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b89a7e71..00178575 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2460,8 +2460,9 @@ sub

  1   2   3   4   5   >