On 3/6/25 12:08, lou.lecriv...@orange.fr wrote:
[...]
+sub verify_api {
+my ($class, $plugin_config) = @_;
+
+my $url = $plugin_config->{url};
+my $namespace = $plugin_config->{namespace};
+my $headers = default_headers($plugin_config);
+
+# check that the namespace exists
In general the plugin implementation seems sensible, the only thing I
didn't quite understand is the need for `get_status_ip`, more on that
inline.
The series no longer applies to master, as there have been patches that
add a fingerprint parameter to the API request [0].
For testing purposes I
sorry my mistake, it looked to me as if the mail did not go to the
mailing list, but it did.
On 3/6/25 12:08, lou.lecriv...@orange.fr wrote:
From: Lou Lecrivain
Following review from Hannes,
I have made some improvements to the form of the code for the pve-network part.
No functional changes
the
patches (I may have forgot to signoff).
Noted for the Co-developed-by.
Would it be OK for you to edit that in or do I have to resend the patch series?
MfG
________
De : Hannes Dürr
Envoyé : jeudi 6 mars 2025 13:13
À : lou.lecriv...@orange.fr ; pve-devel@li
ed in whole or in part by
yourself and you have the right to submit it under our open source license.
jonathan crystall can use the "Co-developed-by: Jonatan Crystall
" to make it clear that he contributed the code.
Best wishes,
Hannes Dürr
On 3/6/25 12:08, lou.lecriv...@orange.fr wrot
On 1/8/25 13:15, Lou Lecrivain wrote:
add support for subnet allocation without ranges,
where it was previously not supported.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 68 +
1 file changed, 68 insertions(+)
diff --git a/src/PVE/Net
On 1/8/25 13:15, Lou Lecrivain wrote:
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 60 -
1 file changed, 58 insertions(+), 2 deletions(-)
diff --git a/
On 1/8/25 13:15, Lou Lecrivain wrote:
added error handling in helpers
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 126 ++--
1 file changed, 113 insertions(+), 13 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src
Sorry it took me so long to reply.
* Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.
* All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series
How did you test the patch, apart from th
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
added error handling in helpers Signed-off-by: lou lecrivain
--- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
| 126 ++-- 1 file changed, 113 insertions(+), 13
deletions(-) diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugi
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion. Signed-off-by: lou lecrivain
--- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
| 60 - 1 file changed, 58 insertions(+), 2
deletions(-) dif
On 1/8/25 13:15, Lou Lecrivain wrote:
add support for subnet allocation without ranges,
where it was previously not supported.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 68 +
1 file changed, 68 insertions(+)
diff --git a/src/PVE/Net
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
add support for subnet allocation without ranges, where it was
previously not supported. Signed-off-by: lou lecrivain
--- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
| 68 + 1 file changed, 68 insertions(+) diff --git
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion. Signed-off-by: lou lecrivain
--- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
| 60 - 1 file changed, 58 insertions(+), 2
deletions(-)
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
+use base('PVE::Network::SDN::Ipams::NetboxPlugin'); why do you base the Plugin in NetboxPlugin at the beginning?> +sub
get_ips_from_mac { > + my ($class, $plugin_config, $mac, $zoneid) = @_;
$zoneid is unused in the function, this looks like
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
added error handling in helpers Signed-off-by: lou lecrivain
--- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
| 126 ++-- 1 file changed, 113 insertions(+), 13
deletions(-) diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugi
Good point, that will certainly help one or the other.
If nobody has anything against it, I would add it to V5.
On 2/12/25 14:38, Dominik Csapak wrote:
One super tiny nit (that's IMHO almost bike-shed territory) but
otherwise LGTM:
Maybe we want to print a short log line before blacklisting th
sorry for the noise, forgot to increment the version number, will resend
the series
On 2/10/25 13:25, Hannes Duerr wrote:
Changes in v4:
in commits
Changes in v3:
* install headers for every installed kernel version by default
* additionally add patch to only install headers for running kernel
forgot to increment version, sorry for the noise.
New version is can be found here [0]
[0]
https://lore.proxmox.com/pve-devel/20250124144121.215130-1-h.du...@proxmox.com/T/#u
On 1/24/25 15:37, Hannes Duerr wrote:
Changes in v3:
* install headers for every installed kernel version by default
*
Tested this:
* enable nftables firewall
* create a security group
* insert the security group to host firewall with interface vmbr0
* enable vm firewall
* insert the security group to vm firewall with interface net0
* check for errors with journalctl -f
no more errors occur, please consider this
this doesn't apply anymore on master
On 1/23/25 11:12, Stefan Hanreich wrote:
Nothing in this workspace directly depends on it, so any library using
this would have to pull it in themselves.
Signed-off-by: Stefan Hanreich
---
debian/control | 1 -
1 file changed, 1 deletion(-)
diff --git a
On 1/22/25 17:04, Thomas Lamprecht wrote:
Am 22.01.25 um 16:23 schrieb Hannes Dürr:
On 1/21/25 17:12, Hannes Dürr wrote:
On 1/21/25 16:36, Thomas Lamprecht wrote:
Am 21.01.25 um 11:47 schrieb Dominik Csapak:
It's probably not a bad idea to install the packages for all
installed k
On 1/21/25 17:12, Hannes Dürr wrote:
On 1/21/25 16:36, Thomas Lamprecht wrote:
Am 21.01.25 um 11:47 schrieb Dominik Csapak:
It's probably not a bad idea to install the packages for all
installed kernel versions? (@Thomas ?)
Yeah, would be definitively a nice UX enhancement.
sounds go
On 1/21/25 16:36, Thomas Lamprecht wrote:
Am 21.01.25 um 11:47 schrieb Dominik Csapak:
It's probably not a bad idea to install the packages for all installed kernel
versions? (@Thomas ?)
Yeah, would be definitively a nice UX enhancement.
sounds good to me, will do.
Not super sure about how
On 1/21/25 11:36, Dominik Csapak wrote:
mhmm not sure if it's so good to reuse the exiting name of the nvidia
service
for this. also not sure how systemd likes it if there is a service
'foo.service'
and a template 'foo@.service' (though my guess would be that it's not
that big of an issue)
i
Do I understand you correctly that the feature is not yet ready to be
removed from the technology preview?
On 12/13/24 15:49, Fiona Ebner wrote:
Am 13.12.24 um 15:32 schrieb Hannes Duerr:
The static load scheduler feature was applied on 17/11/2022 [0] and can
be considered stable now
The tim
i'd prefer some error message telling me that it was not
possible to remove the Subnet or IP (currently the same behavior)
instead of just not deleting it.
MfG
--
Lou Lecrivain
WDZ GmbH
____
De : Hannes Dürr
Envoyé : mardi 10 décembre 2024 10:32
À : Proxmox
Thanks for contributing and sending the patch series, we really
appreciate it!
At first glance it looks quite good, I have a few suggestions for changes:
* The plugin is based on the Netbox plugin, I would suggest changing it
to the base plugin. I know Nautobot is a fork of Netbox, but thi
Hi Alexandre,
i don't know if a colleague has already replied to you, if not:
As far as I know, no colleague went to the cephalocon this year.
LG
Hannes Dürr
On 12/4/24 12:31, Alexandre Derumier via pve-devel wrote:
___
pve-devel mailing lis
On 12/2/24 09:47, Dominik Csapak wrote:
high level comments first:
* the script is actually not installed with the package, because it's not
installed anywhere and not in any .install file
(you'd either have to use an 'install' target in the makefile to
install it to some folder
or use a .in
On 12/2/24 09:36, Dominik Csapak wrote:
i think that's in reverse? we don't need pve-manager here AFAICT,
but if we want a dependency somewhere, we'd want to add this package
as a dependency of pve-manager, no?
from the current state of this package I don't see a reason to depend
on any pve/p
I like your changes, but I would adapt the description more to the
bridge manpage [0].
[0] https://www.man7.org/linux/man-pages/man8/bridge.8.html
On 11/18/24 19:52, Stoiko Ivanov wrote:
On Tue, 12 Nov 2024 16:54:25 +0100
Stefan Hanreich wrote:
Signed-off-by: Stefan Hanreich
---
pvesdn.a
On 11/19/24 11:19, Stoiko Ivanov wrote:
On Tue, 19 Nov 2024 11:06:12 +0100
Hannes Dürr wrote:
I like your changes, but I would adapt the description more to the
bridge manpage [0].
[0] https://www.man7.org/linux/man-pages/man8/bridge.8.html
On 11/18/24 19:52, Stoiko Ivanov wrote:
On Tue
On 10/10/24 17:56, Stefan Hanreich wrote:
Additionally add information about the SDN VNet firewall, which has
been introduced with this changes.
Signed-off-by: Stefan Hanreich
---
Makefile | 1 +
gen-pve-firewall-vnet-opts.pl | 12
pve-firewall-vnet-opts.adoc
As we talked off-list, it is still possible to create Rules on the
forward chain which Reject traffic on cluster, host and bridge level
which should not be possible
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-
On 10/10/24 17:56, Stefan Hanreich wrote:
Signed-off-by: Stefan Hanreich
---
src/PVE/Firewall.pm | 122 ++--
src/PVE/Firewall/Helpers.pm | 12
2 files changed, 128 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewa
On 4/10/24 11:34, Thomas Lamprecht wrote:
This is not bug #5365 [0] (which is about a ceph device class UX improvement)
but #5363 [0].
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5365
[1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5363
Good catch, thank you !
I mostly noticed becaus
On 1/30/24 11:00, Fabian Grünbichler wrote:
On December 19, 2023 3:03 pm, Hannes Duerr wrote:
for base images we call the volume_import of the parent plugin and pass
it as vm-image instead of base-image, then convert it back as base-image
Signed-off-by: Hannes Duerr
---
src/PVE/Storage/LvmT
On 3/6/24 15:04, Fiona Ebner wrote:
Yes, but the question is what is worse: Needing to re-do the clone or
having the VM config on the wrong node?
To avoid that, I'd lean towards keeping the behavior of failing the task
if deactivating $newvollist fails. After all, at least in case of LVM
not
Tested the patch by
1.
* creating a role with
'Datastore.Audit,Datastore.AllocateTemplate,Sys.AccessNetwork'
* creating a user with permission for specific {storage} and {node}
* downloading the iso via gui
2.
* creating a role with 'Datastore.AllocateTemplate,Sys.AccessNetwork'
* creatin
I don't think this is an improvement of the wording, liked the previous
version more.
Are there people who have not understood the wording?
On 1/16/24 14:11, Alexander Zeidler wrote:
Signed-off-by: Alexander Zeidler
---
qm.adoc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -
On 1/16/24 11:34, Thomas Lamprecht wrote:
Am 15/01/2024 um 16:53 schrieb Hannes Dürr:
Tested cluster creation with three new nodes on 8.1 and the patches
Cluster creation and further ssh communication (eq. migration) worked
flawless
Tested-by: Hannes Duerr
What about the reinstallation of
Tested cluster creation with three new nodes on 8.1 and the patches
Cluster creation and further ssh communication (eq. migration) worked
flawless
Tested-by: Hannes Duerr
On 1/11/24 11:51, Fabian Grünbichler wrote:
this series replaces the old mechanism that used a cluster-wide merged known
I live-migrated 300 vms with:
migration: insecure
max_workers: 30
and 10 parallel workers
(as described here
https://forum.proxmox.com/threads/live-migration.127355/#post-557181)
Had zero issues with the patch applied,
without the patch i had ~30 errors
Tested-by: Hannes Duerr
On 12/20/23 13
On 12/14/23 15:23, Fiona Ebner wrote:
create_base() will tell you the actual name, you should not override it
with the old one. We expect it to match, but then there's no need for
the assignment. If it doesn't match, you'd be returning something wrong.
Or what am I missing?
If i am not mistaken
Tested-by: Hannes Duerr
On 11/22/23 13:28, Stefan Hanreich wrote:
This is needed so dhcp-ranges are properly displayed as changed in the
web UI.
Also took the chance to properly indent the encode_value function with
our indentation scheme.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network
Tested-by: Hannes Duerr
On 11/28/23 09:58, Stefan Hanreich wrote:
When SDN is configured with the same subnet in two different VNets the
IPAM tree would render them wrongly.
Reported-By: Hannes Duerr
Signed-off-by: Stefan Hanreich
---
www/manager6/tree/DhcpTree.js | 10 +++---
1 file
New Version can be found here:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060429.html
On 11/17/23 12:53, Hannes Duerr wrote:
adds vendor and product information for SCSI devices to the json schema and
checks in the VM create/update API call if it is possible to add these to QEMU
On 11/3/23 11:39, Fiona Ebner wrote:
[...]
This essentially duplicates most of the same function in the parent
plugin, i.e. LVMPlugin. What you can do to avoid it, is introduce new
helper functions for the parts that are different, call those in
LVMPlugin's implementation and overwrite the help
On 11/8/23 11:04, Fiona Ebner wrote:
Am 08.11.23 um 09:51 schrieb Hannes Duerr:
adds vendor and product information for SCSI devices to the json schema and
checks in the VM create/update API call if it is possible to add these to QEMU
as a device option
Signed-off-by: Hannes Duerr
---
chang
50 matches
Mail list logo
