gt;
> Fixes: 530b0a71 ("fix #4053: don't run vzdump jobs when they change from
> disabled->enabled")
>
> Signed-off-by: Dominik Csapak
Looks good to me:
Reviewed-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Instead, rely on PBSClient to set namespace according to the initial
configuration.
Signed-off-by: Fabian Ebner
---
Dependency bump for new libpve-common-perl needed.
src/PMG/API2/PBS/Job.pm | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/src/PMG/API2
Instead, rely on PBSClient to set namespace according to the initial
configuration.
Signed-off-by: Fabian Ebner
---
Dependency bump for new libpve-common-perl needed.
PVE/API2/Storage/FileRestore.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Storage
space!
In other words, this implicitly fixes the restore_pxar() call in PMG
and avoids the need to extract the namespace from the configuration
(which already is present in the client) on the call site for all
functions that currently take a namespaced parameter.
Signed-off-by: Fabian Ebner
---
Otherwise, there will be
Result: {
"data": null
}
when calling via a CLI tool for example. This also makes it consistent
with PVE in preparation to switch to using PBSClient there.
Signed-off-by: Fabian Ebner
---
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+),
or new pve-common is needed for pve-storage and
pmg-api.
pve-common:
Fabian Ebner (5):
pbs client: delete password: return success for non-existent file
pbs client: forget snapshot: suppress output
pbs client: default to configured namespace for non-namespaced
parameters
pbs client: de
instead of assuming that the requested ID is the same as the node in
the API path. This endpoint is not currently used in the UI AFAICS.
Signed-off-by: Fabian Ebner
---
src/PMG/API2/PBS/Job.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG
could be added, or the relevant functions
could take an additional parameter, either for just the namespace or
like $cmd_opts in restore_pxar().
Signed-off-by: Fabian Ebner
---
src/PVE/PBSClient.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
Instead, use the one from the initial configuration. The only current
caller is in PMG and the namespace parameter set there agrees with
the one from the initial configuration, so this is not actually a
breaking change.
Signed-off-by: Fabian Ebner
---
src/PVE/PBSClient.pm | 4 ++--
1 file
It's currently possible to add a remote in PMG without password (via
API), but deletion of such a remote would fail here.
Signed-off-by: Fabian Ebner
---
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
For the io_uring patch, it's not very clear which configurations can
trigger it, but it should be rather uncommon. See qemu commit
be6a166fde652589761cf70471bcde623e9bd72a for a bit more information.
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Cherry-pick io_uring patch inste
e user actively changed
the node to scan?
> grüße Stefan
>
>
> On 6/28/22 12:33, Fabian Ebner wrote:
>> Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
>>> This adds a dropdown box for iSCSI, LVM, LVMThin & ZFS storage
>>> options where a
>>> cluster n
Before af07f67 ("pbs: use vmid parameter in list_snapshots") the
namespace was set via do_raw_client_command, but now it needs to be
set explicitly here.
Fixes: af07f67 ("pbs: use vmid parameter in list_snapshots")
Signed-off-by: Fabian Ebner
---
PVE/Storage/PBSPlugin.pm |
Am 15.07.22 um 11:01 schrieb Dominik Csapak> On 7/15/22 10:51, Fabian
Ebner wrote:
>>
>>> so that we don't read the file multiple times each round.
>>>
Could add
Fixes: 530b0a71 ("fix #4053: don't run vzdump jobs when they change from
disabled->e
In the subject, I wouldn't call the nodes "unrelated". How about "after
updating job from a different node"?
Am 14.07.22 um 09:42 schrieb Dominik Csapak:
> since the jobs are configured clusterwide in pmxcfs, a user can use any
> node to update the config of them. for some configs (schedule/enable
Am 14.07.22 um 13:13 schrieb Dominik Csapak:> On 7/13/22 12:47, Aaron
Lauterer wrote:
>> + my $poollist = { map { $_->{name} => 1 } @{$pools} };
>
> does that really make sense here? would it not be easier to just
> iterate? e.g.
>
>
> for my $pool (@$pools) {
> die "..." if $pool->{n
Am 02.06.22 um 09:42 schrieb Dominik Csapak:
> by updating the timestamp in the job state when enabled is changing
> from 0 -> 1. We do it this way too in PBS for example, and is the more
> sensible behaviour.
>
> Signed-off-by: Dominik Csapak
We've got a problem here. The state file is per-node
while introducing a 'product' parameter to the relevant functions and
adding wrappers for backwards-compatibility.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Fabian Ebner
---
Changes from v2:
* Turn Rust side into wrappers rahter than adding Perl wrappers.
* Avoid mo
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
No changes from v2.
PVE/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 9cf02e45..fbcd171b 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
No changes from v2.
src/PMG/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/PMG/API2/APT.pm b/src/PMG/API2/APT.pm
index 18bb992..d6f050f 100644
--- a/src/PMG/API2/APT.pm
+++ b/src
while introducing a 'product' parameter to the relevant functions and
adding wrappers for backwards-compatibility.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Add wrappers, so we can defer the Breaks to later.
* Drop unnecessary changes
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
No changes from v1.
(build-)dependency bumps for libproxmox-perl-rs needed.
src/PMG/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/PMG/API2/APT.pm b/src/PMG/API2/APT.pm
index
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
No changes from v1.
(build-)dependency bumps for libproxmox-perl-rs needed.
PVE/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 9cf02e45
Am 06.07.22 um 13:13 schrieb Wolfgang Bumiller:
> On Wed, Jul 06, 2022 at 10:54:17AM +0200, Fabian Ebner wrote:
>> while introducing a 'product' parameter to the relevant functions.
>>
>> Suggested-by: Wolfgang Bumiller
>> Signed-off-by: Fabian Ebner
>>
while introducing a 'product' parameter to the relevant functions.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Fabian Ebner
---
I did the changes in Proxmox/Lib/Common.pm (and Makefile) manually.
Is that the intended way or could I have generated those somehow?
Hope I got these r
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
src/PMG/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/PMG/API2/APT.pm b/src/PMG/API2/APT.pm
index 18bb992..d6f050f 100644
--- a/src/PMG/API2/APT.pm
+++ b/src/PMG/API2/APT.pm
which is shared between PVE and PMG.
Signed-off-by: Fabian Ebner
---
PVE/API2/APT.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 9cf02e45..fbcd171b 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -10,6 +10,8 @@ use
mox.com/threads/111760/#post-482045
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Text for gettext() is required to be on the same line.
www/manager6/window/Restore.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Restore.js b/www/
Am 05.07.22 um 10:08 schrieb Fabian Ebner:
> It's not clear to users that the "VM data" includes mount point
> volumes, including those that are not marked for backup. This is
> different from VM restore, where volumes attached at drives not
> present in the backup wi
mox.com/threads/111760/#post-482045
Signed-off-by: Fabian Ebner
---
www/manager6/window/Restore.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 6738d26f..be2efa3b 100644
--- a/www/manager6/window/R
Am 06.05.22 um 12:11 schrieb Fabian Ebner:
> This will break possibly existing workflows like
> 1. add second cloud-init
> 2. remove first cloud-init
> to change the cloud-init storage.
>
> On the other hand, it avoids unintended misconfiguration of having
> mutliple c
Am 01.07.22 um 13:53 schrieb Thomas Lamprecht:
> How likely is this to trigger? Did you came across such events or is this a
> backport
> for the sake of being cautious?
>
> Mostly asking because 7.0 is already on staging, so it'd be good to know if
> we should
> add another 6.0 release between
Signed-off-by: Fabian Ebner
---
...20-io_uring-fix-short-read-slow-path.patch | 47 +++
debian/patches/series | 1 +
2 files changed, 48 insertions(+)
create mode 100644
debian/patches/extra/0020-io_uring-fix-short-read-slow-path.patch
diff --git a
Am 29.06.22 um 11:34 schrieb Thomas Lamprecht:
> this and "qemu-server: remove json schema pve-targetstorage (moved to
> pve-common)"
> seems rather unrelated from the firewall series.
>
> Besides that I welcome splitting the Firewall.pm monster module up.
>
> For the record: the firewall part o
Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
> replace all "var" with "let" in files related to patch for ticket 2822
>
> Signed-off-by: Stefan Hrdlicka
While this patch can be fine, I think the next one is a bit too big ;)
It might introduce subtle bugs (since we might be relying on the
semant
Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
> This adds a dropdown box for iSCSI, LVM, LVMThin & ZFS storage options where a
> cluster node needs to be chosen. As default the current node is
> selected. It restricts the the storage to be only availabe on the
> selected node.
I don't think we sho
It's escaped in the API result and will be re-escaped upon submit,
leading to confusion as reported in the community forum:
https://forum.proxmox.com/threads/110747/post-480507
Fixes: 2a1f46ed ("ui: manual backup: also set notes-template default")
Signed-off-by: Fabian Ebner
--
coming in via qemu-stable (except for the vdmk fix, which was tagged
for-7.0 on the qemu-devel list, but didn't make it into the release).
Also took the chance to switch the gluster fix to the version that
made it into upstream.
Signed-off-by: Fabian Ebner
---
...rrectly-set-max_pdiscard-
Clean rebase and didn't run into any obvious issues when testing (I
did when testing the release candidates, but those issues got
addressed before the release :)). Still, more testing is always
appreciated!
Fabian Ebner (4):
update submodule and patches to 7.0.0
d/rules: drop out
Signed-off-by: Fabian Ebner
---
debian/rules | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/rules b/debian/rules
index 5e03193..6192fe7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -132,8 +132,8 @@ install: build
# remove Alpha files
rm
See QEMU commits 9e8be4c546ce8469ca9702715bf8f198d604b685 and
a5730b8bd3675f484ed0eacea052452048eeb35d for more information.
Signed-off-by: Fabian Ebner
---
debian/rules | 2 --
1 file changed, 2 deletions(-)
diff --git a/debian/rules b/debian/rules
index 6814f42..5e03193 100755
--- a/debian
Am 22.06.22 um 13:52 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> debian/control | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index af258db..eff8165 100644
> --- a/debian/control
> +++ b/debian/control
> @@
-driver.patch
Fabian Ebner (3):
vma: create: support 64KiB-unaligned input images
vma: create: avoid triggering assertion in error case
block: alloc-track: avoid premature break
block/alloc-track.c | 3 ++-
vma-writer.c| 2 ++
vma.c | 12 ++--
3 files changed, 14
might still be work to do. Additionally, ret is an int,
which on 64-bit platforms is too small to hold the size_t returned by
qemu_iovec_memset().
The branch seems to be difficult to reach in practice, because the
whole point of alloc-track is to be used with a backing device.
Signed-off-by: Fabian
the buffer still contains data from the previous
iteration.
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Add assert just to be sure.
vma.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/vma.c b/vma.c
index 21e765a469..6d02b29047 100644
--- a/vma.c
+
error_setg expects its argument to not be initialized yet.
Signed-off-by: Fabian Ebner
---
New in v2.
vma-writer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vma-writer.c b/vma-writer.c
index 11d8321ffd..29567cba68 100644
--- a/vma-writer.c
+++ b/vma-writer.c
@@ -310,6 +310,8
Am 20.06.22 um 12:44 schrieb Alexandre Derumier:
> Instead using vm pending options for pending cloudinit generated config,
>
> write current generated cloudinit config in a new [special:cloudinit] SECTION.
>
> Currently, some options like vm name, nic mac address can be hotplugged,
> so they are
Am 20.06.22 um 12:45 schrieb Alexandre Derumier:
> diff --git a/PVE/QemuServer/Cloudinit.pm b/PVE/QemuServer/Cloudinit.pm
> index cdaf4e5..2355953 100644
> --- a/PVE/QemuServer/Cloudinit.pm
> +++ b/PVE/QemuServer/Cloudinit.pm
> @@ -632,4 +633,81 @@ sub dump_cloudinit_config {
> }
> }
>
> +s
s generated.
> This is only an hint, to allow to display diff between the generated cloudinit
> drive, and the current vm config.
>
> A new specific cloudinit config api is added too displaying the diff between
> current and generated config.
>
Still found a few minor nits, but
Am 20.06.22 um 12:44 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuMigrate.pm| 10 +-
> PVE/QemuServer/Helpers.pm | 26 ++
> 2 files changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMi
Now that the import-from feature is available.
Signed-off-by: Fabian Ebner
---
qm.adoc | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/qm.adoc b/qm.adoc
index ba0ca20..4d0c7c4 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1377,23 +1377,13 @@ Suppose you created
Signed-off-by: Fabian Ebner
---
qm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index e666d7d..ba0ca20 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1381,7 +1381,7 @@ You can now create a new target VM for this image.
# qm create 600 --net0 virtio
Am 21.03.22 um 10:33 schrieb Daniel Tschlatscher:
> containers Stopping and starting a container that is already in the desired
> state will not return an error value on the CLI anymore. The same as VMs do,
> when they are stopped but not running.
>
> Signed-off-by: Daniel Tschlatscher
This a
e job state should not be touched and
even the first three mails upon migration could be considered spam.
Fixes: e6b8af20 ("replication: sent always mail for first three tries and move
helper")
Signed-off-by: Fabian Ebner
---
PVE/API2/Replication.pm | 4
1 file changed, 4 inse
Am 13.06.22 um 12:13 schrieb Oguz Bektas:
> storage_check_enabled() already dies with an appropriate error message
> so we don't have to handle it here
>
> Signed-off-by: Oguz Bektas
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox
jobs when changing from disabled to enabled,
> since that is not expected
>
> changes from v1:
> * rename 'skip-missed' to 'repeat-missed' and reverse the default
> * always update timestamp on disabled -> enabled
> * put the checkbox in advanced items
Am 02.06.22 um 09:42 schrieb Dominik Csapak:
> diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
> index 5d36789a..ced48977 100644
> --- a/PVE/API2/Backup.pm
> +++ b/PVE/API2/Backup.pm
> @@ -180,6 +180,13 @@ __PACKAGE__->register_method({
> description => "Enable or disable the job
because prepare() was changed in 8d1cd44 ("partially fix #3111:
replication: be less picky when selecting incremental base") to return
all local snapshots.
Signed-off-by: Fabian Ebner
---
New in v2.
src/PVE/Replication.pm | 19 ---
1 file changed, 8 insertions(+), 11
the volume could become completely
orphaned in case the relevant storage wasn't used by the job anymore.
Signed-off-by: Fabian Ebner
---
Dependency bump for libpve-guest-common >= 4.0-3 needed for
is_replication_snapshot().
Changes from v1:
* Adapt to changed behavior of prepare() so
while dropping the instance where the local variable was unused.
prepare() was changed a while ago to return all local snapshots.
Signed-off-by: Fabian Ebner
---
New in v2.
PVE/CLI/pvesr.pm | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI
would only rely on replication state
to get storages for full removal.
* Add safe-guard to only remove other replication snaphsots if the
last_sync snapshot is present.
manager:
Fabian Ebner (2):
pvesr: rename last_snapshots to local_snapshots
pvesr: prepare local job: remove
This prevents left-over volume(s) in the following situation:
1. replication with volumes on different storages A and B
2. remove all volumes on storage B from the guest configuration
3. schedule full removal before the next normal replication runs
Signed-off-by: Fabian Ebner
---
No changes
_sync=1 so chaning the behavior for other (non-zero) values should
be fine.
Signed-off-by: Fabian Ebner
---
New in v2.
src/PVE/Replication.pm | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index 33fcc48..8591
Commit 8d1cd44 ("partially fix #3111: replication: be less picky when
selecting incremental base") changed prepare() to return all local
snapshots.
Special behavior regarding last_sync is also better mentioned
explicitly.
Signed-off-by: Fabian Ebner
---
New in v2.
src/PVE/Replicat
Am 20.05.22 um 15:28 schrieb Daniel Tschlatscher:
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index 0a100b7..7e53189 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -21,6 +21,7 @@ use base qw(PVE::SectionConfig);
> use constant COMPRESSOR_RE => 'gz|lzo|zs
nfo object now returns one more field containing the name of
> the notes file. The test cases have to be adapted to expect this new
> value as the package will not compile otherwise.
>
> Signed-off-by: Daniel Tschlatscher
Only found small nits, so consider the series:
Reviewed
Am 20.05.22 um 15:28 schrieb Daniel Tschlatscher:
> Signed-off-by: Daniel Tschlatscher
Commit title shouldn't include "fix #3972"
> ---
> PVE/Storage.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index 6f2558f..98ecd60 100755
>
Am 20.05.22 um 15:28 schrieb Daniel Tschlatscher:
> This improves handling when two archive remove calls are creating a
> race condition where one would formerly encounter an error. Now both
> finish successfully.
>
> Signed-off-by: Daniel Tschlatscher
Commit title shouldn't include "fix #3972".
Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
> Existing installs are not changed by this.
>
> Signed-off-by: Matthias Heiserer
> ---
Reviewed-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.pro
Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
> Previously, only a plaintext line in the task log showed something was off.
> Now, the GUI will show it as a warning.
>
>
> Signed-off-by: Matthias Heiserer
Reviewed-by: Fabian Ebner
> diff --git a/PVE/QemuServer.pm b
Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
>
> Signed-off-by: Matthias Heiserer
Reviewed-by: Fabian Ebner
> ---
>
> Changes from v3:
> * remove
Am 28.03.22 um 11:53 schrieb Oguz Bektas:
> Signed-off-by: Oguz Bektas
> ---
> PVE/CLI/pveam.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm
> index 6c26f209..0ad33823 100644
> --- a/PVE/CLI/pveam.pm
> +++ b/PVE/CLI/pveam.pm
> @@ -122,6 +122,8 @@
mplete_stream (qemu-system-x86_64 +
> 0x75ab3d)
> #11 0x5641bce4e353 coroutine_trampoline (qemu-system-x86_64 + 0x815353)
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Fix commit message.
* Do di->job = NULL before releasing the context.
* Also keep context before job
Am 09.06.22 um 13:55 schrieb Fabian Ebner:
> Otherwise, we might not run into an abort via bdrv_co_yield_to_drain()
Sorry, the "not" should not be here.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cg
mplete_stream (qemu-system-x86_64 +
> 0x75ab3d)
> #11 0x5641bce4e353 coroutine_trampoline (qemu-system-x86_64 + 0x815353)
Signed-off-by: Fabian Ebner
---
...ensure-jobs-in-di_list-are-referenced.patch | 18 --
...id-segfault-issues-upon-backup-cancel.patch | 6 +++--
Am 16.05.22 um 18:07 schrieb Alexandre Derumier:
> Changelog v5:
>
> - move cloudinit fast_plug_option generation outside vmconfig_hotplug_pending
> - remove cloudinit section from vm_config api
> - vzdump : skip cloudinit section
> - migration: check target node version && forbid migration if to
Am 16.05.22 um 18:07 schrieb Alexandre Derumier:
> @@ -122,6 +123,13 @@ sub prepare {
> # test if VM exists
> my $conf = $self->{vmconf} = PVE::QemuConfig->load_config($vmid);
>
> +my $version = get_node_pvecfg_version($self->{node});
> +my $cloudinit_config = $conf->{cloudinit}
Am 16.05.22 um 18:07 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/API2/Qemu.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 1d5b66f..57a75fc 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -1227,
Am 24.05.22 um 16:45 schrieb Stefan Hrdlicka:
> This adds a dropdown box for LVM, LVMThin & ZFS storage options where a
> cluster node needs to be chosen. As default the current node is
> selected. It restricts the the storage to be only availabe on the
> selected node.
>
IMHO it's not immediatel
Am 24.05.22 um 16:45 schrieb Stefan Hrdlicka:
> this enables forwarding of request to the correct node if a node is set
>
> Signed-off-by: Stefan Hrdlicka
> ---
> PVE/API2/Storage/Config.pm | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Sto
te cannot be
> valid anyway since we just relocated the vm here (from a dead node).
>
> Signed-off-by: Dominik Csapak
> Reviewed-by: Fabian Grünbichler
Both patches:
Reviewed-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Ping
Am 04.03.22 um 14:09 schrieb Fabian Ebner:
> Because $mon->{addr} might come with a port attached (affects monitors
> created with PVE 5.4 as reported in the community forum [0]), or even
> be a hostname (according to the code in Ceph/Services.pm). Although
> the latter shoul
el, but the approach with
using the first non-completed job seemed more robust.
Signed-off-by: Fabian Ebner
---
Changes from v1:
* ref/unref is now done by the previous patch and wider in scope
making sure a job in the di_list is always referenced.
pve-backup.c | 61 +++
cancel QMP call (as happens in PVE when
the backup QMP command fails) would try to call proxmox_backup_abort()
and run into a segfault.
Signed-off-by: Fabian Ebner
---
All patches are intended to be ordered after
0038-PVE-Backup-Don-t-block-on-finishing-and-cleanup-crea.patch
or could also be squ
> job's refcount hits zero -> job is
freed
4. qmp_backup_cancel comes in and locks backup_state.backup_mutex
before pvebackup_co_complete_stream can remove the job from the
di_list
5. qmp_backup_cancel will pick a job that's already been freed
Signed-off-by: Fabian Ebner
There might still be an edge case where completion and cancel race (I
didn't run into this in practice yet, but at a first glance it seems
possible):
1. job_exit -> job_completed -> job_finalize_single starts
2. pvebackup_co_complete_stream gets spawned in completion callback
3. job finalize_singl
but the approach with
using the first non-completed job seemed more robust.
Signed-off-by: Fabian Ebner
---
Intended to be ordered after
0038-PVE-Backup-Don-t-block-on-finishing-and-cleanup-crea.patch
or could also be squashed into that (while lifting the commit message
to the main repo). Of cou
Am 19.05.22 um 15:35 schrieb Matthias Heiserer:
> On 18.05.2022 11:40, Fabian Ebner wrote:
>> Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
>>> Existing disks are not changed by this.
>>> Especially in benchmarks, iothreads significantly improve IO
>>> pe
Please use "fix #3890:" as a prefix to be consistent with how other bug
fix commits do it.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
>
>
> Signed-off-by: Matthias Heiserer
> ---
>
> Changes from v2:
> * also check iothread when adding a disk to an existing VM an
Am 12.05.22 um 15:17 schrieb Daniel Tschlatscher:
> unlink $logpath or warn "removing log file $logpath failed: $!\n";
Forgot to say that we could switch to using PVE::RESTEnvironment's
log_warn here
> }
> }
> +
> +if (defined($notesfn)) {
> + my $notespath = "$dirnam
Looks good to me, just a few suggestions for further improvements.
Am 12.05.22 um 15:17 schrieb Daniel Tschlatscher:
> When a VM or Container backup was deleted, the .notes file was not
> removed, therefore, over time the dump folder would get polluted with
> notes for backups that no longer exist
Am 12.05.22 um 15:17 schrieb Daniel Tschlatscher:
> The archive_info object now returns one more field containing the
> name of the notes file. The test cases have to be adapted to expect
> this new value as the package will not compile otherwise.
Ideally, the package will compile after each commi
able there.
Signed-off-by: Fabian Ebner
---
src/window/FileBrowser.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
index a519d6b..8db7c51 100644
--- a/src/window/FileBrowser.js
+++ b/src/window/FileBrowser.js
@@ -308,
/qemu-project/qemu/-/issues/1026
Forum threads:
https://forum.proxmox.com/threads/109272/
https://forum.proxmox.com/threads/109448/
https://forum.proxmox.com/threads/101334/ (partially)
Signed-off-by: Fabian Ebner
---
I simply removed the other two patches already fixing the offending
commit from
Commit title should include "fixes #3972"
Please note that there's also an archive_remove() function in Storage.pm
which is called when pruning. That (and I'd say archive_info() too)
should be extended to also handle the notes file.
Am 10.05.22 um 14:09 schrieb Daniel Tschlatscher:
> When a VM or
properties' to have the target inherit the compression
property even works during later syncs (but pre-existing data won't be
recompressed automatically then).
Signed-off-by: Fabian Ebner
---
Put it near 'properties' as I felt like that was the most similar one.
pve-zsync
Am 10.05.22 um 09:26 schrieb Fabian Ebner:
> Am 28.04.22 um 10:44 schrieb Matthias Heiserer:
>> Previously, only a plaintext line in the task log showed something was off.
>> Now, the GUI will show it as a warning.
>>
>> Signed-off-by: Matthias Heiserer
>> ---
Am 28.04.22 um 10:44 schrieb Matthias Heiserer:
> Previously, only a plaintext line in the task log showed something was off.
> Now, the GUI will show it as a warning.
>
> Signed-off-by: Matthias Heiserer
> ---
Note: requires a dependency bump for libpve-common-perl (it's currently
at 7.1-3 but
Am 28.04.22 um 10:44 schrieb Matthias Heiserer:
> And move it from the advanced section to the always shown area.
>
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
>
> Especially in benchmarks, iothreads significantly improve IO performance.
1 - 100 of 1001 matches
Mail list logo
