ich is
one day. The minimum value is 0, which disables the timeout.
Signed-off-by: Daniel Tschlatscher
---
No changes from v3
PVE/API2/Qemu.pm | 2 ++
PVE/QemuServer.pm | 1 +
PVE/QemuServer/Helpers.pm | 4
3 files changed, 7 insertions(+)
diff --git a/PVE/API2/Qemu.pm
This allows setting the 'startoptions' property string in the config.
For now this only implements the 'timeout' parameter but should be
rather easily extensible and allow related VM start config options
to be also configurable here.
Signed-off-by: Daniel Tschlatscher
---
C
config)
To avoid unwanted side effects, it is possible to change the value for
the new 'startoptions' parameter, only if the VM is currently locked
with lock 'suspended'.
Signed-off-by: Daniel Tschlatscher
---
No changes from v3
PVE/API2/Qemu.pm | 25 +
nfigurable with it.
Changes from v3
* Minor code cleanup
* Addressed an edge case concerning the killing of a lingering VM to
not accidentally kill an unrelated process
Thanks to Fabian for the review and suggestions!
pve-common:
Daniel Tschlatscher (1):
VM start timeout config parameter
This avoids accidentally killing a potentially completely unrelated
process that was spawned in an edge case between the last check in the
timeout loop and the kill command.
Signed-off-by: Daniel Tschlatscher
---
Changes from v3:
* New patch
PVE/QemuServer.pm | 2 +-
1 file changed, 1
parameters.
Signed-off-by: Daniel Tschlatscher
---
No changes from v3:
www/manager6/qemu/Options.js | 31 +++
1 file changed, 31 insertions(+)
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 7b112400..7f148e18 100644
--- a/www/manager6/qemu/
get around this, this patch intercepts the error, looks whether a
corresponding KVM thread is still running, and waits for/kills it,
before continuing.
Signed-off-by: Daniel Tschlatscher
---
Changes from v3:
* Minor code clean up concerning the usage of "$pid" in ifs according
t
Adds a function for downloading a file from a remote URL in the Utils
class and uses it to revise one similar usage in FileBrowser.js
Signed-off-by: Daniel Tschlatscher
---
No changes from v5 (was last included in v2)
src/Utils.js | 13 +
src/window/FileBrowser.js | 11
Adds a download button in the TaskViewer. Uses the newly created
downloadAsFile() method in the Utils class.
Signed-off-by: Daniel Tschlatscher
---
Changes from v5
* Last version erroneously used "limit=0" instead of the download
parameter in the download URL
src/window/TaskView
VE and the GUI patches in the widget-toolkit for the button in the
TaskViewer.
Changes from v5:
* The last version used parameter 'limit=0' instead of 'download=1'
for the download URL.
* Cleaned up one NIT in manager.
Thanks to sterzy for the review!
pve-manager:
Daniel T
The read_tasklog API call now stream the whole log file if the query
parameter 'download' is set to true.
This is done in preparation for the task log download button to be
added in the TaskViewer.
Signed-off-by: Daniel Tschlatscher
---
Changes from v5:
* Made the if check for w
On 12/22/22 14:20, Fabian Grünbichler wrote:
> On December 22, 2022 1:58 pm, Daniel Tschlatscher wrote:
>
>>>>
>>>> - my $exitcode = run_command($cmd, %run_params);
>>>> - if ($exitcode) {
>>>> - if ($tpmpid) {
>>
On 12/21/22 12:14, Fabian Grünbichler wrote:
> On December 16, 2022 2:36 pm, Daniel Tschlatscher wrote:
>> In some cases the VM API start method would return before the detached
>> KVM process would have exited. This is especially problematic with HA,
>> because the HA manag
config)
To avoid unwanted side effects, it is possible to change the value for
the new 'startoptions' parameter, only if the VM is currently locked
with lock 'suspended'.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
* Rebased to current master
P
parameters.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
* No changes
www/manager6/qemu/Options.js | 31 +++
1 file changed, 31 insertions(+)
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 7b112400..7f148e18 100644
--- a/www/man
ich is
one day. The minimum value is 0, which disables the timeout.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
* No changes
PVE/API2/Qemu.pm | 2 ++
PVE/QemuServer.pm | 1 +
PVE/QemuServer/Helpers.pm | 4
3 files changed, 7 insertions(+)
diff --git a/PVE/API2
This allows setting the 'startoptions' property string in the config.
For now this only implements the 'timeout' parameter but should be
rather easily extensible and allow related VM start config options
to be also configurable here.
Signed-off-by: Daniel Tschlatscher
get around this, this patch intercepts the error, looks whether a
corresponding KVM thread is still running, and waits for/kills it,
before continuing.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
* Rebased to current master
* Changed warn to use 'log_warn' instead
* Re
nfigurable with it.
Changes from v2
* Rebased to current repository masters
* Some minor code cleanups
* Reordered the commits and added a cover letter
pve-common:
Daniel Tschlatscher (1):
VM start timeout config parameter
src/PVE/JSONSchema.pm | 38 ++
1 fi
Testing this series in the Browser, with curl and postman, I couldn't
find any issues anymore, more details below. Code looks good to me as well.
Tested-by: Daniel Tschlatscher
Reviewed-by: Daniel Tschlatscher
Browser/GUI:
✅ Uploading files with 0B, 1B, 1kB, 17kB, 1MB, 1GB, 10GB
✅ Uplo
The read_tasklog API call now stream the whole log file if the query
parameter 'download' is set to true.
This is done in preparation for the task log download button to be
added in the TaskViewer.
Signed-off-by: Daniel Tschlatscher
---
No changes from v4
PVE/API2/Tas
Adds a download button in the TaskViewer. Uses the newly created
downloadAsFile() method in the Utils class.
Signed-off-by: Daniel Tschlatscher
---
No changes from v4 (was last included in v2)
src/window/TaskViewer.js | 17 +++--
1 file changed, 15 insertions(+), 2 deletions
VE and the GUI patches in the widget-toolkit for the button in the
TaskViewer.
pve-manager:
Daniel Tschlatscher (1):
make task log downloadable in the PVE manager backend
PVE/API2/Tasks.pm | 48 ---
1 file changed, 41 insertions(+), 7 deletions(-
Adds a function for downloading a file from a remote URL in the Utils
class and uses it to revise one similar usage in FileBrowser.js
Signed-off-by: Daniel Tschlatscher
---
No changes from v4 (was last included in v2)
src/Utils.js | 13 +
src/window/FileBrowser.js | 11
Before, if a non-existent source archive parameter was passed when
restoring a container, the task would fail but leave an empty config
file behind. The same with invalid mount point configurations.
In both cases, the empty config will now be removed.
Signed-off-by: Daniel Tschlatscher
is.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* Moved into destroy_config_on_error check
src/PVE/API2/LXC.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index f2113de..50c9eaf 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2
This text is only displayed when at least one tag is defined in the
User Tag Access editor.
Signed-off-by: Daniel Tschlatscher
---
www/manager6/dc/OptionView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
applies.
=> Thanks to Fabian for the review!
changes from v3
* parameter 'download' for downloading the task log
* limit=0 now returns the whole log instead
* miscellaneous code clean up
proxmox-backup:
Daniel Tschlatscher (1):
make tasklog downloadable i
eplaced it with a call to dump_logfile(), akin to how
this is handled in pve-manager.
Signed-off-by: Daniel Tschlatscher
---
Changes from v3:
* API parameter 'download' for directly streaming the file
* Added missing API parameter descriptions
src/PM
one of the lower level apimethod types from the
proxmox-router. Therefore, the routing declarations and parameter
schemas have been changed accordingly.
Signed-off-by: Daniel Tschlatscher
---
I sent this separately, as the other 3 patches in this version do not
concern the backup patch in any way.
Ch
The read_tasklog API call now stream the whole log file if the query
parameter 'download' is set to true.
This is done in preparation for the task log download button to be
added in the TaskViewer.
Signed-off-by: Daniel Tschlatscher
---
Changes from v3:
* API parameter 'downloa
The dump_logfile now returns the whole log file if the limit parameter
is set to 0. This must be done explicitely though, as in the case of
'limit' being undefined, the default as before, 50 will be used.
Signed-off-by: Daniel Tschlatscher
---
Changes from v3:
* NEW patch
This
Looks good, 1 suggestions, 2 NITs inline:
On 11/21/22 10:49, Stefan Sterz wrote:
> Signed-off-by: Stefan Sterz
> ---
> de.po | 185 +++---
> 1 file changed, 72 insertions(+), 113 deletions(-)
>
> diff --git a/de.po b/de.po
> index ea6f50b..efd
Signed-off-by: Daniel Tschlatscher
---
qm.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index e7d0c07..428d388 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -636,6 +636,11 @@ but not via the WebUI.
You can also skip adding a network device when creating a VM by
Before, if an invalid/non-existant ostemplate parameter was passed,
the task would abort, but would leave an empty config file behind.
This also applies to errors for invalid mount point configurations.
In both cases, the empty config will now be removed.
Signed-off-by: Daniel Tschlatscher
is.
Signed-off-by: Daniel Tschlatscher
---
src/PVE/API2/LXC.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 7cc64af..27b63f2 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -505,6 +505,9 @@ __PACKAGE__->register_met
On 11/11/22 15:02, Stefan Hanreich wrote:
>
> On 11/11/22 14:58, Daniel Tschlatscher wrote:
>> The new hookscript example works nicely out of the box.
>>
>> I tested restore for both VMs and containers via the GUI, the restore
>> and create commands in the respec
e this is not breaking, it is definitely very unexpected for an
unsuspecting user.
Otherwise, the core part of the series works as intended, therefore:
Tested-by: Daniel Tschlatscher
On 11/10/22 16:33, Stefan Hanreich wrote:
> This patch adds hooks that run when the user restores a backup
On 11/10/22 16:33, Stefan Hanreich wrote:
> Signed-off-by: Stefan Hanreich
> ---
> examples/guest-example-hookscript.pl | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/examples/guest-example-hookscript.pl
> b/examples/guest-example-hookscript.pl
> index adeed59..19fe213
case, just looking at
the task log list, it looks like the task finished without any problems.
This would require some changes in 'exec_hookscript' and probably for
other 'post-x' hooks as well, though, this is not in the scope of these
patches. I just thought to put it somewhere
re visually pleasing.
Signed-off-by: Daniel Tschlatscher
---
Changes from v6
* The message tooltip is now in the advancedColumnB
www/manager6/qemu/NetworkEdit.js | 36
1 file changed, 36 insertions(+)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6
The help button under Datacenter > Firewall > Security Group did not
have the proper help chapter link set.
First reported here:
https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/
Signed-off-by: Daniel Tschlatscher
---
I noticed that the onlineHelp field for our
The option to set the mtu parameter for lxc containers already exists
in the backend. It just has to be exposed in the web UI as well.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* fieldLabel for MTU textfield no longer uses gettext()
* text field has an emptyText now
* the minimum
This patch reworks some mtu settings for LXC containers in the backend
Namely, introducing an absolute maximum for the MTU field of 65535 and
asserting that the MTU setting isn't bigger than the bridge's MTU size
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* New
The new MTU field and the rate limit field are now in the advanced
section of the NetworkInputPanel to parallel the layout of the
NetworkEdit for VMs.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1
* This patch now only moves the rate limit text field
www/manager6/lxc/Network.js | 23
The option to set the mtu parameter for lxc containers already exists
in the backend. It only had to be exposed in the web UI as well.
Signed-off-by: Daniel Tschlatscher
---
www/manager6/lxc/Network.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/www/manager6/lxc
The new MTU field and the rate limit field are now in the advanced
section of the NetworkInputPanel to parallel the layout of the
NetworkEdit for VMs.
Signed-off-by: Daniel Tschlatscher
---
While the layout now is the same as in the VM NetworkEdit, I just feel
like the advanced column does not
This patch still applies well and works as intended.
There is one UI suggestion inline.
Tested-by: Daniel Tschlatscher
On 5/20/22 10:03, Oguz Bektas wrote:
> we already have the 'mtu' option in the API, so we can just expose
> that option inside the 'Advanced
from the proxmox-router. Therefore I also had to change declarations
for the API routing and the corresponding Object Schemas.
Signed-off-by: Daniel Tschlatscher
---
changes from v2
* improved the documentation for the limit parameter
* changed the api method name to "read_task_log"
src
tasklog and replaced it with a call to dump_logfile(), akin to how
this is handled in pve-manager.
Signed-off-by: Daniel Tschlatscher
---
changes from v2
* replaced helper call with inline implementation
* changed compression cutoff to 1024
* replaced stat($filename)→size call with "-s&q
The read tasklog API call now streams the log file if the limit
parameter is set to 0. If not, it should behave the same as before.
This is done in preparation for the task log download button to be
added in the TaskViewer.
Signed-off-by: Daniel Tschlatscher
---
changes from v2
* replaced
eter
* minor refactorings
Daniel Tschlatscher (1):
make tasklog downloadable in the backup server backend
src/api2/node/tasks.rs | 161 ++---
1 file changed, 103 insertions(+), 58 deletions(-)
Daniel Tschlatscher (1):
make tasklog downloadable in the P
Thanks for the review!
On 10/5/22 14:30, Thomas Lamprecht wrote:
> Am 07/09/2022 um 10:56 schrieb Daniel Tschlatscher:
>> The API call for fetching a tasklog with limit=0 now returns the whole
>> log as a file stream rather than reading all lines in memory and then
>> tra
On 9/8/22 11:36, Stefan Sterz wrote:
> On 9/7/22 10:56, Daniel Tschlatscher wrote:
>> With the newly added button in the tasklog the implementation for the
>> PMG server needs to be adapted. I saw an opportunity here to clear
>> some redundant code for displaying the tasklo
to change declarations
for the API routing and the corresponding Object Schemas.
If the parameter 'limit' is not set to 0 the API should behave the
same as before.
Signed-off-by: Daniel Tschlatscher
---
src/api2/node/tasks.rs | 159 ++---
1 file changed, 1
x as far as I could tell.
See https://bugs.chromium.org/p/chromium/issues/detail?id=993362 for
more information on this.
-- Changes from v1 --
* Rewrote commit messages and cover letter
* Got rid of some refactoring which were initially included
(going to send as own patch series later)
*
Adds a function for downloading a file from a remote URL in the Utils
class and uses it to revise one similar usage in FileBrowser.js
Signed-off-by: Daniel Tschlatscher
---
src/Utils.js | 13 +
src/window/FileBrowser.js | 11 +--
2 files changed, 18 insertions
functionality now streams the file by invoking
the newly created function in pve-common.
Signed-off-by: Daniel Tschlatscher
---
src/PMG/API2/Tasks.pm | 34 +++---
1 file changed, 11 insertions(+), 23 deletions(-)
diff --git a/src/PMG/API2/Tasks.pm b/src/PMG/API2
Adds a download button in the TaskViewer. Uses the newly created
downloadAsFile() method in the Utils class.
Signed-off-by: Daniel Tschlatscher
---
src/window/TaskViewer.js | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/window/TaskViewer.js b/src
specification.
Signed-off-by: Daniel Tschlatscher
---
PVE/API2/Tasks.pm | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 9cd1e56b..88762f2f 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -5,6 +5,7 @@ use warnings
Acknowledging the Content-Disposition header makes it possible for the
backend to tell the browser whether a file should be downloaded,
rather than displayed inline, and what it's default name should be.
Signed-off-by: Daniel Tschlatscher
---
src/PVE/APIServer/AnyEvent.pm | 3 +++
1
Creating the filestream for the tasklog download is sourced in its own
function to avoid redundant implementations in pmg-api and pve-manager
Signed-off-by: Daniel Tschlatscher
---
src/PVE/Tools.pm | 28
1 file changed, 28 insertions(+)
diff --git a/src/PVE
A few suggestions I would have found helpful when first reading this
documentation, inline:
On 6/10/22 12:53, Markus Frank wrote:
> added AMD SEV documentation for "[PATCH qemu-server] QEMU AMD SEV
> enable"
>
> Signed-off-by: Markus Frank
> ---
> v2:
> * added check if sev is enabled
> * added
->cgs->ready' failed.
I suspect that this feature is simply not supported by my
motherboard/BIOS yet, but did not find the actual cause for this problem.
I did not test SEV-SNP as it seems to be a 3rd gen Epyc CPU feature.
Tested-by: Daniel Tschlatscher
Some more comments inline in th
spinUpEl and spinDownEl were removed as
well. Additionally, the 'mousewheel' event handler, registered in the
overwritten (but still executed) parent function, is unregistered now,
as it could lead to unintended side effects in browsers which still
implement this event.
Signed-off-
get around this, this patch intercepts the error, looks whether a
corresponding KVM thread is still running, and waits for/kills it,
before continuing.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* New patch
PVE/QemuServer.pm | 40 +---
1 file
This allows setting the 'startoptions' property string in the config.
For now this only implements the 'timeout' parameter but should be
rather easily extensible and allow related VM start config options
to be also configurable here.
Signed-off-by: Daniel Tschlatscher
---
Cha
ich is
one day. The minimum value is 0, which disables the timeout.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* Now uses the "startoptions" propertystring
* Maximum timeout reduced to 86400
PVE/API2/Qemu.pm | 2 ++
PVE/QemuServer.pm | 1 +
PVE/QemuS
parameters.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* Now uses a property string to encode the timeout
www/manager6/qemu/Options.js | 31 +++
1 file changed, 31 insertions(+)
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
inde
config)
To avoid unwanted side effects, it is possible to change the value for
the new 'startoptions' parameter, only if the VM is currently locked
with lock 'suspended'.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1:
* New patch
PVE/API2/Qemu.pm | 25 +
/decrement by step * 2.
The problem was an overwrite for the onRender() method of the Spinner
class, which caused the callbacks for pressing an arrow key to be
registered for a second time. Simply not doing that in the overwritten
onRender() method fixes the problem.
Signed-off-by: Daniel
ver encounter them.
However, I feel like that at the very least the basic error message
should be revised to no longer return 501 and to include a more
descriptive error message than just "upload failed".
With no major problems and depending
ping
(And now that I see it, the patches should actually count up to 7, they
are not in fact 1/1 standalone patches)
On 4/26/22 14:35, Daniel Tschlatscher wrote:
> This patch series' aim is to add a download button in the tasklog-
> viewer GUI so that users may access all parts of
the next HA
check was scheduled, in spite of the expected HA state being 'stopped'
This patches fixes this issue and brings it more in line with the
expected behaviour.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
* This patch no longer includes also changing the return
On 6/21/22 17:52, Thomas Lamprecht wrote:
> fix #3502: add start timeout config parameter
>
> Am 21/06/2022 um 17:20 schrieb Daniel Tschlatscher:
>> It was already possible to set the timeout parameter for the VM config
>> via the API. However, the value was not conside
which nobody should realistically
run into.
Signed-off-by: Daniel Tschlatscher
---
PVE/API2/Qemu.pm | 1 +
PVE/QemuServer.pm | 7 +++
PVE/QemuServer/Helpers.pm | 3 +++
3 files changed, 11 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index a824657..d0a4eaa 1
value manually in the config)
Signed-off-by: Daniel Tschlatscher
---
To make it possible to change the timeout config value when the VM
is locked I created a function to tell whether the config should
be editable or not. This reduces clutter in the already rather long
invoking function. I also tried
The qemu config in the backend already allows specifying a timeout
value. This patch introduces a text field in the Options submenu when
a VM is selected, through which the VM start timeout can be set in the
config.
Signed-off-by: Daniel Tschlatscher
---
www/manager6/qemu/Options.js | 18
id similar problems with leftover config files in the future.
Signed-off-by: Daniel Tschlatscher
---
Changes from v1
Some problems which I was made aware of by Fabian (G) through a quick
chat off-list (thanks btw!):
* Added a dedicated check to conditionally remove the locks for the
new and old co
On 6/14/22 14:51, Fabian Grünbichler wrote:
> On June 14, 2022 2:22 pm, Daniel Tschlatscher wrote:
>> When an attempt was made to clone a locked container the API would
>> correctly present the error 'CT is locked (disk)' but create the
>> config files for the new
or the new container.
Signed-off-by: Daniel Tschlatscher
---
src/PVE/API2/LXC.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 64724cb..e1b4cd3 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -1461,9 +1461,6 @@ _
Signed-off-by: Daniel Tschlatscher
Reviewed-by: Fabian Ebner
---
Changes from v3
* No fix # in commit title
* Added import for PVE::RESTEnvironment to call log_warn directly
PVE/Storage.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE
This improves handling when two archive remove calls are creating a
race condition where one would formerly encounter an error. Now both
finish successfully.
Signed-off-by: Daniel Tschlatscher
Reviewed-by: Fabian Ebner
---
Changes from v3
* No fix # in commit title
PVE/Storage.pm | 4
and refactored usages for .log and .notes with them.
At some parts in the test case code I had to source new variables to
shorten the line length to not exceed the 100 column line limit.
Signed-off-by: Daniel Tschlatscher
Reviewed-by: Fabian Ebner
---
Changes from v3
* File extension constants
be adapted to expect this new
value as the package will not compile otherwise.
Signed-off-by: Daniel Tschlatscher
Reviewed-by: Fabian Ebner
---
Changes from v3
* removed unused variables $logfn and $notesfn
PVE/API2/Storage/Content.pm | 5 ++---
PVE/Storage.pm
or message modals in the PVE, PMG and PBS.
Signed-off-by: Daniel Tschlatscher
---
src/Toolkit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index a1d291e..450a3bc 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -718,6 +718,7 @@ Ext.onRead
On 5/25/22 17:06, Thomas Lamprecht wrote:
On 20/05/2022 15:28, Daniel Tschlatscher wrote:
When a VM or Container backup was deleted, the .notes file was not
removed, therefore, over time the dump folder would get polluted with
notes for backups that no longer existed. As backup names contain
and refactored usages for .log and .notes with them.
At some parts in the test case code I had to source new variables to
shorten the line length to not exceed the 100 column line limit.
Signed-off-by: Daniel Tschlatscher
---
PVE/Storage.pm| 4 ++--
PVE/Storage/Plugin.pm | 1
This improves handling when two archive remove calls are creating a
race condition where one would formerly encounter an error. Now both
finish successfully.
Signed-off-by: Daniel Tschlatscher
---
PVE/Storage.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE
be adapted to expect this new
value as the package will not compile otherwise.
Signed-off-by: Daniel Tschlatscher
---
PVE/API2/Storage/Content.pm | 5 ++---
PVE/Storage.pm | 20 +++-
test/archive_info_test.pm | 6 ++
3 files changed, 23 insertions(+), 8
Signed-off-by: Daniel Tschlatscher
---
PVE/Storage.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 6f2558f..98ecd60 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -1604,7 +1604,8 @@ sub archive_auxiliaries_remove {
my
On 5/12/22 17:13, Thomas Lamprecht wrote:
Am 5/6/22 um 14:39 schrieb Daniel Tschlatscher:
Add the subentry "Options" in the "System" menu to expose some options
in the GUI which were not exposed before.
Added a new file for displaying and editing the node config options
wh
The archive_info object now returns one more field containing the
name of the notes file. The test cases have to be adapted to expect
this new value as the package will not compile otherwise.
Signed-off-by: Daniel Tschlatscher
---
test/archive_info_test.pm | 6 ++
1 file changed, 6
DRY.
I saw this change necessary because archive_remove() does not invoke
external plugins, and doing so might have unintended side effects.
Signed-off-by: Daniel Tschlatscher
---
PVE/API2/Storage/Content.pm | 5 ++---
PVE/Storage.pm | 19 +--
2 files changed, 19
Fixed a cosmetic issue where in the VM creation wizard the SCSI
controller would not be displayed correctly if the default value
"Default (LSI 53C895A)" was selected. In this case, "__default__"
would be printed for the user in the next pane.
Signed-off-by: Daniel Tschlatsche
just like we
do with the .log file.
Signed-off-by: Daniel Tschlatscher
---
PVE/API2/Storage/Content.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm
index 8ff858d..3f9d77f 100644
--- a/PVE/API2/Storage/Content.pm
+++ b/PVE/API2
an IO thread.
Everything worked as advertised.
Tested-by: Daniel Tschlatscher
On 4/28/22 10:44, Matthias Heiserer wrote:
And move it from the advanced section to the always shown area.
Because of the propertyStringSet call in onGetValues, existing VM
show the correct iothread value.
Especial
artall-on-boot-delay. Edited the Makefile
to include the newly created file.
Signed-off-by: Daniel Tschlatscher
---
Changes from v2:
- Moved the file from the widget-toolkit to the pve-manager repository
because it implements PVE specific functionality.
- I originally rewrote this class to use a
Alpine 3.12 VM
Everything worked as advertised.
Tested-by: Daniel Tschlatscher
On 5/3/22 13:18, Markus Frank wrote:
Needed for new machine parameter, because parse_property_string checks
the parameter with the regex-pattern and therefore the test-cases with
somemachine & someothermachine a
Signed-off-by: Daniel Tschlatscher
---
de.po | 217 +++---
1 file changed, 84 insertions(+), 133 deletions(-)
diff --git a/de.po b/de.po
index 5cc8308..d5c4e80 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Pro
1 - 100 of 123 matches
Mail list logo
