This patch series' aim is to add a download button in the tasklog- viewer GUI so that users may access the tasklog more easily. (The tasklog-viewer only displays 50 lines at a time) Instead of suddenly returning a file stream when the 'limit' parameter is set to 0, now, a new parameter 'download' needs to be passed. This parameter is mutually exclusive with the other parameters.
Before, the backup server backend would simply return an array with no content for a call with parameter 'limit=0', the pmg and pve backends would fall back to the default of 50. To unify this, setting 'limit=0' will now return everything until the end of the log file in the normal json format. This is useful in case it is unknown how many lines the log contains, with 0 being a bit nonsensical for other cases anyway. If no parameter is given, the default of 50 still applies. => Thanks to Fabian for the review! changes from v3 * parameter 'download' for downloading the task log * limit=0 now returns the whole log instead * miscellaneous code clean up proxmox-backup: Daniel Tschlatscher (1): make tasklog downloadable in the backup server backend src/api2/node/tasks.rs | 209 +++++++++++++++++++++++++---------------- 1 file changed, 129 insertions(+), 80 deletions(-) pmg-api: Daniel Tschlatscher (1): make tasklog downloadable in the PMG backend src/PMG/API2/Tasks.pm | 60 ++++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 24 deletions(-) pve-manager: Daniel Tschlatscher (1): make task log downloadable in the PVE manager backend PVE/API2/Tasks.pm | 48 ++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 7 deletions(-) pve-common: Daniel Tschlatscher (1): return whole log file if limit is 0 src/PVE/Tools.pm | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
