[pve-devel] [PATCH widget-toolkit] window: ACMEDomains: show error dialog on domain limit

2025-01-29 Thread Christoph Heiss
ads/acme-max-certificate.161400/ Signed-off-by: Christoph Heiss --- src/window/ACMEDomains.js | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/window/ACMEDomains.js b/src/window/ACMEDomains.js index 1fcc784..067cbc9 100644 --- a/src/window/ACMEDomains.js +

Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names

2025-01-29 Thread Christoph Heiss
On Tue Jan 28, 2025 at 3:38 PM CET, Thomas Lamprecht wrote: > Am 05.12.24 um 15:07 schrieb Daniel Kral: [..] > > - with `cert-fingerprint` (which works correctly as expected), and > > - with `cert_fingerprint` (which will fail at a parser error with the > > newest Proxmox VE 8.3-1 ISO). > > This is

[pve-devel] [PATCH proxmox-firewall] d/control: drop unused build dependencies

2025-01-24 Thread Christoph Heiss
These are simply just of the proxmox-ve-config crate, which was moved to a separate repository in aa7692036 ("add proxmox-ve-rs crate - move proxmox-ve-config there") and are not used by the other remaining crates. Signed-off-by: Christoph Heiss --- debian/control | 5 - 1 fi

[pve-devel] [PATCH proxmox-ve-rs] config: fix a few clippy warnings

2025-01-16 Thread Christoph Heiss
.. as newly introduced with 1.84. Namely `elided_named_lifetimes` for the change of `SdnConfig` and `clippy::needless_lifetimes` for the rest. Signed-off-by: Christoph Heiss --- proxmox-ve-config/src/firewall/parse.rs | 6 +++--- proxmox-ve-config/src/sdn/config.rs | 2 +- 2 files changed

[pve-devel] [PATCH proxmox-ve-rs] config: fix some typos

2024-12-17 Thread Christoph Heiss
Some typos snuck in the package description and rustdoc, fix them up. Signed-off-by: Christoph Heiss --- proxmox-ve-config/debian/control | 2 +- proxmox-ve-config/src/firewall/types/alias.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-ve-config

Re: [pve-devel] [PATCH installer] fix #5984: unconfigured: do not reboot if auto-installer fails by default

2024-12-17 Thread Christoph Heiss
Thanks for tackling this! But this still doesn't really fix the issue by honoring the `global.reboot_on_error` flag in any way, but just inverts the current behaviour? I.e. now it just always drops into the a shell, w/o ever auto-rebooting, even if `global.reboot_on_error = true`. This would need

Re: [pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v2 0/8] raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
v2: https://lore.proxmox.com/pve-devel/20241216094114.476756-1-c.he...@proxmox.com/ On Fri Nov 29, 2024 at 1:21 PM CET, Christoph Heiss wrote: > [..] ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mail

[pve-devel] [PATCH installer v3 4/8] auto: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
igned-off-by: Christoph Heiss --- Changes v2 -> v3: * added rustdoc for `verify_email_and_root_password_settings` Changes v1 -> v2: * reworked check to use a `match` instead, as suggested by Stefan proxmox-auto-installer/src/utils.rs | 30 ++- .../test

[pve-devel] [PATCH installer v3 2/8] proxinstall: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * no changes Changes v1 -> v2:

[pve-devel] [PATCH pve-docs v3 6/8] installation: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[pve-devel] [PATCH installer v3 3/8] tui: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * no changes Changes v1 -> v2:

[pve-devel] [PATCH installer v3 1/8] common: convert `InstallRootPassword` into an enum

2024-12-16 Thread Christoph Heiss
It's more appropriate for that type of data, since only one of both variants is ever allowed to be set. Makes it also a bit more ergonomic to handle. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * added rustdoc for `InstallRootPassword` Changes v1 -> v2: * new patch p

[pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v3 0/8] raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
* rebased on latest master * new patch #3; converting `InstallRootPassword` to an enum * new patch #5; negative tests * new patches #6 through #8: respective documentation updates Diffstat pve-installer: Christoph Heiss (5): common: convert `InstallRootPassword` i

[pve-devel] [PATCH installer v3 5/8] auto: add negative tests for root password option

2024-12-16 Thread Christoph Heiss
Extends our test runner for the parse-answer tests to also run some tests which are expected to fail, with a pre-determined error message given in the accompanying json. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased; use separate test function for tests instead of re

[pve-devel] [PATCH proxmox-backup v3 8/8] using-the-installer: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch docs/using-the-installer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[pve-devel] [PATCH pmg-docs v3 7/8] installation: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch pmg-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [pve-devel] [PATCH installer v2] auto: allow a binary executable as the first boot executable

2024-12-13 Thread Christoph Heiss
aries must be (obviously) x86_64 and best case statically linked, as there otherwise no guarantees that it will run on the target system and might just fail blindly. Please consider this patch: Tested-by: Christoph Heiss Reviewed-by: Christoph Heiss FWIW, just thinking out loud here:

[pve-devel] [PATCH installer 4/6] common: setup: include path in error message if file could not be read

2024-12-09 Thread Christoph Heiss
Makes it a bit easier to figure out what went wrong in the error case. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common

[pve-devel] [PATCH installer 2/6] country.pl: generate final structure as json at build time directly

2024-12-09 Thread Christoph Heiss
intermediate format completely and just generate the final data structure as JSON at build time. Signed-off-by: Christoph Heiss --- .gitignore| 2 +- Makefile | 16 +-- Proxmox/Install/ISOEnv.pm | 56

[pve-devel] [PATCH installer 5/6] fix #5889: assistant: validate answer email & root password settings

2024-12-09 Thread Christoph Heiss
These checks are basically "free" and can be re-used from the auto-installer 1:1. Signed-off-by: Christoph Heiss --- proxmox-auto-install-assistant/src/main.rs | 9 + proxmox-auto-installer/src/utils.rs| 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) di

[pve-devel] [PATCH installer 1/6] tui: options: simplify unit-test setup

2024-12-09 Thread Christoph Heiss
We already have `SetupInfo::mocked()` since commit c3c9282 ("common: add mocked variants for setup and ISO related info structs"), so use that. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs | 26 +++--- 1 file changed, 3 insertions(+), 23

[pve-devel] [PATCH installer 3/6] common: setup: read locale info as shipped by the installer directly

2024-12-09 Thread Christoph Heiss
Now that we have a pre-generated `locale-info.json` available, skip generating one on-the-fly and just read that one. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 20 +++- proxmox-low-level-installer | 3 --- 2 files changed, 15

[pve-devel] [PATCH installer 6/6] assistant: validate answer first-boot hook and locale settings

2024-12-09 Thread Christoph Heiss
For the first-boot hook, the check from the auto-installer can be easily re-used. For the locale, as we now have that information available as JSON, include that file in the assistant and use it to verify the answer file settings. Signed-off-by: Christoph Heiss --- proxmox-auto-install

[pve-devel] [PATCH installer 0/6] assistant: properly validate answer file settings

2024-12-09 Thread Christoph Heiss
- thus being able to include it in the auto-install-assistant for verify answer file settings. Christoph Heiss (6): tui: options: simplify unit-test setup country.pl: generate final structure as json at build time directly common: setup: read locale info as shipped by the installer directly

Re: [pve-devel] [RFC PATCH installer] auto: allow a binary executable as the first boot executable

2024-12-09 Thread Christoph Heiss
Apart from one note inline, LGTM overall. On Fri, Dec 06, 2024 at 02:24:55PM +0100, Daniel Kral wrote: > [..] > When the HTTP response is missing the "Content-Length" header, it will > be explicitly stated in the error message. Why mandate the `Content-Length` header tho? For HTTP/1.1, it is only

[pve-devel] [PATCH installer] tree-wide: add workspace-level cargo package version

2024-12-05 Thread Christoph Heiss
rs have to effectively fall back to their system package manager (if installed via such) to identify the correct version. Signed-off-by: Christoph Heiss --- Of course, that version now also needs to be bumped each time, in addition to updating d/changelog -- much like it is done for proxmox-bac

[pve-devel] [PATCH installer 2/4] auto-installer: tests: create separate unit test for each answer file

2024-12-03 Thread Christoph Heiss
e built-in facilities of `cargo test` at the same time. Also means that a failing test won't cancel all other tests. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/tests/parse-answer.rs | 83 +++ .../{first-boot.json => first_boot.json} | 0 ..

[pve-devel] [PATCH installer 4/4] tui: use pretty_assertions for object equal asserts

2024-12-03 Thread Christoph Heiss
Using the previously introduced `pretty_assertions` crates for object comparisons improves developer UX quite a bit, making failures easier to observe and quickly reason about. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/Cargo.toml | 3 +++ proxmox-tui-installer/src/options.rs

[pve-devel] [PATCH installer 3/4] auto-installer: tests: add diff'ed assertions for answer parsing tests

2024-12-03 Thread Christoph Heiss
-cbba-4d79-8535-d2bc7c556...@proxmox.com/ Signed-off-by: Christoph Heiss --- debian/control | 1 + proxmox-auto-installer/Cargo.toml| 3 +++ proxmox-auto-installer/tests/parse-answer.rs | 6 +++--- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git

[pve-devel] [PATCH installer 0/4] auto, tui: improve rust unit test setup

2024-12-03 Thread Christoph Heiss
assertions` crate (as a dev-dependency only, tho) for all object comparison - primarily the answer file parsing/validation tests. This makes failures way easier to observe and quickly reason about. No functional changes in the entire series. Christoph Heiss (4): auto-installer: tests: add tests for

[pve-devel] [PATCH installer 1/4] auto-installer: tests: add tests for raid level case-insensitivity

2024-12-03 Thread Christoph Heiss
aid levels") Signed-off-by: Christoph Heiss --- .../btrfs_raid_level_uppercase.json | 23 ++ .../btrfs_raid_level_uppercase.toml | 15 ++ .../zfs_raid_level_uppercase.json | 30 +++ .../zfs_raid_level_uppercase.toml

[pve-devel] [PATCH installer 1/2] tree-wide: fix rustdoc warnings

2024-12-03 Thread Christoph Heiss
Mostly URLs, which need to be surrounded by < > to be properly formatted. Signed-off-by: Christoph Heiss --- proxmox-auto-install-assistant/src/main.rs | 10 + proxmox-installer-common/src/options.rs | 6 +++--- proxmox-installer-common/src/utils.rs

[pve-devel] [PATCH installer 0/2] fix rustdoc warnings

2024-12-03 Thread Christoph Heiss
Pretty trivial overall, just re-formats some comments in accordance with rustdoc - mostly URLs, which need to be surrounded by < > to be properly recognised/parsed. Christoph Heiss (2): tree-wide: fix `cargo doc` warnings tree-wide: run `cargo fmt` proxmox-auto-install-assistant/src/m

[pve-devel] [PATCH installer 2/2] tree-wide: run `cargo fmt`

2024-12-03 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/options.rs | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs index 6ec7d5c..9720804 100644 --- a/proxmox-installer

Re: [pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Christoph Heiss
On Fri, Nov 29, 2024 at 02:18:25PM +0100, Shannon Sterz wrote: > On Fri Nov 29, 2024 at 2:08 PM CET, Christoph Heiss wrote: > > [..] > > @@ -27,14 +27,13 @@ Mailing Lists > > This is a fast way to communicate with the {pve} community via email. > > > > * Ma

[pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Christoph Heiss
It's been the preferred mailing list archive for some time now. Signed-off-by: Christoph Heiss --- getting-help.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 06a25c2..e53592d 100644 --- a/getting-help.adoc +++ b/ge

[pve-devel] [PATCH installer v2 1/5] proxinstall: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest master * adap

[pve-devel] [PATCH installer v2 5/5] auto: add negative tests for root password option

2024-11-29 Thread Christoph Heiss
Extends our "test runner" for the parse-answer tests such that if a test file ends with ".fail.toml", it is considered a negative test and expected to fail. The expected error message is stored in the accompanying .fail.json file. Signed-off-by: Christoph Heiss --- Chang

[pve-devel] [PATCH pve-docs v2 6/8] installation: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index

[pve-devel] [PATCH installer v2 4/5] auto: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
igned-off-by: Christoph Heiss --- Changes v1 -> v2: * reworked check to use a `match` instead, as suggested by Stefan proxmox-auto-installer/src/utils.rs | 22 +-- .../tests/resources/parse_answer/btrfs.json | 2 +- .../tests/resources/parse_answer/btrfs.tom

[pve-devel] [PATCH proxmox-backup v2 8/8] using-the-installer: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch docs/using-the-installer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/using-the-installer.rst b/docs/u

[pve-devel] [PATCH pmg-docs v2 7/8] installation: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch pmg-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmg-installation.adoc b/pmg-installation.adoc index

[pve-devel] [PATCH installer v2 3/5] common: convert `InstallRootPassword` into an enum

2024-11-29 Thread Christoph Heiss
It's more appropriate for that type of data, since only one of both variants is ever allowed to be set. Makes it also a bit more ergonomic to handle. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch proxmox-auto-installer/src/utils.rs | 15 +++ proxmox-i

[pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v2 0/8] raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
Diffstat pve-installer: Christoph Heiss (5): proxinstall: raise minimum root password length to 8 characters tui: raise minimum root password length to 8 characters common: convert `InstallRootPassword` into an enum auto: raise minimum root password length to 8 characters auto: add negati

[pve-devel] [PATCH installer v2 2/5] tui: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest master * ad

[pve-devel] [PATCH installer] auto: do not allow btrfs as root-fs if not enabled in the setup

2024-11-26 Thread Christoph Heiss
Add a check such that this combination is not possible, if not enabled for the specific iso. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/utils.rs | 13 + 1 file changed, 13 insertions(+) diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer

[pve-devel] [PATCH installer v2 3/6] low-level: stdio: fix: make progress text properly optional

2024-11-25 Thread Christoph Heiss
-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Proxmox/UI/StdIO.pm | 8 +--- .../src/bin/proxmox-auto-installer.rs | 6 +- proxmox-installer-common/src/setup.rs | 2 +- .../src/views/install_progress.rs |

[pve-devel] [PATCH installer v2 2/6] auto: log non-json low-level messages into separate file

2024-11-25 Thread Christoph Heiss
Same as the TUI does, as introduced in [0]. [0] 22de6e5 ("tui: install_progress: write low-level non-JSON messages to separate file") Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes .../src/bin/proxmox-auto-installer.rs | 19 +-- 1 fil

[pve-devel] [PATCH installer v2 6/6] tui: tests: catch EOF from proxmox-low-level-installer early

2024-11-25 Thread Christoph Heiss
ld just be recursively called until the stack overflowed in such a case. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch proxmox-tui-installer/src/views/install_progress.rs | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/proxmox-tui-instal

[pve-devel] [PATCH installer v2 5/6] auto: avoid printing unnecessary progress update lines

2024-11-25 Thread Christoph Heiss
In case the progress message did not contain any text and the percentage did not change, don't print another (useless) line. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * if the percentage was updated w/o any text, reuse the last message .../src/bin/proxmox-auto-inst

[pve-devel] [PATCH installer v2 0/6] small, overall install progress improvements

2024-11-25 Thread Christoph Heiss
> v2: * dropped already-applied patches * rebased on latest master * added new patch #6 Diffstat ==== Christoph Heiss (6): auto, tui: move low-level installer message struct to common crate auto: log non-json low-level messages into separate file low-level: stdio: fix: make progre

[pve-devel] [PATCH installer v2 1/6] auto, tui: move low-level installer message struct to common crate

2024-11-25 Thread Christoph Heiss
.. effectively de-duplicating the struct, which currently is defined in both the auto-installer and the tui-installer separately. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes .../src/bin/proxmox-auto-installer.rs | 5 +- proxmox-auto-installer/src/utils

[pve-devel] [PATCH installer v2 4/6] low-level: add proper message to 100% progress ratio update

2024-11-25 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Proxmox/Install.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index b891383..9074709 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -1460,7 +146

Re: [pve-devel] [PATCH access-control] api, auth: fix two typos in user-visible options description

2024-11-22 Thread Christoph Heiss
v2: https://lore.proxmox.com/pve-devel/20241122102627.521873-1-c.he...@proxmox.com/T/#u On Mon, Oct 21, 2024 at 02:06:17PM +0200, Christoph Heiss wrote: > Signed-off-by: Christoph Heiss > --- > src/PVE/API2/AccessControl.pm | 5 +++-- > src/PVE/Auth/Plugin.pm| 2 +- >

[pve-devel] [PATCH access-control v2] api, auth: fix two typos in user-visible description

2024-11-22 Thread Christoph Heiss
Just two small typos in user-visible API/schema description. Fix them up. Signed-off-by: Christoph Heiss --- v1: https://lore.proxmox.com/pve-devel/20241021120626.1293427-1-c.he...@proxmox.com/ Changes v1 -> v2: * rebased on latest master src/PVE/API2/AccessControl.pm | 2 +- src/PVE/A

[pve-devel] [PATCH installer v2] first-boot: multi-user: start after product-specific API proxy

2024-11-19 Thread Christoph Heiss
that users could even use the API / CLI commands, or write files to pmxcfs (in case of PVE). After= and Wants= ignore non-existent units, so we can just specify all three API proxy units here w/o any conditional. Suggested-by: Shannon Sterz Signed-off-by: Christoph Heiss --- That systemd ignores no

Re: [pve-devel] [PATCH installer] fetch-answer: encode unsafe characters in partition label

2024-11-19 Thread Christoph Heiss
Good catch & thanks for tackeling this! Also tested it with a simple whitespace character. Tested-by: Christoph Heiss Reviewed-by: Christoph Heiss On Tue, Nov 19, 2024 at 03:59:34PM +0100, Filip Schauer wrote: > Ensure potentially unsafe characters in the partition label are

Re: [pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

2024-11-19 Thread Christoph Heiss
On Tue, Nov 19, 2024 at 03:50:47PM +0100, Thomas Lamprecht wrote: > Am 19.11.24 um 15:39 schrieb Christoph Heiss: > > [..] > > diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service > > b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service >

[pve-devel] [PATCH installer] first-boot: multi-user: start after pveproxy.service

2024-11-19 Thread Christoph Heiss
d even use the API / CLI commands, or write files to pmxcfs. Suggested-by: Shannon Sterz Signed-off-by: Christoph Heiss --- proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxmox-first-boot/etc/proxmox-first-

[pve-devel] [PATCH installer] common: fix deserialization of install config

2024-11-19 Thread Christoph Heiss
: Timothy Nicholson Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index fefedf6..1a9a71c 100644 --- a/proxmox-installer

[pve-devel] [PATCH installer v2 1/5] fix #5579: first-boot: add initial service packaging

2024-11-18 Thread Christoph Heiss
that is present. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * changed to three separate services, of which the requested one gets enabled manually, as suggested by Thomas Makefile| 13 ++--- debian/cont

[pve-devel] [PATCH installer v2 5/5] fix #5579: install: setup proxmox-first-boot service if enabled

2024-11-18 Thread Christoph Heiss
The auto-installer will place an executable file named `proxmox-first-boot` in the installer runtime-directory if the user set up. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * factor out of extract_data() * implement enabling correct service depending on set order Prox

[pve-devel] [PATCH installer v2 0/5] fix #5579: allow specifying optional first-boot script

2024-11-18 Thread Christoph Heiss
7;t work, as it is completely product-agnostic. History === v1: https://lore.proxmox.com/pve-devel/20241113135908.1622968-1-c.he...@proxmox.com/ Changes v1 -> v2: * package is only installed when enabled * dropped already applied patches * added option to configure ordering Diffstat

[pve-devel] [PATCH installer v2 3/5] fix #5579: auto-install-assistant: enable baking in first-boot script

2024-11-18 Thread Christoph Heiss
Adds a new parameter `--on-first-boot` to the `prepare-iso` command, to specify a file to bake into the ISO. To later use it with the auto-installer, the following must be set in the answer file: [first-boot] source = "from-iso" Signed-off-by: Christoph Heiss --- Changes v1 ->

[pve-devel] [PATCH installer v2 4/5] fix #5579: auto-installer: add optional first-boot hook script

2024-11-18 Thread Christoph Heiss
ource` key must be at least set, which gives the location of the hook script. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * adapt to new low-level format * add settable ordering of service proxmox-auto-installer/Cargo.toml | 2 +- proxmox-auto-installer/

[pve-devel] [PATCH installer v2 2/5] fix #5579: setup: introduce 'first_boot' low-level installer options

2024-11-18 Thread Christoph Heiss
.. to enable the setup of the 'proxmox-first-boot' service, as well as optionally setting the ordering. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * add tests * introduce `first_boot.enabled` low-level option to tell the installer explicitly about it Proxmox/Inst

[pve-devel] [PATCH installer] fetch-answer, post-hook: rename $format-info to $schema

2024-11-15 Thread Christoph Heiss
'schema' describes the purpose the of this object better and is a more "industry-standard" term. Changes it for both locations where we currently have such an object. Signed-off-by: Christoph Heiss --- No hard feelings though if stay with $format-info if that is indeed

Re: [pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging

2024-11-15 Thread Christoph Heiss
On Fri, Nov 15, 2024 at 02:39:16PM +0100, Thomas Lamprecht wrote: > Am 15.11.24 um 14:34 schrieb Christoph Heiss: > > On Thu, Nov 14, 2024 at 09:23:48PM +0100, Thomas Lamprecht wrote: > >> [..] > >> So it really would be great to allow overriding that ordering. > &g

Re: [pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging

2024-11-15 Thread Christoph Heiss
On Thu, Nov 14, 2024 at 09:23:48PM +0100, Thomas Lamprecht wrote: > [..] > So it really would be great to allow overriding that ordering. > > Simplest way might be to leave it out here, or well go for the default we want > (in doubt -> dice roll), and write out a systemd unit snippet during > inst

[pve-devel] [PATCH installer] auto-installer: fix: add default value for partition-label

2024-11-15 Thread Christoph Heiss
be missing for ISOs prepared with older versions of that tool. Fix it by providing a default label, such that it always has a sensible value. Fixes: 2e89c07 ("auto-install-assistant: add new parameter to specify partition label") Reported-by: Timothy Nicholson Signed-off-by: Christoph

Re: [pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging

2024-11-15 Thread Christoph Heiss
Thanks for chiming in! On Fri, Nov 15, 2024 at 10:49:19AM +0100, Thomas Lamprecht wrote: > Am 15.11.24 um 10:34 schrieb Christoph Heiss: > > [..] > > Should it be an enum then? I.e. only allowing certain values such as > > - network-pre.target > > - network.target

Re: [pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging

2024-11-15 Thread Christoph Heiss
On Thu, Nov 14, 2024 at 09:23:48PM +0100, Thomas Lamprecht wrote: > Am 13.11.24 um 14:59 schrieb Christoph Heiss: > > diff --git a/proxmox-first-boot/etc/proxmox-first-boot.service > > b/proxmox-first-boot/etc/proxmox-first-boot.service > > new file mode 100644 >

Re: [pve-devel] [RFC PATCH installer 4/5] fix #5579: auto-installer: add optional first-boot hook script

2024-11-15 Thread Christoph Heiss
On Thu, Nov 14, 2024 at 09:33:31PM +0100, Thomas Lamprecht wrote: > Am 13.11.24 um 14:59 schrieb Christoph Heiss: > > [..] > > I'd sleep slightly better if we size limit this to something around 1 MiB, or > at max 10 MiB if one really wants to allow a lot of convenience. &g

[pve-devel] [PATCH installer v3 2/2] assistant: avoid regex for simple prefix matching

2024-11-14 Thread Christoph Heiss
assistant-after No functional changes. Reviewed-By: Aaron Lauterer Tested-By: Aaron Lauterer Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest master Changes v2 -> v3: * rebased on latest master proxmox-auto-install-assistant/src/main.r

[pve-devel] [PATCH installer v3 0/2] assistant: clean up glob patterns & regexes

2024-11-14 Thread Christoph Heiss
tches Changes v1 -> v2: * rebased on latest master Christoph Heiss (2): tree-wide: run rustfmt, fix clippy warnings assistant: avoid regex for simple prefix matching proxmox-auto-install-assistant/src/main.rs | 61 +--- proxmox-auto-installer/tests/parse-answer.rs | 2 +

[pve-devel] [PATCH installer v3 1/2] tree-wide: run rustfmt, fix clippy warnings

2024-11-14 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Changes v2 -> v3: * rebased on latest master, mostly new (mechanical) changes proxmox-auto-install-assistant/src/main.rs | 4 ++-- proxmox-auto-installer/tests/parse-answer.rs | 2 +- p

[pve-devel] [RFC PATCH installer 0/5] fix #5579: allow specifying optional first-boot script

2024-11-13 Thread Christoph Heiss
(8.2-2) PVE ISO, both baking it into the ISO and fetching it from an URL. Did not test with PBS explicitly (yet), but I see no reason why it shouldn't work, as it is completely product-agnostic. Diffstat Christoph Heiss (5): common: add function for issuing HTTP GET requests

[pve-devel] [RFC PATCH installer 4/5] fix #5579: auto-installer: add optional first-boot hook script

2024-11-13 Thread Christoph Heiss
ource` key must be at least set, which gives the location of the hook script. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/Cargo.toml | 2 +- proxmox-auto-installer/src/answer.rs | 27 .../src/bin/proxmox-auto-installer.rs

[pve-devel] [RFC PATCH installer 1/5] common: add function for issuing HTTP GET requests

2024-11-13 Thread Christoph Heiss
ffect anything. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/http.rs | 71 +++- 1 file changed, 48 insertions(+), 23 deletions(-) diff --git a/proxmox-installer-common/src/http.rs b/proxmox-installer-common/src/http.rs index b754ed8..f4afe14 100644

[pve-devel] [RFC PATCH installer 5/5] fix #5579: install: copy over `proxmox-first-boot` script if present

2024-11-13 Thread Christoph Heiss
indeed the very first boot of the new system and should run. Signed-off-by: Christoph Heiss --- Proxmox/Install.pm | 20 1 file changed, 20 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 5c64c3d..f46d86a 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/

[pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging

2024-11-13 Thread Christoph Heiss
that is present. Signed-off-by: Christoph Heiss --- Makefile | 13 ++--- debian/control | 7 +++ debian/proxmox-first-boot.install| 1 + debian/rules.proxmox-first-boot | 13

[pve-devel] [RFC PATCH installer 3/5] fix #5579: auto-install-assistant: enable baking in first-boot script

2024-11-13 Thread Christoph Heiss
Adds a new parameter `--on-first-boot` to the `prepare-iso` command, to specify a file to bake into the ISO. To later use it with the auto-installer, the following must be set in the answer file: [first-boot] source = "from-iso" Signed-off-by: Christoph Heiss --- proxmox-au

[pve-devel] [PATCH installer] fetch-answer: add `$fetchinfo` meta-field to HTTP POST payload

2024-11-13 Thread Christoph Heiss
"$fetchinfo": { "version": "1.0" }, "product": .., .. } [0] https://lore.proxmox.com/pve-devel/20241112145405.929194-1-c.he...@proxmox.com/ Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/sysinfo.rs | 5

[pve-devel] [PATCH installer v2] post-hook: add `$hook` field describing document schema version

2024-11-12 Thread Christoph Heiss
lly introducing the post-hook functionality in [0]. [0] https://lore.proxmox.com/pve-devel/00019f8d-e4f2-420e-892a-b89e8b886...@proxmox.com/ Suggested-by: Thomas Lamprecht Signed-off-by: Christoph Heiss --- v1: https://lore.proxmox.com/pve-devel/20241112131815.670475-2-c.he...@proxmox.com/ C

[pve-devel] [PATCH docs] installation: document advanced btrfs options

2024-11-12 Thread Christoph Heiss
Also includes the new `compress` option that has been recently introduced in the installer. Signed-off-by: Christoph Heiss --- The `compress` option will only be included starting with the next (8.3) ISO release, FWIW. I can leave it out for later if preferred, but a newer pve-docs will

Re: [pve-devel] [PATCH installer] post-hook: add `$version` field describing document schema version

2024-11-12 Thread Christoph Heiss
On Tue, Nov 12, 2024 at 02:44:48PM +0100, Thomas Lamprecht wrote: > Am 12.11.24 um 14:18 schrieb Christoph Heiss: > > [..] > > --- a/proxmox-post-hook/src/main.rs > > +++ b/proxmox-post-hook/src/main.rs > > @@ -133,6 +133,17 @@ struct CpuInfo { > > #[derive(Se

[pve-devel] [PATCH installer] post-hook: add `$version` field describing document schema version

2024-11-12 Thread Christoph Heiss
esn't make much sense in this context. This was suggested by Thomas when originally introducing the post-hook functionality in [0]. [0] https://lore.proxmox.com/pve-devel/00019f8d-e4f2-420e-892a-b89e8b886...@proxmox.com/ Suggested-by: Thomas Lamprecht Signed-off-by: Christoph Heiss --- pr

[pve-devel] [PATCH installer] tree-wide: add serde `derive` where actually needed

2024-11-12 Thread Christoph Heiss
Fixes building each crate on their own. In a full build (e.g. `make deb`), everything pulls in serde with the `derive` feature anyway and thus does not exihibit any build failures. Signed-off-by: Christoph Heiss --- Only noticed this by pure chance while using `cargo test -p proxmox-tui

[pve-devel] [PATCH installer] tui: tests: fix reading ui messages from low-level installer

2024-11-12 Thread Christoph Heiss
progression code does it. Fixes: 723afe2 ("run env: always re-create run env file in test mode") Signed-off-by: Christoph Heiss --- .../src/views/install_progress.rs | 34 +++ 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/proxmox-tui-installer

Re: [pve-devel] applied: [PATCH installer v4 00/12] fix #5536: implement post-(auto-)installation notification mechanism

2024-11-12 Thread Christoph Heiss
On Mon, Nov 11, 2024 at 06:41:15PM +0100, Thomas Lamprecht wrote: > Am 11.11.24 um 14:14 schrieb Christoph Heiss: > > This implements a mechanism for post-installation "notifications" via a > > POST request [0] when using the auto-installer. > > [..] > >

Re: [pve-devel] [RFC PATCH installer] buildsys: add static version of proxmox-auto-install-assistant

2024-11-12 Thread Christoph Heiss
On Mon, Nov 11, 2024 at 11:31:05PM +0100, Thomas Lamprecht wrote: > Am 16.08.24 um 18:19 schrieb Christoph Heiss: > > This adds a separate debian package to the build, containing a > > statically-built version of `proxmox-auto-install-assistant`, as > > was suggested in #

[pve-devel] [PATCH installer v4 02/12] fetch-answer: move http-related code to gated module in installer-common

2024-11-11 Thread Christoph Heiss
This enable reusage of this code in other crates. Needed esp. by the upcoming post-installation notification hook functionality. No functional changes overall. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v2 -> v3: * no changes Changes v1

[pve-devel] [PATCH installer v4 11/12] fix #5536: post-hook: add utility for sending notifications after auto-install

2024-11-11 Thread Christoph Heiss
This utility can be called with the low-level install config after a successful installation to send a notification via a HTTP POST request, if the user has configured an endpoint for that in the answer file. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -&

[pve-devel] [PATCH installer v4 08/12] auto-installer: answer: factor out answer file reading into function

2024-11-11 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * new patch, split out from later patch proxmox-auto-installer/src/answer.rs | 16 +++- .../src/bin/proxmox-auto-installer.rs| 11 +-- 2 files chang

[pve-devel] [PATCH installer v4 00/12] fix #5536: implement post-(auto-)installation notification mechanism

2024-11-11 Thread Christoph Heiss
"b8737afea804482697ffe04db69c73d1", "disks": [ { "size": 8589934592, "is-bootdisk": true, "udev-properties": { "DEVNAME": "/dev/vda", [..] } }, { "size": 8589934592, "udev-properties

[pve-devel] [PATCH installer v4 07/12] auto-installer: move `SystemDMI` struct to common crate

2024-11-11 Thread Christoph Heiss
This functionality will be reused by the post-hook, which sends this data as part of its information set. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * new patch proxmox-auto-installer/src/sysinfo.

[pve-devel] [PATCH installer v4 03/12] tree-wide: convert some more crates to use workspace dependencies

2024-11-11 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * no changes Cargo.toml| 4 proxmox-auto-install-assistant/Cargo.toml | 13 +++-- pro

[pve-devel] [PATCH installer v4 09/12] auto-installer: udevinfo: introduce type alias for udev properties

2024-11-11 Thread Christoph Heiss
Makes handling & passing them around a bit more convenient. Will be used in the upcoming proxmox-post-hook utility. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * new patch, split out from later patch proxmox-auto-installer/src/udevi

[pve-devel] [PATCH installer v4 10/12] fix #5536: auto-installer: answer: add `posthook` section

2024-11-11 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * no changes proxmox-auto-installer/src/answer.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-auto-installer/src/answer.rs b/pro

[pve-devel] [PATCH installer v4 04/12] auto-install-assistant: replace `PathBuf` parameters with `AsRef`

2024-11-11 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * new patch, suggestion by Stefan proxmox-auto-install-assistant/src/main.rs | 23 +- 1 file changed, 14 insertions(+), 9 deletions(-) dif

  1   2   3   4   5   6   7   8   >