This idea came to light while talking with Shannon about #5756 [0]. It is 2024, so raising the minimum length for the root password as entered during the installation from 5 to 8 characters seems very sensible. NIST also recommends a minimum length of 8 characters for passwords [1].
See also the respective patches for PVE/PMG [2] and PBS [3] - both series have been already applied. I've sent the documentation patches all together with this series, since a) they are trivial, b) not to clutter the other mailing list and c) to keep everything together for review. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5756 [1] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver [2] https://lore.proxmox.com/pve-devel/20241004133205.258755-1-s.st...@proxmox.com/ [3] https://lore.proxmox.com/pbs-devel/20241004134054.263913-1-s.st...@proxmox.com/ History ======= v1: https://lore.proxmox.com/pve-devel/20241007092218.723938-1-c.he...@proxmox.com/ Notable changes v1 -> v2: * rebased on latest master * new patch #3; converting `InstallRootPassword` to an enum * new patch #5; negative tests * new patches #6 through #8: respective documentation updates Diffstat ======== pve-installer: Christoph Heiss (5): proxinstall: raise minimum root password length to 8 characters tui: raise minimum root password length to 8 characters common: convert `InstallRootPassword` into an enum auto: raise minimum root password length to 8 characters auto: add negative tests for root password option Proxmox/Sys.pm | 5 +++ html/pbs/passwd.htm | 2 +- html/pmg/passwd.htm | 2 +- html/pve/passwd.htm | 2 +- proxinstall | 7 +++- proxmox-auto-installer/src/utils.rs | 37 +++++++++++++------ proxmox-auto-installer/tests/parse-answer.rs | 22 +++++++++-- .../both-password-and-hashed-set.fail.json | 3 ++ .../both-password-and-hashed-set.fail.toml | 15 ++++++++ .../tests/resources/parse_answer/btrfs.json | 2 +- .../tests/resources/parse_answer/btrfs.toml | 2 +- .../resources/parse_answer/disk_match.json | 2 +- .../resources/parse_answer/disk_match.toml | 2 +- .../parse_answer/disk_match_all.json | 2 +- .../parse_answer/disk_match_all.toml | 2 +- .../parse_answer/disk_match_any.json | 2 +- .../parse_answer/disk_match_any.toml | 2 +- .../resources/parse_answer/first-boot.json | 2 +- .../resources/parse_answer/first-boot.toml | 2 +- .../tests/resources/parse_answer/minimal.json | 2 +- .../tests/resources/parse_answer/minimal.toml | 2 +- .../resources/parse_answer/nic_matching.json | 2 +- .../resources/parse_answer/nic_matching.toml | 2 +- .../no-root-password-set.fail.json | 3 ++ .../no-root-password-set.fail.toml | 13 +++++++ .../parse_answer/short-password.fail.json | 3 ++ .../parse_answer/short-password.fail.toml | 14 +++++++ .../resources/parse_answer/specific_nic.json | 2 +- .../resources/parse_answer/specific_nic.toml | 2 +- .../tests/resources/parse_answer/zfs.json | 2 +- .../tests/resources/parse_answer/zfs.toml | 2 +- proxmox-installer-common/src/lib.rs | 3 ++ proxmox-installer-common/src/setup.rs | 15 ++++---- proxmox-tui-installer/src/main.rs | 10 +++-- proxmox-tui-installer/src/setup.rs | 5 +-- 35 files changed, 145 insertions(+), 52 deletions(-) create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/both-password-and-hashed-set.fail.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/both-password-and-hashed-set.fail.toml create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/no-root-password-set.fail.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/no-root-password-set.fail.toml create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/short-password.fail.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/short-password.fail.toml pve-docs: Christoph Heiss (1): installation: adapt to raised root password length requirement pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pmg-docs: Christoph Heiss (1): installation: adapt to raised root password length requirement pmg-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) proxmox-backup: Christoph Heiss (1): using-the-installer: adapt to raised root password length requirement docs/using-the-installer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.46.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
