[pve-devel] [PATCH manager v2] fix #4281: manager: Enabled logging in with Open ID

2025-04-30 Thread Alexander Abraham
Made the neccessary changes to enable users to login with their Open ID provider from the mobile view of the PVE web frontend. Signed-off-by: Alexander Abraham --- www/mobile/Login.js | 146 ++-- 1 file changed, 114 insertions(+), 32 deletions(-) diff --g

[pve-devel] [PATCH proxmox_login_manager v2] fix #6231: Removed whitespace-trimming from password entry field

2025-04-30 Thread Alexander Abraham
The whitespace-trimming was removed for the password field in the login form to allow users to also use spaces in their passwordsThe whitespace-trimming was removed for the password field in the login form to allow users to also use spaces in their passwords. Signed-off-by: Alexander Abraham ---

Re: [pve-devel] [RFC storage 0/3] rbd: use image-/snap-spec instead of --pool/..

2025-04-30 Thread Aaron Lauterer
Tested this patch series by: * create a new VM on ceph RBD * took & removed snapshot (with memory) * cloned VM * converted to template (rename from vm-… to base-… worked) * created linked clone * destroy template -> fail due to linked clone * destroy linked clone * destroy template namespace tes

[pve-devel] applied: [PATCH container v2] net: do not force network interface down if `link_down` is 0

2025-04-30 Thread Fabian Grünbichler
On Wed, 30 Apr 2025 14:52:24 +0200, Christoph Heiss wrote: > Reported in the forum [0]. > > Currently, the (host) interface is always forced down if the property is > set. Check the actual (boolean) value and honor the users request if set > to `0` aka. off. > > [0] > https://forum.proxmox.com/

[pve-devel] [PATCH container v2] net: do not force network interface down if `link_down` is 0

2025-04-30 Thread Christoph Heiss
Reported in the forum [0]. Currently, the (host) interface is always forced down if the property is set. Check the actual (boolean) value and honor the users request if set to `0` aka. off. [0] https://forum.proxmox.com/threads/bug-container-network-card-turned-off.160691/ Fixes: 9e56948 ("net:

Re: [pve-devel] [PATCH container] net: do not force network interface down if `link_down` is to 0

2025-04-30 Thread Christoph Heiss
On Wed Apr 30, 2025 at 2:24 PM CEST, Fabian Grünbichler wrote: > On April 30, 2025 1:19 pm, Christoph Heiss wrote: >> Reported in the forum [0]. >> >> Currently, the (host) interface is always forced down if the property is >> set. Check the actual (boolean) value and honor the users request if set

Re: [pve-devel] [PATCH container] net: do not force network interface down if `link_down` is to 0

2025-04-30 Thread Fabian Grünbichler
On April 30, 2025 1:19 pm, Christoph Heiss wrote: > Reported in the forum [0]. > > Currently, the (host) interface is always forced down if the property is > set. Check the actual (boolean) value and honor the users request if set > to `0` aka. off. > > [0] > https://forum.proxmox.com/threads/bu

[pve-devel] [PATCH installer 1/2] assistant: validate: warn if answer file contains old snake_case keys

2025-04-30 Thread Christoph Heiss
Parses the TOML file as a `Value` without structure and then just iterates over all keys. An exception is made for filter values, as these contain raw udev key names. Signed-off-by: Christoph Heiss --- Essentially a bit more robust version of https://lore.proxmox.com/pve-devel/20250217121748.117

[pve-devel] [RFC PATCH for-9.0 installer 2/2] auto: answer: drop deprecated snake_case keys

2025-04-30 Thread Christoph Heiss
This has been deprecated in PVE 8.4-1 and PBS 3.4-1, respectively. No PMG release to date with this change. The kebab-case style is preferred for all new things. Migration for users is pretty simple, for both hand-written answer files as well as on-the-fly generated ones by automated provisioning

[pve-devel] [PATCH container] net: do not force network interface down if `link_down` is to 0

2025-04-30 Thread Christoph Heiss
Reported in the forum [0]. Currently, the (host) interface is always forced down if the property is set. Check the actual (boolean) value and honor the users request if set to `0` aka. off. [0] https://forum.proxmox.com/threads/bug-container-network-card-turned-off.160691/ Fixes: 9e56948 ("net:

Re: [pve-devel] [PATCH ha-manager 09/15] manager: apply colocation rules when selecting service nodes

2025-04-30 Thread Daniel Kral
On 3/25/25 16:12, Daniel Kral wrote: sub select_service_node { -my ($groups, $online_node_usage, $sid, $service_conf, $current_node, $try_next, $tried_nodes, $maintenance_fallback, $best_scored) = @_; +# TODO Cleanup this signature post-RFC +my ($rules, $groups, $online_node_usage,

[pve-devel] [PATCH manager] fix #4166: restore: add resource pool selector

2025-04-30 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/window/Restore.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 22900868..8d6dfabe 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window/Res

Re: [pve-devel] [PATCH manager 1/1] fix #4281: manager: Enabled logging in with Open ID

2025-04-30 Thread Christoph Heiss
The commit message title should always be in present tense (handy shortcut to remember: the commit/patch will *change* it, but it hasn't been changed *before* the commit/patch). Applies to the other patches in the series as well - see also our developer documentation on that matter [0]. On Tue Ap