The commit message title should always be in present tense (handy shortcut to remember: the commit/patch will *change* it, but it hasn't been changed *before* the commit/patch).
Applies to the other patches in the series as well - see also our developer documentation on that matter [0]. On Tue Apr 29, 2025 at 5:07 PM CEST, Alexander Abraham wrote: > This commit adds an authorization flow for logging > in a user using Open ID on the PVE web frontend in > the mobile view. "This commit [..]" is redundant, since the context is already clear :^) Didn't really review the patch further, so if there's some other important detail, it should be mentioned as well. [0] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages > > Signed-off-by: Alexander Abraham <a.abra...@proxmox.com> > --- > www/mobile/Login.js | 148 ++++++++++++++++++++++++++++++++++---------- > 1 file changed, 116 insertions(+), 32 deletions(-) > > diff --git a/www/mobile/Login.js b/www/mobile/Login.js > index 06c8b3d4..05038036 100644 > --- a/www/mobile/Login.js > +++ b/www/mobile/Login.js > @@ -1,8 +1,10 @@ > +/ > https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/manager6/Workspace.js;h=922e01df86718e8fc89ce5835f81d21f6d849b81;hb=HEAD > + Unintentional copy-paste I assume? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
