On 4/2/25 22:09, Thomas Lamprecht wrote:
Am 12.03.25 um 14:27 schrieb Dominik Csapak:
In some situations, e.g. having a large resource mapping, the UI can
generate a request that is bigger than the current limit of 64KiB.
Our files in pmxcfs can grow up to 1 MiB, so theoretically, a single
mapp
--- Begin Message ---
>>- we should probably move the decision whether a snapshot is done on
>>the storage layer or by qemu into the control of the storage plugin,
>>especially since we are currently cleaning that API up to allow
>>easier implementation of external plugins
Agree with that indeed,
--- Begin Message ---
> >
> > > > > and
> > > probably $backing should not be an arbitrary path, but something
> > > that
> > > is resolved locally?
>
> I'll send the $snapname as param instead
>>see my comments on the qemu-server side, I think it would be even
>>better if we could just get rid
Suggested-by: Wolfgang Bumiller
Signed-off-by: Fiona Ebner
---
pve-backup.c | 62
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/pve-backup.c b/pve-backup.c
index 915649b5f9..88a981f81c 100644
--- a/pve-backup.c
+++ b/pve-back
--- Begin Message ---
In my case I provision VMs using Terraform and Ignition and the only way to do
it it to set
-fw_cfg with giant inline JSON. At first it was fine, but now my config exceeded
~40Kb and I faced with this issue. This patch helped, hope this will be fixed.
12.03.2025 14:27, Domi
- Display the values and descriptions as a table.
`auto`:
- Rephrase the description so that the focus is on the recommended
"notification-system" mode. This also fixes the incorrectly duplicated
"if no email address is entered".
- Emphasize "Send email to".
`legacy-sendmail`:
- s/version/ver
On Tue Apr 1, 2025 at 10:40 AM CEST, Fabian Grünbichler wrote:
> CCing Fiona in case of further input w.r.t. export/import things
>
> On March 26, 2025 3:20 pm, Max Carrara wrote:
> > Adapt the previous description, slightly rewording it and formatting
> > it for POD under the IMPORTS AND EXPORTS s
On Mon Mar 31, 2025 at 5:12 PM CEST, Fabian Grünbichler wrote:
> On March 26, 2025 3:20 pm, Max Carrara wrote:
> > Add docstrings for the following methods:
> > - check_connection
> > - activate_storage
> > - deactivate_storage
> > - status
> > - cluster_lock_storage
> > - parse_volname
> > - get_s
On Mon Mar 31, 2025 at 5:12 PM CEST, Fabian Grünbichler wrote:
> On March 26, 2025 3:20 pm, Max Carrara wrote:
> > Add documentation for the following methods:
> > - list_images
> > - create_base
> > - clone_image
> > - alloc_image
> > - free_image
> >
> > Signed-off-by: Max Carrara
> > Co-author
On Mon Mar 31, 2025 at 5:13 PM CEST, Fabian Grünbichler wrote:
> On March 26, 2025 3:20 pm, Max Carrara wrote:
> > Add PVE::Storage::PluginBase, which defines stubs for all methods that
> > storage plugins should implement in order to conform to our plugin
> > API. This makes it much easier for (th
On Mon Mar 31, 2025 at 5:13 PM CEST, Fabian Grünbichler wrote:
> On March 26, 2025 3:20 pm, Max Carrara wrote:
> > Add a short paragraph in DESCRIPTION serving as an introduction as
> > well as the GENERAL PARAMETERS and CACHING EXPENSIVE OPERATIONS
> > sections.
> >
> > These sections are added i
On 3/31/25 15:59, Philipp Giersfeld wrote:
This patch series adds support for AMD SEV-SNP.
Where possible it mimics the existing support for AMD SEV(-ES).
Running SEV-SNP VMs requires a specific OVMF firmware image. Contrary to
other setups, SEV-SNP does not support loading the firmware via pfla
Applied the series, but I undid the removal of the `restart:` goto-style
error handling and instead renamed it to 'fail', since we'd otherwise
copy the exact same function call into multiple locations which later
becomes its own extra helper function specifically for this one purpose,
which is now
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Save the fabrics configuration in the running configuration, when
> applying the SDN configuration. This causes the FRR configuration to
> be actually generated for the openfabric and ospf plugins, since the
> FRR config
Thanks for the feedback.
On 2025-04-02 15:14, Fabian Grünbichler wrote:
On March 4, 2025 12:57 pm, Markus Frank wrote:
Adds a config file for directories by using a 'map' property string for
each node mapping.
Next to node & path, there is the optional announce-submounts parameter
which force
Hi, I tried v7 very quickly with the backup-provider-dir-example
storage. Some minor things I noticed below, IMO nothing that can't be
fixed in follow-ups.
Note that I didn't look too closely how the backup provider API really
works, so some of the following may just be consequences of the example
I tested this in a 4-node Squid cluster, one thing I noticed:
- after selecting a pool in the GUI and creating a namespace, the
namespace panel is greyed out and I get a spinning wheel with the error
message
> rbd error: Ensure that the default pool has been created or specify an
alternate pool n
On 4/2/25 12:36, Laurențiu Leahu-Vlăducu wrote:
Is it a good idea to use cache=auto by default? I know that "cache=auto"
is the upstream default, but I was wondering whether it's not safer to
use "never" by default in PVE to minimize the amount of potential
issues. Feel free to contradict me, t
On Tue Apr 1, 2025 at 7:34 PM CEST, Fiona Ebner wrote:
> The new_backup_provider() method can be used by storage plugins for
> external backup providers. If the method returns a provider, Proxmox
> VE will use callbacks to that provider for backups and restore instead
> of using its usual backup/re
On 3/4/25 12:57, Markus Frank wrote:
Virtio-fs is a shared file system that enables sharing a directory
between host and guest VMs. It takes advantage of the locality of
virtual machines and the hypervisor to get a higher throughput than
the 9p remote file system protocol.
build-order:
1. cluste
Some comments inline, with those addressed consider this as:
Reviewed-by: Daniel Kral
On 3/4/25 12:57, Markus Frank wrote:
Signed-off-by: Markus Frank
---
v14:
* addressed formulation nits
* added paragraph about expose-acl & expose-xattr
qm.adoc | 99 ++
Some smaller higher level comments inline.
Else the patch looks good to me and with those addressed, consider this as:
Reviewed-by: Daniel Kral
Tested-by: Daniel Kral
On 3/4/25 12:58, Markus Frank wrote:
Signed-off-by: Markus Frank
---
v14:
* disable expose-xattr when expose-acl is set
* ad
One comment inline, else LGTM and with this addressed consider this as:
Reviewed-by: Daniel Kral
On 3/4/25 12:58, Markus Frank wrote:
Signed-off-by: Markus Frank
---
v14:
* return HTML encoded comment
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 10 +
www
One small comment inline.
Tested the obvious cases:
- trying to add multiple map entries with the same node for the same
dirid results in an error in the WebGUI
- adding multiple map entries manually in the file for a dirid will make
the VM fail to start with an error indicating that there are
> Alexandre Derumier via pve-devel hat am
> 11.03.2025 11:28 CET geschrieben:
> Look at qdev value, as cdrom drives can be empty
> without any inserted media
>
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer.pm | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>
other than the comments on individual patches nothing here jumped out at
me for the backend part, I haven't looked at the front-end.
some things that would be nice to consider/follow-up with:
- add a hotplug feature (set up all the machinery, even if no virtiofs
is configured yet, then add/remov
On March 4, 2025 12:57 pm, Markus Frank wrote:
> add dir mapping checks to check_local_resources
>
> Since the VM needs to be powered off for migration, migration should
> work with a directory on shared storage with all caching settings.
>
> Signed-off-by: Markus Frank
> Reviewed-by: Fiona Ebne
On March 4, 2025 12:57 pm, Markus Frank wrote:
> Signed-off-by: Markus Frank
> ---
> v14:
> * addressed formulation nits
> * added paragraph about expose-acl & expose-xattr
>
> qm.adoc | 99 +++--
> 1 file changed, 97 insertions(+), 2 deletions
On April 2, 2025 2:20 pm, Stefan Hanreich wrote:
>
>
> On 4/2/25 12:41, Fabian Grünbichler wrote:
>>> +code => sub {
>>> + my ($param) = @_;
>>> + my $rpcenv = PVE::RPCEnvironment::get();
>>> +
>>> + my $running = extract_param($param, 'running');
>>> + my $pending = extract_param($pa
On 4/2/25 12:41, Fabian Grünbichler wrote:
>> +code => sub {
>> +my ($param) = @_;
>> +my $rpcenv = PVE::RPCEnvironment::get();
>> +
>> +my $running = extract_param($param, 'running');
>> +my $pending = extract_param($param, 'pending');
>> +
>> +my $fabric_config = PVE::Ne
This task name is used by the SDN stack when applying the configuration,
i.e. reloading the network configuration completely on all cluster
nodes.
Signed-off-by: Christoph Heiss
---
www/manager6/Utils.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Uti
Hello,
looks good to me.
On 2025-03-31 15:59, Philipp Giersfeld wrote:
Expand input panel with AMD SEV-SNP selection, and relevant optional
parameters similar to existing options for AMD SEV(-ES).
Further, upon selecting AMD SEV-SNP, issue a warning that EFI disks are
not included when using
On 4/2/25 12:41, Fabian Grünbichler wrote:
> On March 28, 2025 6:13 pm, Gabriel Goller wrote:
>> From: Stefan Hanreich
>>
>> Add functions that allow reading and manipulating values in the
>> /etc/frr/daemons file. We need this for en/disabling daemons depending
>> on which fabric types are config
Hi, two comments inline:
On 28/03/2025 18:13, Gabriel Goller wrote:
> TreeView that shows all the fabrics and nodes in a hierarchical
> structure. It also shows all the pending changes from the
> running-config.
>
> We decided against including all the interfaces (as children of nodes)
> because
Am 02.04.25 um 12:01 schrieb Max Carrara:
>> +use base qw(PVE::BackupProvider::Plugin::Base);
> You can `use parent ...` here, as that's more lightweight. `base` is
> fine too though.
>
> See: https://perldoc.perl.org/parent
>
> Only difference is that `use parent ...` doesn't support the `fi
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Add a new subfolder that contains the API methods for the sdn
> fabrics. We also add a method for listing all fabrics of all types as
> a GET endpoint, with the respective schemas. It supports the same
> filtering option
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Since the perlmod API for both the openfabric and ospf are the same,
> add helpers for all CRUD operations that will be supported by the
> openfabric and ospf endpoints, so they can share the same code.
>
> Signed-off-b
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Add functions that allow reading and manipulating values in the
> /etc/frr/daemons file. We need this for en/disabling daemons depending
> on which fabric types are configured. We only enable daemons which are
> required
some high level comments, see below for details though I haven't
repeated them for all instances:
- lots of schema duplication
- lots of string types without formats
- no indices, but this is a two-level deep nested router with path
parameters/child links..
- ACL paths referenced are not yet vali
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Add CRUD endpoints for the ospf fabric and node section types.
same comments as for the openfabrics one apply here as well..
>
> Signed-off-by: Stefan Hanreich
> Co-authored-by: Gabriel Goller
> Signed-off-by: Gabri
On March 28, 2025 6:13 pm, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> Reloading the FRR configuration failed, because outfunc was defined as
> an empty hash, but Tools.pm requires it to be a CODE reference, so the
> following error has been thrown on FRR reload:
>
> Not a CODE reference
Thanks for working on this awesome feature! I tested it with Debian 12
and Windows Server 2025 VMs and it worked really well.
This patch series LGTM and can be merged very soon, IMO.
I wrote some further comments as answers to the other patches.
For the whole series, please consider:
Tested-
I think the docs should also - at least shortly - mention that:
1. The directory is only mounted temporarily and does not persist after
a restart.
2. The reasoning behind this decision.
3. How to mount permanently, if still desired (despite the reasoning
from point 2).
Other popular virtual
On 02/04/2025 12:04, Gabriel Goller wrote:
> On 02.04.2025 11:26, Friedrich Weber wrote:
>>> + commonColumns: [
>>> + {
>>> + text: gettext('Status'),
>>> + dataIndex: 'status',
>>> + width: 30,
>>> + renderer: function(value, metaData, record) {
>>> + let i
On Tue Apr 1, 2025 at 7:34 PM CEST, Fiona Ebner wrote:
> Hard-coding a list of sensitive properties means that custom plugins
> cannot define their own sensitive properties for the on_add/on_update
> hooks.
>
> Have plugins declare the list of their sensitive properties in the
> plugin data. For ba
On 02.04.2025 11:26, Friedrich Weber wrote:
+commonColumns: [
+ {
+ text: gettext('Status'),
+ dataIndex: 'status',
+ width: 30,
+ renderer: function(value, metaData, record) {
+ let icon = record.data.statusIcon || '';
+
[snip]
+Name:: This is the name of the OpenFabric fabric and can be at most 8
characters long.
+
+Loopback Prefix:: CIDR (IPv4 or IPv6) network range (e.g., 10.0.0.0/24) used
to verify that
+all router-IDs in the fabric are contained within this prefix.
+
+Hello Interval:: Controls how frequentl
On Wed Apr 2, 2025 at 11:09 AM CEST, Gabriel Goller wrote:
[..]
>>> +Interfaces:: Specify the interfaces used to establish peering connections
>>> with
>>> +other OpenFabric nodes. Preferably select interfaces without pre-assigned
>>> IP
>>> +addresses, then configure addresses in the IPv4/IPv6 c
Some comments inline - did the review mostly in tandem with testing the
UI, to get a better context.
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote:
[..]
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 74728c8320e9..68f7be8d6042 100644
> --- a/www/manager6/dc
Hi, one minor comment inline:
On 28/03/2025 18:13, Gabriel Goller wrote:
> Implements a shared interface selector panel for openfabric and ospf fabrics.
> This GridPanel combines data from two sources: the node network interfaces
> (/nodes//network) and the fabrics section configuration, displayin
Am 01.04.25 um 19:34 schrieb Fiona Ebner:
> + my $convert_opts = {
> + bwlimit => $options->{bwlimiit},
There's a typo here :/
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/
On 02.04.2025 10:49, Christoph Heiss wrote:
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote:
[..]
+
+Installation
+
+
+We use the FRR implementations of OpenFabric and OSPF, so first you need to
+install `frr` and the `frr-pythontools` package:
Rather try to avoid first-pe
Applied all the patches and built all the crates. Unit tests and clippy
look good.
Only really looked at patch #2 ("network-types: add hostname type") in
the series, as all others are just code moves.
Please consider the entire series:
Reviewed-by: Christoph Heiss
On Tue Apr 1, 2025 at 4:52 PM
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote:
[..]
> +
> +Installation
> +
> +
> +We use the FRR implementations of OpenFabric and OSPF, so first you need to
> +install `frr` and the `frr-pythontools` package:
Rather try to avoid first-person, as per our style guide [0].
C
On Mon Mar 31, 2025 at 10:06 AM CEST, Fiona Ebner wrote:
> Am 28.03.25 um 18:12 schrieb Max Carrara:
> > - What would be the preferred way to allow specifying whether a
> > (custom) plugin is shared or not via our API?
> >
> > E.g. some external plugins do the following, which (I suppose)
> >
Am 01.04.25 um 20:21 schrieb Thomas Lamprecht:
> Am 01.04.25 um 18:02 schrieb Andreas Rogge:
>>> The backup provider gives a path to the disk image that will be
>>> restored. The path needs to be something 'qemu-img' can deal with,
>>> e.g. can also be an NBD URI or similar.
>> Um... that has nothi
On Tue, Apr 01, 2025 at 08:21:30PM +0200, Thomas Lamprecht wrote:
> Hi!
>
> Am 01.04.25 um 18:02 schrieb Andreas Rogge:
> > sorry for digging up that ancient mail, but I feel that's the best
> > starting point for me.
>
> For more current discussion it might be best to check out the recently
> p
> DERUMIER, Alexandre hat am 02.04.2025
> 10:01 CEST geschrieben:
>
>
> >
> > @@ -716,7 +721,11 @@ sub filesystem_path {
> >
> > my $dir = $class->get_subdir($scfg, $vtype);
> >
> > - $dir .= "/$vmid" if $vtype eq 'images';
> > + if ($scfg->{snapext} && $snapname) {
> > + $na
> Alexandre Derumier via pve-devel hat am
> 11.03.2025 11:29 CET geschrieben:
> We need to define name-nodes for all backing chain images,
> to be able to live rename them with blockdev-reopen
>
> For linked clone, we don't need to definebase image(s) chain.
> They are auto added with #block
This commit moves some IP address and MAC address types from
proxmox-ve-config to proxmox, so they can be used re-used across our
code base.
The code in this commit is mostly the same as in proxmox-ve-config
('bc9253d8'), but I have made a few changes:
* Added additional documentation to some of
Am 02.04.25 um 08:20 schrieb Prashant Patil:
> Basically, the backup/restore tasks will be managed through our backup
> solution. So, all we needed is VM config which can be fetched through PVE
> REST API and a API to get access to consistent disk image which can be then
> transferred to backup
61 matches
Mail list logo
