On Mon Mar 31, 2025 at 10:06 AM CEST, Fiona Ebner wrote: > Am 28.03.25 um 18:12 schrieb Max Carrara: > > - What would be the preferred way to allow specifying whether a > > (custom) plugin is shared or not via our API? > > > > E.g. some external plugins do the following, which (I suppose) > > wasn't originally part of the API, but is now, due it being used in > > the wild: > > > > push @PVE::Storage::Plugin::SHARED_STORAGE, 'some-custom-plugin'; > > > > Would be open for any suggestions on how to support this properly! > > Perhaps as a flag in `plugindata()`? > > Yes, could be done as a storage feature [0]. > > > - Should we allow custom plugins to define sensitive properties for > > their own purposes? If so, how? > > > > Currently, sensitive props are hardcoded [2] which is sub-optimal, > > but gets the job done. However, should third-party plugin authors > > need additional / different properties, there's currently no way to > > support this. This would perhaps also be useful for this plugin > > here, as one could e.g. provide a path to a password file to use for > > something like sshpass [3] or similar, but I'm not really sure about > > this yet. > > > > The reason why I'm bringing this up is because the upcoming guide in > > the wiki could benefit from a demonstration on how to implement / > > handle both cases. Network storages are quite common, can be shared > > among nodes in most cases, and may also require one to handle > > authentication. > > See here [0][1] ;) > > [0]: > https://lore.proxmox.com/pve-devel/20250321134852.103871-8-f.eb...@proxmox.com/ > [1]: > https://lore.proxmox.com/pve-devel/20250321134852.103871-11-f.eb...@proxmox.com/
Oooooh perfect! I knew I should've checked out your series earlier! That's gonna be a godsend 🙏 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
