Re: [pve-devel] [PATCH storage v5] fix #957: iscsi: improve iscsi_test_portal logic

2025-03-21 Thread Friedrich Weber
Patch looks good to me too, ran a few tests and didn't see anything unexpected, hence: Tested-by: Friedrich Weber Reviewed-by: Friedrich Weber Thank you! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailma

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-03-21 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > btw. instead of pinging a series unconditionally a better approach might > be to use that as an opportunity to self-test the whole series, i.e. apply > them locally and see if all works out; that would have made most issues of > this series visible. > If that succeede

Re: [pve-devel] Storage plugin questions

2025-03-21 Thread Thomas Lamprecht
Am 21.03.25 um 15:45 schrieb Fiona Ebner: > Am 18.03.25 um 11:32 schrieb Max Schettler via pve-devel: >> - is it possible to integrate with the webinterface, to allow creation of a >> custom storage provider from there, instead of the CLI? > Not yet and we can't give a timeline/promises, but other

[pve-devel] [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header

2025-03-21 Thread Lukas Wagner
To quote from RFC 9110 [1]: A user agent SHOULD send Content-Length in a request when the method defines a meaning for enclosed content and it is not sending Transfer-Encoding. For example, a user agent normally sends Content-Length in a POST request even when the value is 0 (indicating

[pve-devel] [PATCH common v5 06/32] syscall: expose fallocate syscall

2025-03-21 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- New in v5. src/PVE/Syscall.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Syscall.pm b/src/PVE/Syscall.pm index 9ef3d5d..f3193a3 100644 --- a/src/PVE/Syscall.pm +++ b/src/PVE/Syscall.pm @@ -19,6 +19,7 @@ BEGIN { mknod => &SYS_mknod,

[pve-devel] [PATCH qemu v5 04/32] PVE backup: implement bitmap support for external backup access

2025-03-21 Thread Fiona Ebner
There can be one dirty bitmap for each backup target ID (which are tracked in the backup_access_bitmaps hash table). The QMP user can specify the ID of the bitmap it likes to use. This ID is then compared to the current one for the given target. If they match, the bitmap is re-used (should it still

Re: [pve-devel] Storage plugin questions

2025-03-21 Thread Fiona Ebner
Am 18.03.25 um 11:32 schrieb Max Schettler via pve-devel: > - is it possible to integrate with the webinterface, to allow creation of a > custom storage provider from there, instead of the CLI? Not yet and we can't give a timeline/promises, but others requested this as well, see: https://lore.pro

[pve-devel] [PATCH qemu-server v5 18/32] backup: implement backup for external providers

2025-03-21 Thread Fiona Ebner
The state of the VM's disk images at the time the backup is started is preserved via a snapshot-access block node. Old data is moved to the fleecing image when new guest writes come in. The snapshot-access block node, as well as the associated bitmap in case of incremental backup, will be made avai

[pve-devel] [PATCH storage v5 09/32] plugin: introduce new_backup_provider() method

2025-03-21 Thread Fiona Ebner
The new_backup_provider() method can be used by storage plugins for external backup providers. If the method returns a provider, Proxmox VE will use callbacks to that provider for backups and restore instead of using its usual backup/restore mechanisms. The backup provider API is split into two pa

[pve-devel] [PATCH container v5 27/32] external restore: don't use 'one-file-system' tar flag when restoring from a directory

2025-03-21 Thread Fiona Ebner
This gives backup providers more freedom, e.g. mount backed-up mount point volumes individually. Suggested-by: Fabian Grünbichler Signed-off-by: Fiona Ebner --- src/PVE/LXC/Create.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Cre

[pve-devel] [PATCH container v5 26/32] backup: implement restore for external providers

2025-03-21 Thread Fiona Ebner
First, the provider is asked about what restore mechanism to use. Currently, 'directory' and 'tar' are possible. The 'directory' mechanism is for restoring from a directory containing the container's full filesystem structure, which is restored by piping from a privileged tar cf - to tar xf - in th

[pve-devel] [PATCH storage v5 10/32] config api/plugins: let plugins define sensitive properties themselves

2025-03-21 Thread Fiona Ebner
Hard-coding a list of sensitive properties means that custom plugins cannot define their own sensitive properties for the on_add/on_update hooks. Have plugins declare the list of their sensitive properties in the plugin data. For backwards compatibility, return the previously hard-coded list if no

[pve-devel] [PATCH container v5 25/32] backup: implement backup for external providers

2025-03-21 Thread Fiona Ebner
The filesystem structure is made available as a directory in a consistent manner (with details depending on the vzdump backup mode) just like for regular backup via tar. The backup_container() method of the backup provider is executed in a user namespace with the container's ID mapping applied. Th

[pve-devel] [PATCH qemu-server v5 22/32] backup: support 'missing-recreated' bitmap action

2025-03-21 Thread Fiona Ebner
A new 'missing-recreated' action was added on the QEMU side. Signed-off-by: Fiona Ebner --- New in v5. PVE/VZDump/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index c2d64192..068046ae 100644 --- a/PVE/VZDump/QemuServer

[pve-devel] [PATCH qemu-server v5 20/32] backup restore: external: hardening check for untrusted source image

2025-03-21 Thread Fiona Ebner
Suggested-by: Fabian Grünbichler Signed-off-by: Fiona Ebner --- Changes in v5: * adapt to changed file_size_info() signature PVE/QemuServer.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index cb8447c9..fcec60b2 100644 --- a/PVE/QemuServer.pm

[pve-devel] [PATCH qemu-server v5 16/32] backup: fleecing: use exact size when allocating non-raw fleecing images

2025-03-21 Thread Fiona Ebner
A non-1KiB aligned source image could cause issues when used with qcow2 fleecing images, e.g. for an image with size 4.5 KiB: > Size mismatch for 'drive-tpmstate0-backup-fleecing' - sector count 10 != 9 Raw images are attached to QEMU with an explicit 'size' argument, so rounding up before allocat

[pve-devel] [PATCH qemu v5 02/32] PVE backup: get device info: allow caller to specify filter for which devices use fleecing

2025-03-21 Thread Fiona Ebner
For providing snapshot-access to external backup providers, EFI and TPM also need an associated fleecing image. The new caller will thus need a different filter. Signed-off-by: Fiona Ebner --- pve-backup.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pve-backup.c

[pve-devel] [PATCH proxmox] fix #6143: notify: allow overriding notification templates

2025-03-21 Thread Alexander Zeidler
Previously, notification templates could be modified by the user, but these were overwritten again with installing newer package versions of pve-manager and proxmox-backup. Now override templates can be created cluster-wide in the path “/etc/{pve,proxmox-backup}/notification-templates/{namespace}”

[pve-devel] [PATCH] fix #4499: prevent superblock read errors for containers on CIFS storage

2025-03-21 Thread Hugo via pve-devel
--- Begin Message --- Signed-off-by: Hugo --- src/PVE/Storage/CIFSPlugin.pm | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm index 475065a..9a8a02c 100644 --- a/src/PVE/Storage/CIFSP

[pve-devel] applied: [PATCH proxmox-i18n] updated Japanese language ja.po

2025-03-21 Thread Thomas Lamprecht
Am 21.03.25 um 00:28 schrieb rib...@skrbn.sakura.ne.jp: > > --- ja.po.org 2025-03-20 22:22:38.644618693 +0900 > +++ ja.po 2025-03-20 23:21:15.603578886 +0900 applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pro