Re: [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources

Am 10.03.25 um 13:52 schrieb Dominik Csapak: > On 3/7/25 14:40, Fiona Ebner wrote: >> Am 07.03.25 um 14:30 schrieb Fiona Ebner: >>> Am 13.02.25 um 14:17 schrieb Dominik Csapak: those should be able to migrate even for online vms. If the mapping does not exist on the target node, that

Re: [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources

On 3/7/25 14:40, Fiona Ebner wrote: Am 07.03.25 um 14:30 schrieb Fiona Ebner: Am 13.02.25 um 14:17 schrieb Dominik Csapak: those should be able to migrate even for online vms. If the mapping does not exist on the target node, that will be caught further down anyway. Signed-off-by: Dominik Csap

[pve-devel] [PATCH pve-network v2 1/8] ipam: netbox: factor out common api methods and unify error handling

Create a helper method that abstracts the common code used in making netbox requests. Move all api_request incovations over to using the helper method. This saves us from writing lots of repeated code. This also updates the helpers and introduces error checking there. Helpers didn't catch any erro

Re: [pve-devel] [PATCH proxmox-perl-rs 1/3] pve: Port to 2024 edition

Maximiliano Sandoval writes: > Signed-off-by: Maximiliano Sandoval I forgot to run rustfmt after switching to 2024 🙊. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox-mail-forward 1/2] cargo: port to rust 2024 edition

Signed-off-by: Maximiliano Sandoval --- Cargo.toml | 2 +- rustfmt.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 0f4e3b0..5a8e1d0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -6,7 +6,7 @@ authors = [ "Lukas Wagner ", "Proxmox

[pve-devel] [PATCH proxmox-mail-forward 2/2] run rustfmt

With rust 2024 edition. Signed-off-by: Maximiliano Sandoval --- src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.rs b/src/main.rs index 4662ffa..795b0f2 100644 --- a/src/main.rs +++ b/src/main.rs @@ -23,9 +23,9 @@ use std::path::Path; use anyhow::Error;

[pve-devel] applied: [PATCH] gitignore: add pattern for build packages

applied, thanks On Mon, Mar 10, 2025 at 10:34:49AM +0100, Maximiliano Sandoval wrote: > The following files fit this pattern: > > pmg-rs/libpmg-rs-perl-0.7.7/ > pmg-rs/libpmg-rs-perl-build-deps_0.7.7_all.deb > pmg-rs/libpmg-rs-perl-build-deps_0.7.7_amd64.buildinfo > pmg-rs/libpmg-rs-perl-build-de

[pve-devel] applied-series: [PATCH proxmox-perl-rs 1/3] pve: Port to 2024 edition

applied and ran cargo fmt, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox-perl-rs 2/3] pmg: Port to 2024 edition

Signed-off-by: Maximiliano Sandoval --- pmg-rs/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml index 2499f40..a6f4bb1 100644 --- a/pmg-rs/Cargo.toml +++ b/pmg-rs/Cargo.toml @@ -4,7 +4,7 @@ version = "0.7.7" description = "PMG p

[pve-devel] [PATCH] gitignore: add pattern for build packages

The following files fit this pattern: pmg-rs/libpmg-rs-perl-0.7.7/ pmg-rs/libpmg-rs-perl-build-deps_0.7.7_all.deb pmg-rs/libpmg-rs-perl-build-deps_0.7.7_amd64.buildinfo pmg-rs/libpmg-rs-perl-build-deps_0.7.7_amd64.changes pve-rs/libpve-rs-perl-0.9.2/ pve-rs/libpve-rs-perl-dbgsym_0.9.2_amd64.deb pv

Re: [pve-devel] About PVE Backup Integration Guide

Am 05.03.25 um 07:36 schrieb Prashant Patil via pve-devel: > 1. How much part of the plugins method is done? It is an initial, functional version of the API. > 2. How soon we can start the integration? The patches were not applied yet, feedback is welcome. As Thomas already said "We would

[pve-devel] [PATCH pve-network v2 5/8] ipam: netbox: add error handling to get_ips_from_mac

This function did not catch any possible errors, nor respect the $noerr parameter. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlu

[pve-devel] [PATCH pve-network v2 3/8] ipam: netbox: simplify helpers

The helpers had lots of unnecessary intermediate assignments, which we can just simplify. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/sr

[pve-devel] [PATCH pve-network v2 6/8] partial fix #5496: ipam: netbox: properly return allocated ip

The netbox integration did not properly return the IP when creating the entries in netbox. This lead to errors on starting the guest, stating that an IP could not be allocated. Originally-by: lou lecrivain Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 8 ++--

[pve-devel] [PATCH pve-network v2 4/8] ipam: netbox: no conditional assignments for descriptions

While it should make practically no difference, it opens up potential errors in the future, so just remove the conditional assignments and explicitly define the variable as undef, so the intention is more clear. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 6 +++