Re: [pve-devel] [PATCH perl-rs v2 4/5] fix #4234: openid: adjust openid verification function for userinfo option

2025-01-28 Thread Thomas Skinner
On Fri, Jan 24, 2025 at 3:17 AM Fabian Grünbichler wrote: > > On December 16, 2024 5:14 am, Thomas Skinner wrote: > > Signed-off-by: Thomas Skinner > > --- > > pve-rs/src/openid/mod.rs | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/pve-rs/src/openid/mod.r

Re: [pve-devel] [PATCH proxmox v2 5/5] fix #4234: openid: add library functions for optional userinfo endpoint

2025-01-28 Thread Thomas Skinner
On Fri, Jan 24, 2025 at 3:17 AM Fabian Grünbichler wrote: > > On December 16, 2024 5:14 am, Thomas Skinner wrote: > > Signed-off-by: Thomas Skinner > > --- > > proxmox-openid/src/lib.rs | 30 +- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > diff --git a/

[pve-devel] [PATCH qemu v2 1/2] update submodule and patches to QEMU 9.2.0

2025-01-28 Thread Fiona Ebner
Notable changes: * Commit 07bea2d35f ("block-backend: Remove deadcode") removed blk_op_{,un}block_all() which was used by PVE async savevm code. Fixed by switching to using bdrv_op_{,un}block_all(). * Drop patches that are already part of upstream. Signed-off-by: Fiona Ebner --- ...d-suppo

[pve-devel] [PATCH qemu v2 2/2] stable fixes for QEMU 9.2.0

2025-01-28 Thread Fiona Ebner
Most notabbly, there now is an upstream workaround for the "Windows PCI Label bug" [0] and the revert of QEMU commit 44d975ef34 ("x86: acpi: workaround Windows not handling name references in Package properly") can be dropped. Pick up some other fixes already merged in current master, for emulatio

[pve-devel] [PATCH-SERIES qemu v2 0/2] QEMU 9.2.0

2025-01-28 Thread Fiona Ebner
Changes in v2: * rebase for current master * add a few more stable fixes Very small diff in our patches this time and only a couple of stable fixes seemed worth picking up, see the patches for details. Did only a very quick sanity check with v2, focussing on the difference in our patches to v1.

Re: [pve-devel] [PATCH cluster v4 1/2] cluster files: add used_vmids.list

2025-01-28 Thread Thomas Lamprecht
Am 27.01.25 um 13:18 schrieb Fabian Grünbichler: >> Severen Redwood via pve-devel hat am >> 08.11.2024 02:46 CET geschrieben: > >> Add `/etc/pve/used_vmids.list` to the list of cluster files, which will >> be used for recording previously used VM/CT IDs. This is required so >> that we can option

[pve-devel] applied-series: [PATCH http-server v2 1/2] add error message into http body

2025-01-28 Thread Thomas Lamprecht
Am 28.01.25 um 15:41 schrieb Dominik Csapak: > In our rust client, we can't access the http reason phrases[0], so let's > put them into the body itself if we don't specify an explicit content. > > our proxmox-client code in rust already uses the body as message if > there is one [1], so we get tha

Re: [pve-devel] [RFC PATCH http-server 1/2] add error message into http body

2025-01-28 Thread Dominik Csapak
On 1/28/25 15:24, Thomas Lamprecht wrote: Am 27.01.25 um 13:44 schrieb Dominik Csapak: any new input on this? I have thought about blindly adding 'plain/text' to it or do an 'encode_json("$msg")' and adding 'application/json', but both options don't seem very sensible to me, as they're alteri

[pve-devel] applied: [PATCH widget-toolkit] fix #6088: notification: matcher: use more descriptive strings

2025-01-28 Thread Thomas Lamprecht
Am 28.01.25 um 10:31 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > > The longest translation of "At least one rule does not match" has only 4 more > characters than the original, this is not a problem for the size we have > available as in most cases the rules carry

[pve-devel] [PATCH http-server v2 1/2] add error message into http body

2025-01-28 Thread Dominik Csapak
In our rust client, we can't access the http reason phrases[0], so let's put them into the body itself if we don't specify an explicit content. our proxmox-client code in rust already uses the body as message if there is one [1], so we get that automatically. 0: https://github.com/hyperium/http/i

[pve-devel] [PATCH http-server v2 2/2] use HTTP_INTERNAL_SERVER_ERROR were appropriate instead of '501'

2025-01-28 Thread Dominik Csapak
The http status code 501 is meant to be 'Not Implemented'[0] but that clearly does not fit here as the default error when we encounter a problem during handling an api request or upload. So instead use '500' (HTTP_INTERNAL_SERVER_ERROR) which we already use in other places where it fits. 0: https

Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names

2025-01-28 Thread Thomas Lamprecht
Am 05.12.24 um 15:07 schrieb Daniel Kral: > Allow the names for the [first-boot] properties to be parsed as either > snake_cased or kebab-cased strings, i.e. `cert_fingerprint` or > `cert-fingerprint`, to have consistent property name casings. Currently, > this only affects the `cert_fingerprint`.

[pve-devel] applied: [PATCH installer] tree-wide: add workspace-level cargo package version

2025-01-28 Thread Thomas Lamprecht
Am 05.12.24 um 13:23 schrieb Christoph Heiss: > Means that all CLIs will now have the correct version compiled-in. > > This is at least very much relevant for > `proxmox-auto-install-assistant`, which we distribute separately as a > normal binary/package. > > Currently, `proxmox-auto-install-assi

[pve-devel] applied: [PATCH http-server] fix #4816: do not disconnect twice if client sends no data

2025-01-28 Thread Thomas Lamprecht
Am 04.12.24 um 10:52 schrieb Fabian Grünbichler: > client_do_disconnect expects to be called exactly once per connection, since > it > takes care of closing and unsetting the handle corresponding to the > connection. > to find bugs in our connection handling, it will log "detected empty handle"

[pve-devel] applied: [PATCH http-server] fix #6503: return api handler errors in the json body

2025-01-28 Thread Thomas Lamprecht
Am 08.01.25 um 10:58 schrieb Dominik Csapak: > similar to what we do for the extjs formatter, put the error message or > status message in the 'message' property of the return object. > > This way client libraries can extract the error without having to parse > the HTTP status reason phrase (which

Re: [pve-devel] [RFC PATCH http-server 1/2] add error message into http body

2025-01-28 Thread Thomas Lamprecht
Am 27.01.25 um 13:44 schrieb Dominik Csapak: > any new input on this? > > I have thought about blindly adding 'plain/text' to it or do an > 'encode_json("$msg")' and adding > 'application/json', but both options don't seem very sensible to me, as > they're altering > the content type for all err

Re: [pve-devel] [PATCH widget-toolkit] fix #6088: notification: matcher: use more descriptive strings

2025-01-28 Thread Lukas Wagner
On 2025-01-28 10:31, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > > The longest translation of "At least one rule does not match" has only 4 more > characters than the original, this is not a problem for the size we have > available as in most cases the rules carry e

[pve-devel] [PATCH widget-toolkit] fix #6088: notification: matcher: use more descriptive strings

2025-01-28 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- The longest translation of "At least one rule does not match" has only 4 more characters than the original, this is not a problem for the size we have available as in most cases the rules carry even longer text. src/window/NotificationMatcherEdit.js | 15