In our rust client, we can't access the http reason phrases[0], so let's put them into the body itself if we don't specify an explicit content.
our proxmox-client code in rust already uses the body as message if there is one [1], so we get that automatically. 0: https://github.com/hyperium/http/issues/737 1: https://git.proxmox.com/?p=proxmox.git;a=blob;f=proxmox-client/src/client.rs;h=9b078a9820405b22ca54c17ea4da4c586e0649b4;hb=refs/heads/master#l237 Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> --- changes from rfc: * add a comment why we don't set the content type src/PVE/APIServer/AnyEvent.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index b94e1aa..9a1e35a 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src/PVE/APIServer/AnyEvent.pm @@ -389,6 +389,9 @@ sub error { my ($self, $reqstate, $code, $msg, $hdr, $content) = @_; eval { + $content //= $msg; # write error into body by default + # lack of content type here means either 'application/octet-stream' or the client + # can guess. This is fine since we don't know what content/msg actually contains. my $resp = HTTP::Response->new($code, $msg, $hdr, $content); $self->response($reqstate, $resp); }; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
