[pve-devel] [PATCH pve-kernel v2] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-22 Thread Stoiko Ivanov
Can be used to generate a package for testing a particular bugfix, or new version, which can be shared with a small audience, without reusing the current package version, or bumping to a version that looks like our released kernels[0]. previously this could be accomplished by setting the PKGREL va

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-22 Thread Thomas Lamprecht
Am 22.01.25 um 16:23 schrieb Hannes Dürr: > > On 1/21/25 17:12, Hannes Dürr wrote: >> >> On 1/21/25 16:36, Thomas Lamprecht wrote: >>> Am 21.01.25 um 11:47 schrieb Dominik Csapak: It's probably not a bad idea to install the packages for all installed kernel versions? (@Thomas ?) >>> Yea

[pve-devel] applied: [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace

2025-01-22 Thread Thomas Lamprecht
Am 22.01.25 um 11:55 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > src/test/ha-tester.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

[pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import

2025-01-22 Thread Thomas Lamprecht
Am 22.01.25 um 11:55 schrieb Fiona Ebner: > There is no user of File::Path remaining after commit 787b66e > ("SimCluster: setup status dir inside new") which was the only user > of remove_tree(). make_path() was not used at all according to git > history. > > Signed-off-by: Fiona Ebner > --- > s

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-22 Thread Hannes Dürr
On 1/21/25 17:12, Hannes Dürr wrote: On 1/21/25 16:36, Thomas Lamprecht wrote: Am 21.01.25 um 11:47 schrieb Dominik Csapak: It's probably not a bad idea to install the packages for all installed kernel versions? (@Thomas ?) Yeah, would be definitively a nice UX enhancement. sounds good to m

Re: [pve-devel] [PATCH pve-kernel] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-22 Thread Stoiko Ivanov
On Wed, 22 Jan 2025 15:49:06 +0100 Thomas Lamprecht wrote: > Am 20.01.25 um 20:27 schrieb Stoiko Ivanov: > > Can be used to generate a package for testing a particular bugfix, or > > new version, which can be shared with a small audience, without > > reusing the current package version, or bumpin

Re: [pve-devel] [PATCH guest-common v5 3/3] mapping: remove find_on_current_node

2025-01-22 Thread Thomas Lamprecht
Am 22.01.25 um 09:16 schrieb Dominik Csapak: > On 1/20/25 15:51, Dominik Csapak wrote: >> they only have one user each (where we can inline the implementation). >> It's easy enough to recreate should we need to. >> > > turns out i forgot that we added a second user of the pci function in > pve-ma

Re: [pve-devel] [PATCH qemu-server v5 10/11] tests: cfg2cmd: fix mdev tests

2025-01-22 Thread Thomas Lamprecht
Am 20.01.25 um 15:51 schrieb Dominik Csapak: > this will fail with the new checks for mdev when we don't have the > correct config. IIUC this patch should then be ordered earlier before any patch that needs a newer guest-common that contains the adapted check.I _

Re: [pve-devel] [PATCH pve-kernel] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-22 Thread Thomas Lamprecht
Am 20.01.25 um 20:27 schrieb Stoiko Ivanov: > Can be used to generate a package for testing a particular bugfix, or > new version, which can be shared with a small audience, without > reusing the current package version, or bumping to a version that > looks like our released kernels[0]. > > previo

Re: [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images

2025-01-22 Thread Fiona Ebner
Am 22.01.25 um 14:18 schrieb Daniel Kral: > On 11/29/24 15:23, Fiona Ebner wrote: >> Am 16.09.24 um 18:38 schrieb Daniel Kral: >>> +=head3 check_volume_alloc($storecfg, $storeid, $node) >>> + >>> +Checks whether the volume with the identifier C<$volid>, that is >>> defined in C<$storecfg> (which >>

Re: [pve-devel] [RFC qemu-server 2/9] cfg2cmd: improve error message for invalid volume storage content type

2025-01-22 Thread Fiona Ebner
Am 22.01.25 um 14:16 schrieb Daniel Kral: > Thank you very much for taking a look over this! > > Sorry for taking such a long time for getting back to you on this, I'll > rework this patch series for a v2 now. > > On 11/29/24 15:23, Fiona Ebner wrote: >> Am 16.09.24 um 18:38 schrieb Daniel Kral:

Re: [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images

2025-01-22 Thread Daniel Kral
On 1/22/25 14:18, Daniel Kral wrote: On 11/29/24 15:23, Fiona Ebner wrote: Am 16.09.24 um 18:38 schrieb Daniel Kral: +sub check_volume_alloc : prototype($$;$) { Again, "assert_" and "_permission" Hm, why did you choose permission here? There are no permission checks done here, would be a s

Re: [pve-devel] [RFC qemu-server 9/9] restore_vm: improve checks if storage supports vm images

2025-01-22 Thread Daniel Kral
On 11/29/24 15:23, Fiona Ebner wrote: Am 16.09.24 um 18:38 schrieb Daniel Kral: Improves checks if the underlying storage, where VMs are restored to, support the content type 'images'. This has been already the case for backup restores, but is refactored to use `check_storage_alloc` and `check_v

Re: [pve-devel] [RFC qemu-server 7/9] api: migrate_vm: improve check if target storages support vm images

2025-01-22 Thread Daniel Kral
On 11/29/24 15:23, Fiona Ebner wrote: Am 16.09.24 um 18:38 schrieb Daniel Kral: diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a0abe44f..13c1c4e0 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -220,18 +220,6 @@ my $check_storage_access_clone = sub { return $sharedvm; };

Re: [pve-devel] [RFC qemu-server 4/9] api: clone_vm: add check if storage supports vm images

2025-01-22 Thread Daniel Kral
On 11/29/24 15:23, Fiona Ebner wrote: Am 16.09.24 um 18:38 schrieb Daniel Kral: @@ -197,6 +198,25 @@ sub check_volume_alloc : prototype($$;$) { return 1; } +=head3 alloc_volume_disk($storecfg, $storeid, $vmid, $format, $name, $size_kb) + +Allocates a volume disk image on C<$storeid>,

Re: [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images

2025-01-22 Thread Daniel Kral
On 11/29/24 15:23, Fiona Ebner wrote: For issues like these, it's often nice to start out with the fix and put bigger refactorings later. Then the fix can already be applied up-front while discussing the bigger changes. ACK, I'll move this in front of the other changes. Am 16.09.24 um 18:38

Re: [pve-devel] [PATCH proxmox-i18n 2/2] make: add proxmox-datacenter-manager translations

2025-01-22 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > Am 22.01.25 um 13:22 schrieb Maximiliano Sandoval: >> Maximiliano Sandoval writes: >>> One thing to note is that xtr, unlike our script to extract translations >>> will add comments, context, and plural forms. >> >> I forgot to mention that xtr is not bundled at the mo

Re: [pve-devel] [RFC qemu-server 2/9] cfg2cmd: improve error message for invalid volume storage content type

2025-01-22 Thread Daniel Kral
Thank you very much for taking a look over this! Sorry for taking such a long time for getting back to you on this, I'll rework this patch series for a v2 now. On 11/29/24 15:23, Fiona Ebner wrote: Am 16.09.24 um 18:38 schrieb Daniel Kral: diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuSer

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 4/4] debian: add and install nvidia-vgpu systemd template unit file

2025-01-22 Thread Thomas Lamprecht
Am 21.01.25 um 11:36 schrieb Dominik Csapak: > On 1/21/25 11:04, Hannes Duerr wrote: >> diff --git a/debian/nvidia-vgpud@.service b/debian/nvidia-vgpud@.service >> new file mode 100644 >> index 000..b3c1220 >> --- /dev/null >> +++ b/debian/nvidia-vgpud@.service > > mhmm not sure if it's so good

Re: [pve-devel] [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-01-22 Thread Alexander Zeidler
On Tue Jan 21, 2025 at 3:46 PM CET, Aaron Lauterer wrote: > > > On 2025-01-21 13:08, Alexander Zeidler wrote: >> On Mon Jan 20, 2025 at 3:35 PM CET, Aaron Lauterer wrote: >>> VSS in windows guests with additional backup software in the guest can >>> cause problems. By now the guest agent does sup

Re: [pve-devel] [PATCH proxmox-i18n 2/2] make: add proxmox-datacenter-manager translations

2025-01-22 Thread Thomas Lamprecht
Am 22.01.25 um 13:22 schrieb Maximiliano Sandoval: > Maximiliano Sandoval writes: >> One thing to note is that xtr, unlike our script to extract translations >> will add comments, context, and plural forms. > > I forgot to mention that xtr is not bundled at the moment for Debian and > this is a b

Re: [pve-devel] [PATCH proxmox-i18n 2/2] make: add proxmox-datacenter-manager translations

2025-01-22 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-manager instead of the whole > {lang}.po file. The msgmerge command will produce all strings containing > in the {lang}.po file but the ones that do not conce

[pve-devel] [PATCH proxmox-i18n 2/2] make: add proxmox-datacenter-manager translations

2025-01-22 Thread Maximiliano Sandoval
The catalog-{lang}.mo files are generated only with strings that are relevant to the proxmox-datacenter-manager instead of the whole {lang}.po file. The msgmerge command will produce all strings containing in the {lang}.po file but the ones that do not concern proxmox-datacenter-manager.pot will be

[pve-devel] [PATCH proxmox-i18n 1/2] makefile: prefer using xgettext over msgcat

2025-01-22 Thread Maximiliano Sandoval
For concatenating .pot files. From [1]: > To concatenate POT files, better use xgettext, not msgcat, because > msgcat would choke on the undefined charsets in the specified POT > files. [1] https://www.gnu.org/software/gettext/manual/html_node/msgcat-Invocation.html Signed-off-by: Maximiliano Sa

[pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import

2025-01-22 Thread Fiona Ebner
There is no user of File::Path remaining after commit 787b66e ("SimCluster: setup status dir inside new") which was the only user of remove_tree(). make_path() was not used at all according to git history. Signed-off-by: Fiona Ebner --- src/test/ha-tester.pl | 2 -- 1 file changed, 2 deletions(-

[pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace

2025-01-22 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/test/ha-tester.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl index 8ff1629..0693133 100755 --- a/src/test/ha-tester.pl +++ b/src/test/ha-tester.pl @@ -47,7 +47,7 @@ sub do_run_test { my

[pve-devel] [PATCH docs v13 3/12] add doc section for the shared filesystem virtio-fs

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 92 +++-- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..5ad79c1 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1202,6 +1202,93 @@ recommended to always use a lim

[pve-devel] [PATCH manager v13 09/12] ui: add edit window for dir mappings

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 208 ++ 2 files changed, 209 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile i

[pve-devel] [PATCH manager v13 11/12] ui: form: add selector for directory mappings

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v13 0/12] virtiofs

2025-01-22 Thread Markus Frank
Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system protocol. build-order: 1. cluster 2. guest-common 3. docs 4. qemu-serve

[pve-devel] [PATCH qemu-server v13 5/12] fix #1027: virtio-fs support

2025-01-22 Thread Markus Frank
add support for sharing directories with a guest vm. virtio-fs needs virtiofsd to be started. In order to start virtiofsd as a process (despite being a daemon it is does not run in the background), a double-fork is used. virtiofsd should close itself together with QEMU. There are the parameters

[pve-devel] [PATCH manager v13 08/12] api: add resource map api endpoints for directories

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 307 ++ PVE/API2/Cluster/Mapping/Makefile | 1 + 3 files changed, 315 insertions(+) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm diff --git a/PVE/AP

[pve-devel] [PATCH manager v13 12/12] ui: add options to add virtio-fs to qemu config

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 123 ++ 4 files changed, 144 insertions(+) create mode 100644 www/m

[pve-devel] [PATCH qemu-server v13 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b89a7e71..00178575 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2460,8 +2460,9 @@ sub check_non_migratable_resources

[pve-devel] [PATCH manager v13 10/12] ui: add resource mapping view for directories

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 42 +++ 3 files changed, 53 insertions(+) create mode 100644 www/manager6/dc/DirMapView.js diff --git a/www/manager

[pve-devel] [PATCH qemu-server v13 6/12] migration: check_local_resources for virtiofs

2025-01-22 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 12 +++- test/MigrationTest/Shared.pm |

[pve-devel] [PATCH guest-common v13 2/12] add dir mapping section config

2025-01-22 Thread Markus Frank
Adds a config file for directories by using a 'map' property string for each node mapping. Next to node & path, there is the optional announce-submounts parameter which forces virtiofsd to report a different device number for each submount it encounters. Without it, duplicates may be created becau

[pve-devel] [PATCH qemu-server v13 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-01-22 Thread Markus Frank
Signed-off-by: Markus Frank --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 81f0fad6..eda357a5 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus, socat, swtpm, swtpm-tools, +

[pve-devel] [PATCH cluster v13 1/12] add mapping/dir.cfg for resource mapping

2025-01-22 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff -

Re: [pve-devel] [PATCH guest-common v5 3/3] mapping: remove find_on_current_node

2025-01-22 Thread Dominik Csapak
On 1/20/25 15:51, Dominik Csapak wrote: they only have one user each (where we can inline the implementation). It's easy enough to recreate should we need to. turns out i forgot that we added a second user of the pci function in pve-manager we still need to adapt the qemu-server side code st