On 1/20/25 15:51, Dominik Csapak wrote:
they only have one user each (where we can inline the implementation).
It's easy enough to recreate should we need to.


turns out i forgot that we added a second user of the pci function in 
pve-manager

we still need to adapt the qemu-server side code still, so this would have one 
user after
again...

i could still do the changes similar to this version (remove the 
find_on_current_node here,
add a new sub in qemu-server) but add a new patch for pve-manager that makes
use of the new qemu-server sub

alternatively we could omit this patch and simply change the one place in 
qemu-server
where find_on_current_node is not enough

seems variant 2 is less breakage & work, any input on this @thomas?
(I'm asking you because you started to review the patches in v5)

but I'll wait with a v6 until i get more feedback on this series
(at least a user on the bugzilla reported that it works correct except the VFIO state in the migration log)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to