Re: [pve-devel] Nobody from proxmox team AT cephalocon ?

2024-12-04 Thread Hannes Dürr
Hi Alexandre, i don't know if a colleague has already replied to you, if not: As far as I know, no colleague went to the cephalocon this year. LG Hannes Dürr On 12/4/24 12:31, Alexandre Derumier via pve-devel wrote: ___ pve-devel mailing list pve-d

Re: [pve-devel] [PATCH docs 2/2] pvesr: mention how to configure specific network for replication

2024-12-04 Thread Aaron Lauterer
I sent a v2 https://lore.proxmox.com/pve-devel/20241204160749.1868857-1-a.laute...@proxmox.com/T/#t On 2024-11-29 16:17, Fiona Ebner wrote: Am 05.11.24 um 12:08 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- pvesr.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/

[pve-devel] [PATCH docs v2 1/2] pvecm: add anchor for the migration network chapter

2024-12-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v1: * new patch pvecm.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pvecm.adoc b/pvecm.adoc index 5117eaa..15dda4e 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -1365,6 +1365,7 @@ modern systems is lower because they implement AES encrypt

[pve-devel] [PATCH docs v2 2/2] pvesr: mention how to configure specific network for replication

2024-12-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v1: * reworded and mention datacenter.cfg and link to the section explaining it in more detail pvesr.adoc | 8 1 file changed, 8 insertions(+) diff --git a/pvesr.adoc b/pvesr.adoc index e626835..9ad02f5 100644 --- a/pvesr.adoc +++ b/pve

[pve-devel] [PATCH access-control] api: role: remove role references from acl rules on role deletion

2024-12-04 Thread Daniel Kral
Let the API endpoint `DELETE /access/roles/{roleid}` or command `pveum role delete ` remove any ACL rules in the user configuration, which reference the removed role. Before this change, the removal of a role has caused the role to remain in existing ACL rules, which referenced the removed role. T

[pve-devel] Nobody from proxmox team AT cephalocon ?

2024-12-04 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Hi guys, I m AT the cephalocon AT Genève for 2 days. Any proxmox devs here ? --- End Message --- ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH qemu-server 1/3] api: clone: add missing sort to hash

2024-12-04 Thread Fiona Ebner
Am 04.12.24 um 11:30 schrieb Alexander Zeidler: > When cloning was repeatedly attempted, the error message indicated a > different unsupported volume each time. The hash is now sorted to always > mention the same volume as long as it has not been fixed. > > Signed-off-by: Alexander Zeidler > ---

[pve-devel] [PATCH widget-toolkit/manager/access-control/docs 0/5] clarify that password changes for PAM realm only apply to local node

2024-12-04 Thread Fiona Ebner
Soft dependency bump manager -> widget-toolkit needed to actually make it work in the UI. proxmox-widget-toolkit: Fiona Ebner (1): password edit: support specifying a hint src/window/PasswordEdit.js | 13 + 1 file changed, 13 insertions(+) manager: Fiona Ebner (1): user: pass

Re: [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab

2024-12-04 Thread Dominik Csapak
generally looks good but i have one high level comment/question (and some nits inline) one thing i'd like to see here is to retain the info what is configured, so previously the info was either 'dhcp'/'auto' (slaac) or an ip address now we only show the ip adress what i mean is something like

[pve-devel] [PATCH docs 5/5] user management: clarify that password changes for PAM realm only apply to local node

2024-12-04 Thread Fiona Ebner
Reported in the community forum: https://forum.proxmox.com/threads/158518/ Signed-off-by: Fiona Ebner --- pveum.adoc | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 81565ab..b8303e8 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -170,8 +1

[pve-devel] [PATCH widget-toolkit 1/5] password edit: support specifying a hint

2024-12-04 Thread Fiona Ebner
Intended to be used by Proxmox VE to clarify that password changes for the PAM realm only apply to the local node. Signed-off-by: Fiona Ebner --- src/window/PasswordEdit.js | 13 + 1 file changed, 13 insertions(+) diff --git a/src/window/PasswordEdit.js b/src/window/PasswordEdit.js

[pve-devel] [PATCH access-control 3/5] api: clarify that password changes for PAM realm only apply to local node

2024-12-04 Thread Fiona Ebner
Reported in the community forum: https://forum.proxmox.com/threads/158518/ Signed-off-by: Fiona Ebner --- src/PVE/API2/AccessControl.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2/AccessControl.pm index f23662a..bb7b78f 10064

[pve-devel] [PATCH manager 2/5] user: password edit: clarify that password changes for PAM realm only apply to local node

2024-12-04 Thread Fiona Ebner
Reported in the community forum: https://forum.proxmox.com/threads/158518/ Signed-off-by: Fiona Ebner --- www/manager6/dc/UserView.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js index 82bd2ee7..d5844674 100644 --- a/www/mana

[pve-devel] [PATCH access-control 4/5] api: password: use singular they pronoun

2024-12-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/PVE/API2/AccessControl.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2/AccessControl.pm index bb7b78f..c4c0699 100644 --- a/src/PVE/API2/AccessControl.pm +++ b/src/PVE/API2/AccessControl.p

Re: [pve-devel] [PATCH cluster 2/3] add consent-text paramter to datacenter config file

2024-12-04 Thread Thomas Lamprecht
Am 04.12.24 um 10:16 schrieb Gabriel Goller: > On 03.12.2024 18:24, Thomas Lamprecht wrote: >> Am 03.12.24 um 16:29 schrieb Gabriel Goller: >>> The consent-text paramter is the base64-encoded content of the optional >>> consent-banner which can be displayed before login. >> >> This can get quite bi

Re: [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab

2024-12-04 Thread Gabriel Goller
On 04.12.2024 11:10, Dominik Csapak wrote: On 12/4/24 10:52, Gabriel Goller wrote: On 04.12.2024 10:17, Dominik Csapak wrote: generally looks good but i have one high level comment/question (and some nits inline) one thing i'd like to see here is to retain the info what is configured, so previ

[pve-devel] [PATCH qemu-server 3/3] api: clone: mention "snapshot" in the error message if specified

2024-12-04 Thread Alexander Zeidler
as it may be the only cause of the clone incompatibility Example: # qm clone 101 102 --full --snapname foo Before: > Full clone feature is not supported for > 'local-zfs:base-100-disk-2/vm-101-disk-2' (tpmstate0) After: > Full clone feature is not supported for a snapshot of > 'local-zfs:base

[pve-devel] [PATCH qemu-server 1/3] api: clone: add missing sort to hash

2024-12-04 Thread Alexander Zeidler
When cloning was repeatedly attempted, the error message indicated a different unsupported volume each time. The hash is now sorted to always mention the same volume as long as it has not been fixed. Signed-off-by: Alexander Zeidler --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH qemu-server 2/3] api: clone: extend error message by volume ID

2024-12-04 Thread Alexander Zeidler
So far, the error message only contained the name of the disk (tpmstate0, efidisk0, ...), which can also lead to the assumption that a specific disk type is the problem. Now the volume ID is primarily listed. Example: # qm clone 101 102 --full --snapname foo Before: > Full clone feature is not s

Re: [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab

2024-12-04 Thread Dominik Csapak
On 12/4/24 10:52, Gabriel Goller wrote: On 04.12.2024 10:17, Dominik Csapak wrote: generally looks good but i have one high level comment/question (and some nits inline) one thing i'd like to see here is to retain the info what is configured, so previously the info was either 'dhcp'/'auto' (sla

[pve-devel] [PATCH http-server] fix #4816: do not disconnect twice if client sends no data

2024-12-04 Thread Fabian Grünbichler
client_do_disconnect expects to be called exactly once per connection, since it takes care of closing and unsetting the handle corresponding to the connection. to find bugs in our connection handling, it will log "detected empty handle" if it is called for a request/connection that no longer has a

Re: [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab

2024-12-04 Thread Gabriel Goller
On 04.12.2024 10:17, Dominik Csapak wrote: generally looks good but i have one high level comment/question (and some nits inline) one thing i'd like to see here is to retain the info what is configured, so previously the info was either 'dhcp'/'auto' (slaac) or an ip address now we only show th

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

2024-12-04 Thread Dominik Csapak
Hi, thanks for wanting to contribute! First, did you already see https://pve.proxmox.com/wiki/Developer_Documentation ? (especially the CLA part at the end?) Just a few high level comments/questions to the approach (did not look too much at the code yet). Please correct me if I'm wrong, but

Re: [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view

2024-12-04 Thread Dominik Csapak
high level comments/questions (i know they're not you're patches exactly, but still): * maybe it would be better to integrate this into the AgentIPView for vms? AFAICS the code is very similar and probably just needs a few adaptions to work there too (url,parsing, etc.) I'm not opposed to

Re: [pve-devel] [PATCH cluster 2/3] add consent-text paramter to datacenter config file

2024-12-04 Thread Gabriel Goller
On 03.12.2024 18:24, Thomas Lamprecht wrote: Am 03.12.24 um 16:29 schrieb Gabriel Goller: The consent-text paramter is the base64-encoded content of the optional consent-banner which can be displayed before login. This can get quite big, would be good to set some relatively high limit here, I

Re: [pve-devel] [PATCH manager 1/3] show optional consent-banner before login

2024-12-04 Thread Gabriel Goller
On 03.12.2024 18:24, Thomas Lamprecht wrote: Am 03.12.24 um 16:29 schrieb Gabriel Goller: Add ConsentBanner variable to html template and populate it from the `datacenter.cfg` config file. Add Datacenter option to set the text and trigger the popup on login. Signed-off-by: Gabriel Goller ---