On 04.12.2024 11:10, Dominik Csapak wrote:
On 12/4/24 10:52, Gabriel Goller wrote:
On 04.12.2024 10:17, Dominik Csapak wrote:
generally looks good but i have one high level comment/question
(and some nits inline)
one thing i'd like to see here is to retain the info what is configured,
so previously the info was either 'dhcp'/'auto' (slaac) or an ip address
now we only show the ip adress
what i mean is something like
'x.y.z.w (dhcp)'
or
'xx00::1 (static)'
etc. so one can still see what mode is configured
This is a nice idea, but it could be a bit tricky. To get the ip info we
execute `ip a` in the container's netns, but for some reason I can't see
the 'dynamic' option which is usually shown on a dynamically acquired
address.
I could use `ip route` and check if the route was inserted by 'dhcp' or
'kernel', but no idea how foolproof this is...
but you should have the info what is configured from the confResponse, no?
so something like
if (net.ip === 'dhcp' || ...) {
net.ip = `${iface.inet} (${net.ip})`;
...
}
?
Oh, yeah didn't notice this, this is nice.
Though I still have to change the api endpoint to return multiple
ip-addresses so that we also support a static ip with a dhcp-enabled
bridge (this will set two addresses on the interface). Then I can match
the static ip from the config with the set ip and find out which one is
static and which one is dynamic.
Thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
