[pve-devel] [PATCH common] tools: explain reason for the explicit PerlIO load

2024-12-02 Thread Filip Schauer
Explain the reason for the explicit `use PerlIO::scalar;` statement introduced in c4945bf ("tools: load PerlIO explicitly to avoid odd failures") Signed-off-by: Filip Schauer --- src/PVE/Tools.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Tools.pm b/

Re: [pve-devel] [PATCH proxmox] notify: remove legacy filters and groups

2024-12-02 Thread Thomas Lamprecht
Am 02.12.24 um 14:32 schrieb Lukas Wagner: > It has been a full year now, so I'd argue it is safe to drop these > safety guards now. On the off chance that there are still systems out > there which still have these entries in their notifications.cfg, > a manual removal from the file will be needed

Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 2/2] add script to help with the installation of the nvidia vgpu dependencies

2024-12-02 Thread Thomas Lamprecht
Am 02.12.24 um 09:47 schrieb Dominik Csapak: > What I'd have imagined is more like our 'pveceph' tool that can > include multiple commands, even if we might only have one or two for now > > so e.g. > > pve-nvidia-vgpu-helper install-prerequisites Yes, that was my idea as well, but I'd just do ab

[pve-devel] [PATCH proxmox] notify: remove legacy filters and groups

2024-12-02 Thread Lukas Wagner
The notification system as we know it know underwent a serious overhaul shortly before its initial release in PVE one year ago. Before the overhaul, there were filters (the 'inverse' of a matchers as we know them today) and groups (allowed one to send a notification to multiple targets at once, the

Re: [pve-devel] [PATCH] webhook edit: do not split translatable strings

2024-12-02 Thread Maximiliano Sandoval
"Shannon Sterz" writes: > wouldn't it be more elegant to simply define `addLabel` as > `gettext('Add')` and then override that where needed? that would safe > this akward ternary operator. haven't tested that though. Not sure to be honest. Whenever in doubt I try to leave the logic as close as p

[pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view

2024-12-02 Thread Gabriel Goller
modelled after the QEMU Guest Agent UI. We only show the first non-loopback IP on the summary page itself. Originally-by: Leo Nunner [GG: increase status panel height] Signed-off-by: Gabriel Goller --- www/manager6/Makefile | 1 + www/manager6/lxc/ContainerIPView.js | 19

[pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab

2024-12-02 Thread Gabriel Goller
Show the ip/hwaddress of the network interfaces of containers in the summary tab of the container and in the network tab on a per-interface basis. This series was originally by Leo Nunner: https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nun...@proxmox.com/ The pve-container patch has

[pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in network tab

2024-12-02 Thread Gabriel Goller
adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the returned data with the existing configuration. This will update the IPv4 and IPv6 address, as well as the interface name (in case the container changed it). Originally-by: Leo Nunner Signed-off-by: Gabriel Goller --- www/manager6

Re: [pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab

2024-12-02 Thread Gabriel Goller
Oops, ignore this mail, forgot to ignore the Leo Nunners' email so the other patches won't get through :) ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab

2024-12-02 Thread Gabriel Goller
Show the ip/hwaddress of the network interfaces of containers in the summary tab of the container and in the network tab on a per-interface basis. This series was originally by Leo Nunner: https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nun...@proxmox.com/ The pve-container patch has

Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 2/2] add script to help with the installation of the nvidia vgpu dependencies

2024-12-02 Thread Hannes Dürr
On 12/2/24 09:47, Dominik Csapak wrote: high level comments first: * the script is actually not installed with the package, because it's not installed anywhere and not in any .install file (you'd either have to use an 'install' target in the makefile to install it to some folder or use a .in

Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 1/2] debian/control: adjust description and pve-manager dependency

2024-12-02 Thread Hannes Dürr
On 12/2/24 09:36, Dominik Csapak wrote: i think that's in reverse? we don't need pve-manager here AFAICT, but if we want a dependency somewhere, we'd want to add this package as a dependency of pve-manager, no? from the current state of this package I don't see a reason to depend on any pve/p

Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 2/2] add script to help with the installation of the nvidia vgpu dependencies

2024-12-02 Thread Dominik Csapak
high level comments first: * the script is actually not installed with the package, because it's not installed anywhere and not in any .install file (you'd either have to use an 'install' target in the makefile to install it to some folder or use a .install file in the debian folder for the pac

Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 1/2] debian/control: adjust description and pve-manager dependency

2024-12-02 Thread Dominik Csapak
On 11/20/24 12:26, Hannes Duerr wrote: remove the dependency of proxmox-dkms, since this package does not exist, and add the dependency of pve-manager, which should be installed with every reasonable Proxmox VE installation, so that the package can already be installed during the installation.