[pve-devel] applied: [PATCH docs 1/2] pvesr: fix possible issues storage ID

2024-11-29 Thread Fiona Ebner
Am 05.11.24 um 12:08 schrieb Aaron Lauterer: > The same storage needs to be configured on the target node for the > replication to work. > > Signed-off-by: Aaron Lauterer > --- > pvesr.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pvesr.adoc b/pvesr.adoc > index

Re: [pve-devel] [PATCH docs 2/2] pvesr: mention how to configure specific network for replication

2024-11-29 Thread Fiona Ebner
Am 05.11.24 um 12:08 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pvesr.adoc | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/pvesr.adoc b/pvesr.adoc > index 4fc2de1..209f306 100644 > --- a/pvesr.adoc > +++ b/pvesr.adoc > @@ -181,6 +181,12 @@ A replication job is

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
superseded-by version 2: https://lore.proxmox.com/pve-devel/20241129150013.323432-1-c.eb...@proxmox.com/T/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
Allow to select the change detection mode when performing manual backups of containers with Proxmox Backup Server as target, just like for the advanced backup job options introduced by commit 3b21f19f ("www: advanced backup: add pbs change detection mode selector"). The selector is shown for virtu

Re: [pve-devel] [PATCH docs] backup: warn that tar does not honor exclusion pattern with a trailing slash

2024-11-29 Thread Fiona Ebner
Am 31.05.24 um 12:07 schrieb Fiona Ebner: > As reported in the community forum [0], for tar, an exclusion pattern > with a trailing slash will not match a folder with that name. For > rsync and proxmox-backup-client however, such a pattern will exclude > a directory with that name, but not a file.

Re: [pve-devel] [PATCH v2 proxmox-apt-hook] initial commit

2024-11-29 Thread Fiona Ebner
Am 09.09.24 um 12:20 schrieb Fiona Ebner: > Many people will use 'upgrade' instead of 'full-upgrade' or > 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly > mentioning 'dist-upgrade' [3]. Proxmox projects use different > packaging guarantees than Debian (necessary for a rolling rel

Re: [pve-devel] [PATCH-SERIES qemu-server] cfg2cmd: bump minimum binary version to 5.0 and test for QEMU machine version instead of binary version

2024-11-29 Thread Fiona Ebner
Am 23.07.24 um 17:25 schrieb Fiona Ebner: > Since there are certain checks that depend on the QEMU binary version, > tests with a fixed QEMU binary version make it less likely to catch > issues on current setups, because current setups will always have a > newer QEMU binary version than the test. >

Re: [pve-devel] [RFC qemu-server 9/9] restore_vm: improve checks if storage supports vm images

2024-11-29 Thread Fiona Ebner
Am 16.09.24 um 18:38 schrieb Daniel Kral: > Improves checks if the underlying storage, where VMs are restored to, > support the content type 'images'. This has been already the case for > backup restores, but is refactored to use `check_storage_alloc` and > `check_volume_alloc`. > > Adds a check r

Re: [pve-devel] [RFC qemu-server 7/9] api: migrate_vm: improve check if target storages support vm images

2024-11-29 Thread Fiona Ebner
Am 16.09.24 um 18:38 schrieb Daniel Kral: > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index a0abe44f..13c1c4e0 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -220,18 +220,6 @@ my $check_storage_access_clone = sub { > return $sharedvm; > }; > > -my $check_storage_acces

Re: [pve-devel] [RFC qemu-server 1/9] test: cfg2cmd: expect error for invalid volume's storage content type

2024-11-29 Thread Fiona Ebner
Am 16.09.24 um 18:38 schrieb Daniel Kral: > @@ -68,7 +72,7 @@ my $base_env = { > content => { > images => 1, > } > - } > + }, Nit: unrelated hunk should be it's own patch > } > }, > vmid => 8006,

Re: [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images

2024-11-29 Thread Fiona Ebner
For issues like these, it's often nice to start out with the fix and put bigger refactorings later. Then the fix can already be applied up-front while discussing the bigger changes. Am 16.09.24 um 18:38 schrieb Daniel Kral: > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm > ind

Re: [pve-devel] [RFC qemu-server 4/9] api: clone_vm: add check if storage supports vm images

2024-11-29 Thread Fiona Ebner
Am 16.09.24 um 18:38 schrieb Daniel Kral: > @@ -197,6 +198,25 @@ sub check_volume_alloc : prototype($$;$) { > return 1; > } > > +=head3 alloc_volume_disk($storecfg, $storeid, $vmid, $format, $name, > $size_kb) > + > +Allocates a volume disk image on C<$storeid>, that is defined in > C<$st

Re: [pve-devel] [RFC qemu-server 2/9] cfg2cmd: improve error message for invalid volume storage content type

2024-11-29 Thread Fiona Ebner
Am 16.09.24 um 18:38 schrieb Daniel Kral: > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm > index 0afb6317..9d0f24aa 100644 > --- a/PVE/QemuServer/Helpers.pm > +++ b/PVE/QemuServer/Helpers.pm > @@ -106,6 +106,51 @@ sub vm_running_locally { > return; > } > > +=head3 chec

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
On 11/29/24 14:25, Shannon Sterz wrote: On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote: On 11/29/24 14:09, Shannon Sterz wrote: On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: Allow to select the change detection mode when performing manual backups of containers with Prox

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote: > On 11/29/24 14:09, Shannon Sterz wrote: > > On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > >> Allow to select the change detection mode when performing manual > >> backups of containers with Proxmox Backup Server as target,

Re: [pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Christoph Heiss
On Fri, Nov 29, 2024 at 02:18:25PM +0100, Shannon Sterz wrote: > On Fri Nov 29, 2024 at 2:08 PM CET, Christoph Heiss wrote: > > [..] > > @@ -27,14 +27,13 @@ Mailing Lists > > This is a fast way to communicate with the {pve} community via email. > > > > * Mailing list for users: > > - http://list

Re: [pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 2:08 PM CET, Christoph Heiss wrote: > It's been the preferred mailing list archive for some time now. > > Signed-off-by: Christoph Heiss > --- > getting-help.adoc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/getting-help.adoc b/getting-help.

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
On 11/29/24 14:09, Shannon Sterz wrote: On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: Allow to select the change detection mode when performing manual backups of containers with Proxmox Backup Server as target, just like for the advanced backup job options introduced by commit 3b21f

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > Allow to select the change detection mode when performing manual > backups of containers with Proxmox Backup Server as target, just like > for the advanced backup job options introduced by commit 3b21f19f > ("www: advanced backup: add pbs

[pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Christoph Heiss
It's been the preferred mailing list archive for some time now. Signed-off-by: Christoph Heiss --- getting-help.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 06a25c2..e53592d 100644 --- a/getting-help.adoc +++ b/getting-

[pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
Allow to select the change detection mode when performing manual backups of containers with Proxmox Backup Server as target, just like for the advanced backup job options introduced by commit 3b21f19f ("www: advanced backup: add pbs change detection mode selector"). The selector is only shown in t

[pve-devel] [PATCH installer v2 1/5] proxinstall: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest master * adapted html te

[pve-devel] [PATCH installer v2 5/5] auto: add negative tests for root password option

2024-11-29 Thread Christoph Heiss
Extends our "test runner" for the parse-answer tests such that if a test file ends with ".fail.toml", it is considered a negative test and expected to fail. The expected error message is stored in the accompanying .fail.json file. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch

[pve-devel] [PATCH pve-docs v2 6/8] installation: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index 869a879..0ff

[pve-devel] [PATCH installer v2 4/5] auto: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. While at it, refactor the `InstallRootPassword` struct into an enum, as suggested by Stefan. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-o

[pve-devel] [PATCH proxmox-backup v2 8/8] using-the-installer: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch docs/using-the-installer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/using-the-installer.rst b/docs/using-the-installer.r

[pve-devel] [PATCH pmg-docs v2 7/8] installation: adapt to raised root password length requirement

2024-11-29 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch pmg-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmg-installation.adoc b/pmg-installation.adoc index 4209784..484

[pve-devel] [PATCH installer v2 3/5] common: convert `InstallRootPassword` into an enum

2024-11-29 Thread Christoph Heiss
It's more appropriate for that type of data, since only one of both variants is ever allowed to be set. Makes it also a bit more ergonomic to handle. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * new patch proxmox-auto-installer/src/utils.rs | 15 +++ proxmox-installer-

[pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v2 0/8] raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
This idea came to light while talking with Shannon about #5756 [0]. It is 2024, so raising the minimum length for the root password as entered during the installation from 5 to 8 characters seems very sensible. NIST also recommends a minimum length of 8 characters for passwords [1]. See also the

[pve-devel] [PATCH installer v2 2/5] tui: raise minimum root password length to 8 characters

2024-11-29 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest master * added note abou

[pve-devel] [PATCH stable-7 guest-common] storage tunnel: correctly set disk-import parameters

2024-11-29 Thread Fiona Ebner
From: Fabian Grünbichler according to the schema, else some combinations of migration / guest / storage settings will fail validation: 2024-05-15 11:48:51 ERROR: migration_snapshot: type check ('boolean') failed - got '' since this is client / source side, remote migrations to a remote node wi

Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

2024-11-29 Thread Shannon Sterz
On Tue Nov 26, 2024 at 11:21 AM CET, Thomas Lamprecht wrote: > Am 26.11.24 um 10:27 schrieb Shannon Sterz: > > actually i needed to adapt this to add support for attachments, which > > require reworking the multipart logic a bit too. i can factor that out > > into it's own `proxmox-sendmail` crate

[pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status

2024-11-29 Thread Christian Ebner
Until now, the reported smart value is returned unconditionally, even if the drive might report an `UNKNOWN` status. To allow for better handling of the unknown smart state, also return the utils helper text in that case. This allows for better handling of e.g. conditionally showing the smart value

[pve-devel] applied: [PATCH pve-manager] api: notification targets: fix permission check for POST/PUT

2024-11-29 Thread Thomas Lamprecht
Am 29.11.24 um 09:59 schrieb Lukas Wagner: > This fixes the error: > unknown permission test at /usr/share/perl5/PVE/RPCEnvironment.pm line 536. > (500) > which occured when trying to create or update a notification target. > > The cause was a permission 'check' parameter for the API handlers w

[pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown

2024-11-29 Thread Christian Ebner
Do not allow to open the smart values window by either double clicking the record or clicking the show button, if the selected drives status is unknown. Fetching the smart values for such devices might fail. Devices which do not support this can be, e.g. USB pen drives used as removable datastores

[pve-devel] [PATCH pve-manager] api: notification targets: fix permission check for POST/PUT

2024-11-29 Thread Lukas Wagner
This fixes the error: unknown permission test at /usr/share/perl5/PVE/RPCEnvironment.pm line 536. (500) which occured when trying to create or update a notification target. The cause was a permission 'check' parameter for the API handlers which was nested one level too deep by accident. This