Re: [pve-devel] [PATCH openid 0/1] Make OIDC userinfo endpoint optional

2024-10-02 Thread Thomas Skinner
This is still applicable to the latest master for the referenced repositories. Any movement? On Fri, Aug 30, 2024, 5:34 PM Thomas Skinner wrote: > In the OpenID Connect documentation ( > https://openid.net/specs/openid-connect-core-1_0.html), the > protocol abstract defined in 1.3 states in step

Re: [pve-devel] [PATCH SERIES openid/access-control/docs/manager] fix #4411: add support for openid groups

2024-10-02 Thread Thomas Skinner
This is still applicable to the latest master for the referenced repositories. Any movement? On Sun, Sep 1, 2024, 11:55 AM Thomas Skinner wrote: > This patch series adds support for groups for OpenID logins. > > The following options are implemented: > - Configurable claim for retrieving a lis

[pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-02 Thread Christian Ebner
Fixes rare read corruption issues using the in kernel ceph client. On incomplete read requests, the clean tail flag should make sure to zero fill the remaining bytes for the subrequest. If the iov iterator is not at the correct position, this can however zero fill downloaded data, corrupting the r

Re: [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable

2024-10-02 Thread Aaron Lauterer
a new v5 has been sent https://lore.proxmox.com/pve-devel/20241002131157.227292-1-a.laute...@proxmox.com/T/#t On 2024-07-29 13:55, Aaron Lauterer wrote: since I only incorporated smaller suggested changes, I left the r-b and t-b in place. this version reworks a few parts since v3: incorporat

[pve-devel] [PATCH manager v5 6/7] fix #3893: api: network: add bridge_vids parameter

2024-10-02 Thread Aaron Lauterer
The API itself allows several list separators. The network configuration for bridge_vids expects a space separated list. We therefore convert it initially to a space separated list. Signed-off-by: Aaron Lauterer --- I opted for a comment before the step where we split and reassemble the list with

[pve-devel] [PATCH common v5 1/7] tools: add check_list_empty function

2024-10-02 Thread Aaron Lauterer
In some situations we don't want a total empty list. I opted for a dedicated function instead of integrating it as error in the `split_list` function. It is used in many places and the potential fallout from unintended behavior changes is too big. Signed-off-by: Aaron Lauterer --- changes since:

[pve-devel] [PATCH common v5 3/7] fix #3893: network: add vlan id and range parameter definitions

2024-10-02 Thread Aaron Lauterer
This is one step to make it possible to define the VLAN IDs and ranges for bridges. It is expected to be used in combination with the `-list` magic property. Therefore it defines and checks the validity of a single list item that could just be a single VLAN tag ID or a range. Signed-off-by: Aaron

[pve-devel] [PATCH widget-toolkit v5 4/7] fix #3892: Network: add bridge vids field for bridge_vids

2024-10-02 Thread Aaron Lauterer
The new optional bridge_vids field allows to set that property via the GUI. Since the backend needs to support it, the field needs to be explicitly enabled. For now, Proxmox VE (PVE) is the use case. Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- change

[pve-devel] [PATCH common, widget-toolkit, manager v5 0/7] fix #3893: make bridge vids configurable

2024-10-02 Thread Aaron Lauterer
Since this version reworks a few things, especially in the logic, I dropped the r-b and t-b tags in some patches. The following patch has been dropped as this is handled in the API call itself now. [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator There is n

[pve-devel] [PATCH manager v5 7/7] fix #3893: ui: network: enable bridge_vids field

2024-10-02 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- changes since v4: none v3: none v2: none www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index d27592ce..7bdfb6d9 10

[pve-devel] [PATCH common v5 2/7] inotify: interfaces: check if bridge_vids is truthy instead of defined

2024-10-02 Thread Aaron Lauterer
The old check for defined would also be true if it contained an empty string. By checking its truthyness, an empty string will be falsy and therefore the default value will be used. Signed-off-by: Aaron Lauterer --- changes since: v4: newly added src/PVE/INotify.pm | 2 +- 1 file changed, 1 ins

[pve-devel] [PATCH widget-toolkit v5 5/7] Network: add explanation for bridge vids field

2024-10-02 Thread Aaron Lauterer
Make clear that it affects only out-/inbound traffic and can be used if the underlying physical NICs support only a limited number of VLANs when offloading is possible. Signed-off-by: Aaron Lauterer Reviewed-by: Shannon Sterz --- changes since v4: none v3-follow-up: * reordered inside the patch

Re: [pve-devel] [PATCH installer 0/7] use email regex from HTML spec for validation

2024-10-02 Thread Christoph Heiss
v2 posted: https://lore.proxmox.com/pve-devel/20241002122933.628461-1-c.he...@proxmox.com/ On Tue, May 28, 2024 at 10:13:41AM GMT, Christoph Heiss wrote: > This uses the regex for elements as defined in > the HTML spec to validate emails in the installer. That regex should be > a lot more robust

[pve-devel] [PATCH installer v2 5/7] tui: use email regex from HTML specification for validation

2024-10-02 Thread Christoph Heiss
That regex should be a lot more accurate in what it allows - if it's good enough for the HTML spec, it should be for us too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * move `EMAIL_DEFAULT_PLACEHOLDER` constant to proxmox-installer-common/lib.rs proxmox-installer-common/Cargo.t

[pve-devel] [PATCH installer v2 0/7] use email regex from HTML spec for validation

2024-10-02 Thread Christoph Heiss
This uses the regex for elements as defined in the HTML spec to validate emails in the installer. That regex should be a lot more robust than our current on and cover basically all cases of email addresses that might be encountered in the while. Also, patch #6 adds validation for the auto-install

[pve-devel] [PATCH installer v2 1/7] cargo: convert `anyhow` to workspace dependency

2024-10-02 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Cargo.toml| 2 ++ proxmox-auto-install-assistant/Cargo.toml | 2 +- proxmox-auto-installer/Cargo.toml | 2 +- proxmox-chroot/Cargo.toml | 2 +- proxmox-fetch-answer/Cargo.t

[pve-devel] [PATCH installer v2 7/7] proxinstall: use email regex from HTML specification for validation

2024-10-02 Thread Christoph Heiss
That regex should be a lot more accurate in what it allows - if it's good enough for the HTML spec, it should be for us too. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes Proxmox/Makefile | 1 + Proxmox/Sys.pm | 9 + proxinstall | 3 ++- 3 files changed, 12

[pve-devel] [PATCH installer v2 6/7] auto-installer: validate `global.mailto` answer option

2024-10-02 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * instead of re-using/-naming the `verify_locale_settings()` for the email validation, combine it the with root password validation proxmox-auto-installer/src/utils.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) d

[pve-devel] [PATCH installer v2 4/7] auto-installer: print full anyhow message on failure

2024-10-02 Thread Christoph Heiss
Otherwise, context info is simply lost -- which might contain valuable information for the user. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes proxmox-auto-installer/src/bin/proxmox-auto-installer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxm

[pve-devel] [PATCH installer v2 3/7] auto-installer: drop some unneeded `pub` modifiers

2024-10-02 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes proxmox-auto-installer/src/utils.rs | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src/utils.rs index 45ad222..cc483c9 100644 --- a/proxm

Re: [pve-devel] Fix UTF-8 encoding issue in Tools.pm

2024-10-02 Thread Shannon Sterz
On Sun Sep 29, 2024 at 10:52 AM CEST, =?utf-8?B?SmFtZXMgQnJvd24=?= wrote: > https://github.com/proxmox/pve-common/pull/11 Hi, thanks for your contribution! Please note that the GitHub repositories are read-only and we do not accept pull requests there. Would you mind re-submitting the patches in

Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES

2024-10-02 Thread Shannon Sterz
note that the gui's default is a bit "fake". it pre-sets the field to `x86-64-v2-AES`, but if you click the little "x" next to it, the field will be cleared and if you submit the form like that the default ends up being `kvm64` again. this happens because the final config file does not specify a cp