Re: [pve-devel] [PATCH pve-xtermjs v3] termproxy: allow to use unix sockets for auth requests

2024-07-25 Thread Thomas Lamprecht
On 24/07/2024 13:33, Dietmar Maurer wrote: > Remove ureq, because it does not support unix sockets. > > Signed-off-by: Dietmar Maurer > --- > > Changes sinve v2: > split out the command line help text change into patch: > [PATCH pve-xtermjs] termproxy: fix the command line help text > > Cha

Re: [pve-devel] applied: [PATCH pve-xtermjs] termproxy: fix the command line help text

2024-07-25 Thread Thomas Lamprecht
On 25/07/2024 10:58, Wolfgang Bumiller wrote: > applied, thanks > this was a good stop-gap but as it wasn't much work I followed this up with fixing the implementation. As while it's just a internal tool, it's still nicer to have it behave as all CLI tools: https://git.proxmox.com/?p=pve-xtermjs

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Max Carrara
On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: > Am 25.07.24 um 11:48 schrieb Max Carrara: > > On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: > >> Signed-off-by: Fiona Ebner > > > > Some overall thoughts: > > > > 1. I'm really, really happy to see documentation in this module

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Fiona Ebner
Am 25.07.24 um 15:11 schrieb Fiona Ebner: > Am 25.07.24 um 11:48 schrieb Max Carrara: >> For the specific types we can always then provide helper functions that >> handle common cases that implementors can use. >> >> Extending on my namespace idea above, those helpers could then land in >> e.g. `PV

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Fiona Ebner
Am 25.07.24 um 11:48 schrieb Max Carrara: > On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: >> Signed-off-by: Fiona Ebner > > Some overall thoughts: > > 1. I'm really, really happy to see documentation in this module here, > that's fantastic! :) > > While the contents of the d

Re: [pve-devel] [PATCH storage] volume import: assume target API version is at least 9

2024-07-25 Thread Thomas Lamprecht
For the record, we talked about this in person for a bit with the following outcome: - there was a bit of a misunderstanding w.r.t. my heavy exaggeration for the point's sake, I really did not mean that as accusation at all, but that's now talked out - it's a good point that the package that

Re: [pve-devel] [PATCH qemu-server] resume: bump timeout for query-status

2024-07-25 Thread Fiona Ebner
Sent a v2 improving the commit message with new findings: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064908.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 qemu-server] resume: bump timeout for query-status

2024-07-25 Thread Fiona Ebner
As reported in the community forum [0], after migration, the VM might not immediately be able to respond to QMP commands, which means the VM could fail to resume and stay in paused state on the target. The reason is that activating the block drives in QEMU can take a bit of time. For example, it m

[pve-devel] [PATCH proxmox-perl-rs] update to proxmox-log 0.2

2024-07-25 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- common/src/logger.rs | 4 +--- pmg-rs/Cargo.toml | 2 +- pmg-rs/debian/control | 2 +- pve-rs/Cargo.toml | 2 +- pve-rs/debian/control | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/common/src/logger.rs b/common/src/logger.rs

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-25 Thread Max Carrara
On Tue Jul 23, 2024 at 11:56 AM CEST, Fiona Ebner wrote: > The new_backup_provider() method can be used by storage plugins for > external backup providers. If the method returns a provider, Proxmox > VE will use callbacks to that provider for backups and restore instead > of using its usual backup/

[pve-devel] [PATCH qemu 1/2] update submodule and patches to QEMU 9.0.2

2024-07-25 Thread Fiona Ebner
Most relevant are some fixes for VirtIO and for ARM and i386 emulation. There also is a fix for VGA display to fix screen blanking, which fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=4786 Signed-off-by: Fiona Ebner --- ...d-support-for-sync-bitmap-mode-never.patch | 10 +- ...race-with-c

[pve-devel] [PATCH qemu 2/2] some more stable fixes for QEMU 9.0.2

2024-07-25 Thread Fiona Ebner
Fix the two issues reported in the community forum[0][1], i.e. regression in LSI-53c895a controller and ignored boot order for USB storage (only possible via custom arguments in Proxmox VE), both causing boot failures, and pick up fixes for VirtIO, ARM emulation, char IO device and a graph lock fix

[pve-devel] applied: [PATCH pve-xtermjs] termproxy: fix the command line help text

2024-07-25 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-xtermjs v3] termproxy: allow to use unix sockets for auth requests

2024-07-25 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH docs] docs: fix typos

2024-07-25 Thread Maximiliano Sandoval
Aaron Lauterer writes: > Thanks for this patch. > > A few things need to be changed in the actually commands/API/… definitions as > we > autogenerate the manual pages. > > This is true for any file with `*-synopsis` or `*-opts*` in its name. > > Please send a v2 without the synopsis and opts fil

[pve-devel] [PATCH docs v2] docs: fix typos

2024-07-25 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- Differences from v1: - Remove fixes in automatically generated files ha-manager.adoc| 2 +- notifications.adoc | 12 ++-- pve-faq.adoc | 2 +- pve-firewall.adoc | 2 +- pve-network.adoc | 4 ++-- pvescheduler.adoc | 2 +- pvesdn