--- Begin Message ---
Hello,
We have a need for a non-network based (i.e. hypercall / out-of-band) file
browser for containers and VMs within the pve-manager web UI. I'd like to be
able to select a VM or container, click "More", and choose "File manager" and
then browse the VM or container's fi
Did a quick smoke test of this series by creating an ISO with an answer
file baked in and checking the response via `nc -l`. Review is inline.
Consider this:
Tested-By: Stefan Hanreich
Reviewed-By: Stefan Hanreich
On 7/10/24 15:27, Christoph Heiss wrote:
> This implements a mechanism for post
On 7/10/24 15:27, Christoph Heiss wrote:
> +impl Answer {
> +pub fn from_reader(reader: impl BufRead) -> Result {
> +let mut buffer = String::new();
> +let lines = reader.lines();
> +for line in lines {
> +buffer.push_str(&line.unwrap());
> +bu
On 7/10/24 15:27, Christoph Heiss wrote:
> diff --git a/proxmox-installer-common/src/setup.rs
> b/proxmox-installer-common/src/setup.rs
> index 9131ac9..29137bf 100644
> --- a/proxmox-installer-common/src/setup.rs
> +++ b/proxmox-installer-common/src/setup.rs
> @@ -163,24 +163,29 @@ pub fn install
On 7/10/24 15:27, Christoph Heiss wrote:
> Makes more sense and makes debugging easier.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-auto-installer/tests/parse-answer.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-auto-installer/tests/parse-answer.rs
On 7/10/24 15:27, Christoph Heiss wrote:
> +impl<'de> Deserialize<'de> for FsType {
> +fn deserialize(deserializer: D) -> Result
> +where
> +D: serde::Deserializer<'de>,
> +{
> +let fs: String = Deserialize::deserialize(deserializer)?;
> +
> +match fs.as_str() {
v3 out: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064635.html
On Thu, Jul 11, 2024 at 11:56:37AM GMT, Christoph Heiss wrote:
> Pretty straight forward overall, implements a check for an existing
> `rpool` on the system and ask the user whether they would like to rename
> it, much in
v3 (already) out:
https://lists.proxmox.com/pipermail/pve-devel/2024-July/064635.html
On Thu, May 16, 2024 at 12:28:32PM GMT, Christoph Heiss wrote:
> Pretty straight forward overall, implements a check for an exising
> `rpool` on the system and ask the user whether they would like to rename
> it
Pretty straight forward overall, implements a check for an existing
`rpool` on the system and ask the user whether they would like to rename
it, much in the same way as it works for VGs already.
Without this, the installer would silently create a second (and thus
conflicting) `rpool` and cause a b
As this is an internal option for the low-level installer anyway, no
real functional changes here.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch
Proxmox/Install.pm | 2 +-
Proxmox/Install/Config.pm |
.. much in the same manner as the detection for LVM works.
zpools can only be renamed by importing them with a new name, so
unfortunately the import-export dance is needed.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* skip rename prompt in auto-install mode
Changes v1 -> v2:
* use
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch, split out from patch #1
* rewrote tests to use a pre-defined input instead, thus being able
to enable the tests unconditionally
test/Makefile | 7 -
test/zfs-get-pool-list
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* incorporated Aarons suggestion to use anonymous arrays instead
* added documentation
* renamed parsing function parse_pool_list -> zpool_import_parse_output
* split out tests into separate patch
Prox
with 8.x, the scope of non-"Permissions.Modify"-based ACL update privileges
were reduced (so that users with for example, VM.Allocate on a VM could only
delegate their own privileges, but not arbitrary other ones). that additional
logic had a wrong guard and was accidentally triggered for calls whe
Signed-off-by: Aaron Lauterer
---
vzdump.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/vzdump.adoc b/vzdump.adoc
index 733704b..7625d08 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -205,7 +205,8 @@ contents from disk, whenever possible.
|===
and move the example command from inline to a block
Signed-off-by: Aaron Lauterer
---
vzdump.adoc | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/vzdump.adoc b/vzdump.adoc
index 415742e..733704b 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -149,11 +149,14 @@ Wi
gave it a test on a VM with the GUI installer.
consider this series:
Tested-By: Aaron Lauterer
Reviewed-By: Aaron Lauterer
On 2024-07-11 11:56, Christoph Heiss wrote:
Pretty straight forward overall, implements a check for an existing
`rpool` on the system and ask the user whether they wou
On 2024-07-11 13:23, Fiona Ebner wrote:
Am 11.07.24 um 13:11 schrieb Aaron Lauterer:
Signed-off-by: Aaron Lauterer
---
@fiona please let me know if this works and doesn't introduce wrong
infos.
I think this way the sentence represents better what is happening, as
it is not enabling it, but
Am 11.07.24 um 13:11 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer
> ---
> @fiona please let me know if this works and doesn't introduce wrong
> infos.
> I think this way the sentence represents better what is happening, as
> it is not enabling it, but running that particular backup with
Signed-off-by: Aaron Lauterer
---
@fiona please let me know if this works and doesn't introduce wrong
infos.
I think this way the sentence represents better what is happening, as
it is not enabling it, but running that particular backup with fleecing.
I am also thinking of placing the actual comm
On 2024-07-11 11:37, Christian Ebner wrote:
Add a concise section about what PBS change detection mode is, where
to configure the option and what it affects, including a table with a
description of the modes.
Signed-off-by: Christian Ebner
---
changes since version 2 (thanks @Aaron for the
.. much in the same manner as the detection for LVM works.
zpools can only be renamed by importing them with a new name, so
unfortunately the import-export dance is needed.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* use unique pool id for renaming instead of generating random id
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* incorporated Aaron suggestion to use anonymous arrays instead
* added documentation
* renamed parsing function parse_pool_list -> zpool_import_parse_output
* split out tests into separate patch
Proxmox/Makefile | 1 +
Proxmox/Sys/
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* new patch, split out from patch #1
* rewrote tests to use a pre-defined input instead, thus being able
to enable the tests unconditionally
test/Makefile | 7 -
test/zfs-get-pool-list.pl | 57 +
Pretty straight forward overall, implements a check for an existing
`rpool` on the system and ask the user whether they would like to rename
it, much in the same way as it works for VGs already.
Without this, the installer would silently create a second (and thus
conflicting) `rpool` and cause a b
superseded-by version 3:
https://lists.proxmox.com/pipermail/pve-devel/2024-July/064617.html
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Add a concise section about what PBS change detection mode is, where
to configure the option and what it affects, including a table with a
description of the modes.
Signed-off-by: Christian Ebner
---
changes since version 2 (thanks @Aaron for the suggestions!):
- Incorporated suggested paragraph
On 7/11/24 10:24, Aaron Lauterer wrote:
could we have a short paragraph on where to set these options? Similar
to how it is done in the fleecing section?
Sure, I agree as it is not obvious where to find the configuration
option. Will send a v3 incorporating the suggestions.
Thanks!
___
could we have a short paragraph on where to set these options? Similar
to how it is done in the fleecing section?
a few very nitpicky comments inline:
On 2024-07-10 16:41, Christian Ebner wrote:
Add a concise section about what PBS change detection mode is and
what it affects, including a ta
picked from v6.9.8, the bug can cause lost NFS connections according to
upstream, and possibly corrupt backups according to our user report.
Signed-off-by: Fabian Grünbichler
---
numbered after Fiona's two cherry-picks already on the list, assuming those
will all be applied in one go ;)
...0-SU
30 matches
Mail list logo
