Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Dietmar Maurer
> > As a compromise, maybe we could just add a note to the docs > > that discusses the reliability aspects of 'sendmail' vs 'smtp' > > endpoints? > > > > Sure, for now adding a general hint to the documentation that they are > send one-shot only would be good. Ok for me. __

[pve-devel] [PATCH manager] debian: postinst: copy notifications.cfg from /usr/share/pve-manager

2023-11-09 Thread Lukas Wagner
... instead of using a heredoc in postinst script. Signed-off-by: Lukas Wagner --- Requires "debian: postinst: create notifications.cfg if it does not exist "[1] from the "overhaul notification system, use matchers instead of filters" patch series [1] https://lists.proxmox.com/pipermail/pve-de

[pve-devel] applied: [PATCH installer v3 0/2] fix #4856: tui: bootdisk: use correct defaults in advanced dialog

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 10:40 schrieb Christoph Heiss: > Fixes #4856 [0]. > > Patch #1 is preparatory only, #2 the actual fix. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4856 > > v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058400.html > v2: https://lists.proxmox.com/pipermail/

[pve-devel] applied: [PATCH installer v2] low level: testmode: take path to disk image instead of using /dev/null

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 10:47 schrieb Christoph Heiss: > .. in exactly the same way GUI and TUI installer do, streamlining them. > > Up until now, testing the TUI installer often involved hand-editing the > `run-env-info.json` to put some proper disk sizes > 0 in place. This > makes this process a lot ea

[pve-devel] [PATCH qemu-server 1/1] fix #5033: api: Add target-filename option to move_disk reassign

2023-11-09 Thread Markus Ebner via pve-devel
--- Begin Message --- When the move_disk endpoint is used to reassign a disk image from one vm to another, the target-filename of the image is typically chosen automatically with the known naming schema. This patch adds the optional parameter target-filename, allowing to manually specify a filenam

[pve-devel] [PATCH qemu-server 0/1] Fix #5033: Add target-filename parameter in move_disk endpoint

2023-11-09 Thread Markus Ebner via pve-devel
--- Begin Message --- When using the POST endpoint at /node//storage//content a filename can be specified that will be used for the created image. If said image is then moved from one vm to another vm, the target disk-image has an automatically generated filename with the vm--disk- schema. This pa

Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 13:34 schrieb Lukas Wagner: > On 11/9/23 13:16, Dietmar Maurer wrote: >>> On 11/8/23 16:52, Dietmar Maurer wrote: > This patch series adds support for a new notification endpoint type, > smtp. As the name suggests, this new endpoint allows PVE to talk > to SMTP server d

Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Lukas Wagner
On 11/9/23 13:16, Dietmar Maurer wrote: On 11/8/23 16:52, Dietmar Maurer wrote: This patch series adds support for a new notification endpoint type, smtp. As the name suggests, this new endpoint allows PVE to talk to SMTP server directly, without using the system's MTA (postfix). Isn't this to

Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Dietmar Maurer
> On 11/8/23 16:52, Dietmar Maurer wrote: > >> This patch series adds support for a new notification endpoint type, > >> smtp. As the name suggests, this new endpoint allows PVE to talk > >> to SMTP server directly, without using the system's MTA (postfix). > > > > Isn't this totally unreliable? W

[pve-devel] applied: [PATCH manager v2 1/2] ui: resource tree: limit tooltip to icon and text

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 11:56 schrieb Dominik Csapak: > and exclude the tags for that, since we want the tags to have their own > tooltips > > we use the delegate function of the tooltips for that > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * instead of using a custom tree column class

[pve-devel] applied-series: [PATCH manager v3 1/3] ui: bulk actions: reorder fields

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 11:47 schrieb Dominik Csapak: > to use less vertical space > > also remove the local-storage warning since this is not that helpful > > Signed-off-by: Dominik Csapak > --- > no changes > www/manager6/window/BulkAction.js | 75 +-- > 1 file changed, 4

[pve-devel] [PATCH manager v2 1/2] ui: resource tree: limit tooltip to icon and text

2023-11-09 Thread Dominik Csapak
and exclude the tags for that, since we want the tags to have their own tooltips we use the delegate function of the tooltips for that Signed-off-by: Dominik Csapak --- changes from v1: * instead of using a custom tree column class, use the same delegate mechanism as the next patch www/manage

[pve-devel] [PATCH manager v2 2/2] ui: add tooltips to non-full tags globally

2023-11-09 Thread Dominik Csapak
by using the delegate function of ExtJS' tooltips on the global Workspace element and using the proper css selectors this way, we can limit the tooltips to the non-full ones (in contrast to using data-qtip on the element, which would always be show, even for tags with the 'full' style) Signed-off

Re: [pve-devel] [PATCH manager v2 1/3] ui: bulk actions: reorder fields

2023-11-09 Thread Thomas Lamprecht
Am 08/11/2023 um 16:45 schrieb Dominik Csapak: > to use less vertical space > > also remove the local-storage warning since this is not that helpful > > Signed-off-by: Dominik Csapak > --- > new in v2 > www/manager6/window/BulkAction.js | 75 +-- > 1 file changed, 41

[pve-devel] [PATCH manager v3 2/3] ui: bulk actions: rework filters and include tags

2023-11-09 Thread Dominik Csapak
This moves the filters out of the grid header for the BulkActions and puts them into their own fieldset above the grid. With that, we can easily include a tags filter (one include and one exclude list). The filter fieldset is collapsible and shows the active filters in parenthesis. aside from that

[pve-devel] [PATCH manager v3 1/3] ui: bulk actions: reorder fields

2023-11-09 Thread Dominik Csapak
to use less vertical space also remove the local-storage warning since this is not that helpful Signed-off-by: Dominik Csapak --- no changes www/manager6/window/BulkAction.js | 75 +-- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/www/manager6/windo

[pve-devel] [PATCH manager v3 3/3] ui: bulk actions: add clear filters button

2023-11-09 Thread Dominik Csapak
to be able to clear all of them at once Signed-off-by: Dominik Csapak --- no changes www/manager6/window/BulkAction.js | 26 ++ 1 file changed, 26 insertions(+) diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js index 1ffc7538..5f76ef7a 1

Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Lukas Wagner
On 11/8/23 16:52, Dietmar Maurer wrote: This patch series adds support for a new notification endpoint type, smtp. As the name suggests, this new endpoint allows PVE to talk to SMTP server directly, without using the system's MTA (postfix). Isn't this totally unreliable? What if the server resp

[pve-devel] [PATCH installer v2] low level: testmode: take path to disk image instead of using /dev/null

2023-11-09 Thread Christoph Heiss
.. in exactly the same way GUI and TUI installer do, streamlining them. Up until now, testing the TUI installer often involved hand-editing the `run-env-info.json` to put some proper disk sizes > 0 in place. This makes this process a lot easier. Signed-off-by: Christoph Heiss --- v1: https://lis

[pve-devel] [PATCH installer v3 0/2] fix #4856: tui: bootdisk: use correct defaults in advanced dialog

2023-11-09 Thread Christoph Heiss
Fixes #4856 [0]. Patch #1 is preparatory only, #2 the actual fix. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4856 v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058400.html v2: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058452.html Changes v1 -> v2: * rebased s

[pve-devel] [PATCH installer v3 2/2] fix #4856: tui: bootdisk: use correct defaults in advanced dialog

2023-11-09 Thread Christoph Heiss
The size of the install disk was set to the size of the first disk, regardless of what disk was selected. This only happened if the advanced options dialog was never opened, and only a disk was selected in the main bootdisk dialog. Properly solving this involved restructuring the LVM advanced boot

[pve-devel] [PATCH installer v3 1/2] tui: bootdisk: refactor Rc> type into custom type

2023-11-09 Thread Christoph Heiss
Will be used/passed around quite a lot of times due to future changes, so simplify it a bit. No functional changes. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/proxmox-tui-install

[pve-devel] [PATCH pve-network] sdn: allow deletion of empty subnet with gateway

2023-11-09 Thread Stefan Lendl
If the gateway IP is last remaining IP in the subnet (in IPAM), allow deleting the subnet. Signed-off-by: Stefan Lendl --- src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm b/src/PVE

Re: [pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering

2023-11-09 Thread Christian Ebner
Ping, still applies > On 09.08.2023 12:55 CEST Christian Ebner wrote: > > > This series is send to pmg-devel and pve-devel list, as it changes the > DateTimeField used by Proxmox Virtual Environment and Proxmox Mail > Gateway. > > This series of patches implements functionality to extend the

Re: [pve-devel] [WIP v2 pve-network 05/10] dhcp: add DHCP plugin for dnsmasq

2023-11-09 Thread Stefan Hanreich
On 11/8/23 18:18, DERUMIER, Alexandre wrote: > Also, currently, I'm not sure why we need to define the dhcp in > /etc/pve/sdn/dhcp.cfg ? > > couldn't we simply add something like : "dhcp:1" or "dhcp:dnsmasq" on > the zone ? That sounds like a good idea and would simplify stuff a lot. I'll tr

Re: [pve-devel] [PATCH v2 qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-09 Thread Fiona Ebner
Am 08.11.23 um 15:28 schrieb Hannes Dürr: >> >> Can we do the check before creating the drive instead? We know if it's a >> CD or pass-through and the path or if it's iscsi ahead of time and that >> should be enough for the check, or what am I missing? > I don't think its possible to check in advan

Re: [pve-devel] [PATCH manager 1/2] ui: resource tree: limit tooltip to icon and text

2023-11-09 Thread Dominik Csapak
mhmm.. disregard these patches for now, instead of creating a custom class we can use the delegate from the tooltip (like in the second patch) and i want to check the performance of the second patch before it get's applied (if it's too bad, we can apply the technique only for the scope we need)